From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C960BC25B06 for ; Tue, 9 Aug 2022 06:42:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238367AbiHIGmi (ORCPT ); Tue, 9 Aug 2022 02:42:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237760AbiHIGmf (ORCPT ); Tue, 9 Aug 2022 02:42:35 -0400 Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 411F9201AC; Mon, 8 Aug 2022 23:42:33 -0700 (PDT) Received: from [192.168.0.2] (ip5f5aecbd.dynamic.kabel-deutschland.de [95.90.236.189]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id D747D61EA192A; Tue, 9 Aug 2022 08:42:29 +0200 (CEST) Message-ID: <6d1576c9-f105-2aff-4497-2c2e7bed2f3b@molgen.mpg.de> Date: Tue, 9 Aug 2022 08:42:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Referencing non-public datasheets in commit messages (was: [PATCH v12 3/3] EDAC: nuvoton: Add NPCM memory controller driver) To: Borislav Petkov Cc: medadyoung@gmail.com, KWLIU@nuvoton.com, tony.luck@intel.com, rric@kernel.org, benjaminfair@google.com, linux-edac@vger.kernel.org, KFTING@nuvoton.com, avifishman70@gmail.com, venture@google.com, openbmc@lists.ozlabs.org, JJLIU0@nuvoton.com, ctcchien@nuvoton.com, tali.perry1@gmail.com, devicetree@vger.kernel.org, robh+dt@kernel.org, james.morse@arm.com, YSCHU@nuvoton.com, mchehab@kernel.org, linux-kernel@vger.kernel.org, tmaimon77@gmail.com References: <20220610084340.2268-1-ctcchien@nuvoton.com> <20220610084340.2268-4-ctcchien@nuvoton.com> Content-Language: en-US From: Paul Menzel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Borislav, Am 20.06.22 um 21:20 schrieb Borislav Petkov: > On Fri, Jun 10, 2022 at 04:43:40PM +0800, medadyoung@gmail.com wrote: […] >> Datasheet: >> Cadence DDR Controller Register Reference Manual For DDR4 Memories >> Chapter 2: Detailed Register Map > > If that datasheet is not public, no need to mention it here. At least a > quick web search cannot find something relevant. Maybe it could be denoted, that is not public (and also the version), but even mentioning non-public datasheets is useful, as they could be made public in the future, and allows everyone to contact people with access to these datasheets to take a look into the specific datasheet. Kind regards, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06C99C19F2D for ; Tue, 9 Aug 2022 06:43:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4M23RZ308Kz304m for ; Tue, 9 Aug 2022 16:43:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=molgen.mpg.de (client-ip=141.14.17.11; helo=mx1.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de; receiver=) Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4M23R40HRrz2xH8 for ; Tue, 9 Aug 2022 16:42:37 +1000 (AEST) Received: from [192.168.0.2] (ip5f5aecbd.dynamic.kabel-deutschland.de [95.90.236.189]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id D747D61EA192A; Tue, 9 Aug 2022 08:42:29 +0200 (CEST) Message-ID: <6d1576c9-f105-2aff-4497-2c2e7bed2f3b@molgen.mpg.de> Date: Tue, 9 Aug 2022 08:42:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Referencing non-public datasheets in commit messages (was: [PATCH v12 3/3] EDAC: nuvoton: Add NPCM memory controller driver) To: Borislav Petkov References: <20220610084340.2268-1-ctcchien@nuvoton.com> <20220610084340.2268-4-ctcchien@nuvoton.com> Content-Language: en-US From: Paul Menzel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: KWLIU@nuvoton.com, tony.luck@intel.com, rric@kernel.org, benjaminfair@google.com, devicetree@vger.kernel.org, avifishman70@gmail.com, venture@google.com, openbmc@lists.ozlabs.org, JJLIU0@nuvoton.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, tali.perry1@gmail.com, KFTING@nuvoton.com, ctcchien@nuvoton.com, james.morse@arm.com, medadyoung@gmail.com, YSCHU@nuvoton.com, mchehab@kernel.org, tmaimon77@gmail.com, linux-edac@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Dear Borislav, Am 20.06.22 um 21:20 schrieb Borislav Petkov: > On Fri, Jun 10, 2022 at 04:43:40PM +0800, medadyoung@gmail.com wrote: […] >> Datasheet: >> Cadence DDR Controller Register Reference Manual For DDR4 Memories >> Chapter 2: Detailed Register Map > > If that datasheet is not public, no need to mention it here. At least a > quick web search cannot find something relevant. Maybe it could be denoted, that is not public (and also the version), but even mentioning non-public datasheets is useful, as they could be made public in the future, and allows everyone to contact people with access to these datasheets to take a look into the specific datasheet. Kind regards, Paul