* [PATCH] target/sh4: Use lookup_symbol in sh4_tr_disas_log
@ 2021-09-29 13:03 Richard Henderson
2021-09-29 13:42 ` Philippe Mathieu-Daudé
2021-09-29 15:03 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2021-09-29 13:03 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, ysato
The correct thing to do has been present but commented
out since the initial commit of the sh4 translator.
Fixes: fdf9b3e831e
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/sh4/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index cf5fe9243d..d363050272 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -2344,7 +2344,7 @@ static void sh4_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)
static void sh4_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs)
{
- qemu_log("IN:\n"); /* , lookup_symbol(dcbase->pc_first)); */
+ qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first));
log_target_disas(cs, dcbase->pc_first, dcbase->tb->size);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target/sh4: Use lookup_symbol in sh4_tr_disas_log
2021-09-29 13:03 [PATCH] target/sh4: Use lookup_symbol in sh4_tr_disas_log Richard Henderson
@ 2021-09-29 13:42 ` Philippe Mathieu-Daudé
2021-09-29 15:03 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-29 13:42 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-trivial, ysato
On 9/29/21 15:03, Richard Henderson wrote:
> The correct thing to do has been present but commented
> out since the initial commit of the sh4 translator.
>
> Fixes: fdf9b3e831e
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/sh4/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/sh4: Use lookup_symbol in sh4_tr_disas_log
2021-09-29 13:03 [PATCH] target/sh4: Use lookup_symbol in sh4_tr_disas_log Richard Henderson
2021-09-29 13:42 ` Philippe Mathieu-Daudé
@ 2021-09-29 15:03 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-09-29 15:03 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: qemu-trivial, ysato
Le 29/09/2021 à 15:03, Richard Henderson a écrit :
> The correct thing to do has been present but commented
> out since the initial commit of the sh4 translator.
>
> Fixes: fdf9b3e831e
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/sh4/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/sh4/translate.c b/target/sh4/translate.c
> index cf5fe9243d..d363050272 100644
> --- a/target/sh4/translate.c
> +++ b/target/sh4/translate.c
> @@ -2344,7 +2344,7 @@ static void sh4_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs)
>
> static void sh4_tr_disas_log(const DisasContextBase *dcbase, CPUState *cs)
> {
> - qemu_log("IN:\n"); /* , lookup_symbol(dcbase->pc_first)); */
> + qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first));
> log_target_disas(cs, dcbase->pc_first, dcbase->tb->size);
> }
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-29 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-29 13:03 [PATCH] target/sh4: Use lookup_symbol in sh4_tr_disas_log Richard Henderson
2021-09-29 13:42 ` Philippe Mathieu-Daudé
2021-09-29 15:03 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.