diff for duplicates of <6d291eba-1055-51c3-f015-d029a434b2c0@ozlabs.ru>
diff --git a/a/1.txt b/N1/1.txt
index 3eda27a..cee2753 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -27,12 +27,12 @@ On 5/25/22 11:52, Alexey Kardashevskiy wrote:
>>> kvm_ioctl_create_device() already checks for ops->init() so I guess
>>> kvm_device_ops are expected to not have certain handlers.
>>
->> Oof. IMO, ->destroy() should be mandatory in order to pair with
+>> Oof. IMO, ->destroy() should be mandatory in order to pair with
>> ->create().
After reading
-https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2bde9b3ec8bdf60788e9e
+https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id+de9b3ec8bdf60788e9e
and neighboring commits, it sounds that each create() should be paired
with either destroy() or release() but not necessarily both.
@@ -46,7 +46,7 @@ So I'm really not sure dummy handlers is a good idea. Thanks,
>
> Huh it used to be release() actually, nice:
>
-> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5422e95103cf9663bc
+> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?idT22e95103cf9663bc
>
>
>> A nop/dummy ->destroy() would be a good place to further document
@@ -56,7 +56,7 @@ So I'm really not sure dummy handlers is a good idea. Thanks,
>> obvious.
>
> I could probably borrow some docs from here:
-> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6f868405faf067e8cfb
+> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?ido868405faf067e8cfb
>
>
> Thanks for the review! At very least I'll add the dummies.
diff --git a/a/content_digest b/N1/content_digest
index 96abd20..4f6705d 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -14,7 +14,7 @@
"Subject\0Re: [PATCH kernel] KVM: Don't null dereference ops->destroy\0"
]
[
- "Date\0Wed, 25 May 2022 12:58:41 +1000\0"
+ "Date\0Wed, 25 May 2022 02:58:41 +0000\0"
]
[
"To\0Sean Christopherson <seanjc\@google.com>\0"
@@ -60,12 +60,12 @@
">>> kvm_ioctl_create_device() already checks for ops->init() so I guess\n",
">>> kvm_device_ops are expected to not have certain handlers.\n",
">>\n",
- ">> Oof.\302\240 IMO, ->destroy() should be mandatory in order to pair with \n",
+ ">> Oof.\303\202\302\240 IMO, ->destroy() should be mandatory in order to pair with \n",
">> ->create().\n",
"\n",
"\n",
"After reading\n",
- "https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2bde9b3ec8bdf60788e9e \n",
+ "https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id+de9b3ec8bdf60788e9e \n",
"and neighboring commits, it sounds that each create() should be paired \n",
"with either destroy() or release() but not necessarily both.\n",
"\n",
@@ -79,7 +79,7 @@
"> \n",
"> Huh it used to be release() actually, nice:\n",
"> \n",
- "> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5422e95103cf9663bc\n",
+ "> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?idT22e95103cf9663bc\n",
"> \n",
"> \n",
">> A nop/dummy ->destroy() would be a good place to further document \n",
@@ -89,7 +89,7 @@
">> obvious.\n",
"> \n",
"> I could probably borrow some docs from here:\n",
- "> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6f868405faf067e8cfb\n",
+ "> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?ido868405faf067e8cfb\n",
"> \n",
"> \n",
"> Thanks for the review! At very least I'll add the dummies.\n",
@@ -108,4 +108,4 @@
"Alexey"
]
-bf8dd69295dfb8fb5b63d15137a58d67f809e5548fe0cfaa1b17b393b8122a82
+692b8fff16f986dcdf4ba90404e3d42c9c72eb7559085653272843efaf1142b8
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.