From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDDF6C4320A for ; Fri, 27 Aug 2021 19:52:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B688460FE6 for ; Fri, 27 Aug 2021 19:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231309AbhH0TxB (ORCPT ); Fri, 27 Aug 2021 15:53:01 -0400 Received: from mxout03.lancloud.ru ([45.84.86.113]:33520 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbhH0TxA (ORCPT ); Fri, 27 Aug 2021 15:53:00 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru DF08720E99AE Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH net-next 12/13] ravb: Factorise ravb_emac_init function To: Biju Das , "David S. Miller" , Jakub Kicinski CC: Lad Prabhakar , Andrew Lunn , Sergei Shtylyov , "Geert Uytterhoeven" , Adam Ford , Yoshihiro Shimoda , , , Chris Paterson , Biju Das References: <20210825070154.14336-1-biju.das.jz@bp.renesas.com> <20210825070154.14336-13-biju.das.jz@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <6d2a7dfa-94e7-bdc5-f437-8656c9921f29@omp.ru> Date: Fri, 27 Aug 2021 22:52:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210825070154.14336-13-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/25/21 10:01 AM, Biju Das wrote: > The E-MAC IP on the R-Car AVB module has different initialization > parameters for RX frame size, duplex settings, different offset > for transfer speed setting and has magic packet detection support > compared to E-MAC on RZ/G2L Gigabit Ethernet module. Factorise > the ravb_emac_init function to support the later SoC. Again, couldn't we resolve these differencies like the sh_eth driver does, by adding the register values into the *struct* ravb_hw_info? > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar [...] MBR, Sergey