All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	"Christoph Hellwig" <hch@lst.de>, <linux-block@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Sagi Grimberg <sagi@grimberg.me>, Daniel Wagner <dwagner@suse.de>,
	Wen Xiong <wenxiong@us.ibm.com>, "Hannes Reinecke" <hare@suse.de>
Subject: Re: [PATCH V5 2/3] blk-mq: mark if one queue map uses managed irq
Date: Wed, 21 Jul 2021 19:53:22 +0100	[thread overview]
Message-ID: <6d2e0c81-6efd-69eb-7b00-85565533e5b4@huawei.com> (raw)
In-Reply-To: <20210721091723.1152456-3-ming.lei@redhat.com>

On 21/07/2021 10:17, Ming Lei wrote:

FWIW,

Reviewed-by: John Garry <john.garry@huawei.com>

> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
> index 1d18447ebebc..d54a795ec971 100644
> --- a/include/linux/blk-mq.h
> +++ b/include/linux/blk-mq.h
> @@ -192,7 +192,8 @@ struct blk_mq_hw_ctx {
>   struct blk_mq_queue_map {
>   	unsigned int *mq_map;
>   	unsigned int nr_queues;
> -	unsigned int queue_offset;
> +	unsigned int queue_offset:31;
> +	unsigned int use_managed_irq:1;

late nit: I'd be inclined to call this "drain_hw_queue" or similar, 
which is what it means to blk-mq

>   };

Thanks

  parent reply	other threads:[~2021-07-21 18:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21  9:17 [PATCH V5 0/3] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-07-21  9:17 ` [PATCH V5 1/3] driver core: add device_has_managed_msi_irq Ming Lei
2021-07-21 13:48   ` Greg Kroah-Hartman
2021-07-21 14:36   ` Christoph Hellwig
2021-07-21  9:17 ` [PATCH V5 2/3] blk-mq: mark if one queue map uses managed irq Ming Lei
2021-07-21 14:37   ` Christoph Hellwig
2021-07-22  1:24     ` Ming Lei
2021-07-21 18:53   ` John Garry [this message]
2021-07-22  1:22     ` Ming Lei
2021-07-21  9:17 ` [PATCH V5 3/3] blk-mq: don't deactivate hctx if managed irq isn't used Ming Lei
2021-07-21 14:37   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d2e0c81-6efd-69eb-7b00-85565533e5b4@huawei.com \
    --to=john.garry@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    --cc=tglx@linutronix.de \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.