From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C04B6C433EF for ; Mon, 28 Mar 2022 15:37:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 588BF83C91; Mon, 28 Mar 2022 17:37:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=seco.com header.i=@seco.com header.b="iiklEE4z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0B0F683C91; Mon, 28 Mar 2022 17:37:24 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on0618.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0d::618]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8FF1F83B99 for ; Mon, 28 Mar 2022 17:37:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ChOzbj1AOWLYjZnLsoMpYaLO5a8vlsrySA56hInT+RinWMLezfsK8JTzDp5PuuzXV6VJ2Xs6hg1fJjjyY+0WJWBOBnZPAnxFbrpUbmLR1SsFvNA7AaePGrgXOWCWqRvObB+I6yG9JYgFY7C2ukxZTkNtnhZGdXROUMxMPSrO0s7iPmmBOGz5caFMCO6z0513Yrh6OexeZlIqFxnxi8QkMrqofWXpCDQemDnuTGYMakkHh39A+7emxLHA3kVDnuiFEXw035gkYKU+onWCngnM6ooy3hZsN0yAsUq/2d33G1Phh0VtK/Afq+D1LBx29kNbyjT/msqiFNElFdOkIQcGwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SWUruIOtr2H3/5U2pEBGXEDApb8Xz6cFdtzwf/sl1/Y=; b=m50U387ovY/eX16sp7vERRxryNgLf7W02+Fr3iOYAAD73/aFV7F0Vlo3ayyoz6w7sihlRDIt/banIE4n+rCZMstbOWdW1haqnyCw3YBvorBL+HydiijHsNDvEEiE0J/8mAADlR8p+tc14QPcB/7I2CO1CHW+JIQc7AWn8ZyZw6o8LcEri7kew97HbB0CTp7dnQqNVQei7Rd5woJrFIEUbLMI/lLMRJ9O65Yz1wcuCbFzdi+DE+lxHHet3U0oajngyefsBk4vdn/3haS7L5no+UbIvLLOf3I57HBCKXKHGSCJu1n7wQ7705JJu+xH1d2FHV4Wdx5EZw9P3fxCdr7eTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SWUruIOtr2H3/5U2pEBGXEDApb8Xz6cFdtzwf/sl1/Y=; b=iiklEE4zTrapPEywzs79Suxp8h1/tzOC+N6E/aUQkD/Y4CaNqNLFkb4Vsm24o7UlW79nZmsSBFLGxcjwbGAYoNLHheuJrxEsDRKvRAgdcJjyNN3oULo4diXvHgVSrHRhQI9J16x883UNJwnDNU2wSvBVvNDICaPdcyTMkP/V0jvYkUD1Omjf6zwjQEtaFFDU1d6op6uhg1ikT/n1nvyqPHEOVNbrT+4RenT4GE0CKj1Ta20EhL+NMChEHxADwhRMlIhdpqora0trhmZ8mh4FNNDUzkW/ZFWKgNmiJD+AVuk3g+8ejacJz/ZOsDpe2jQwUby0+Gg93QnV3RbmzBoMtQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) by PR3PR03MB6427.eurprd03.prod.outlook.com (2603:10a6:102:7b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.22; Mon, 28 Mar 2022 15:37:20 +0000 Received: from DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::356c:789f:d20f:92bc]) by DB7PR03MB4972.eurprd03.prod.outlook.com ([fe80::356c:789f:d20f:92bc%7]) with mapi id 15.20.5102.022; Mon, 28 Mar 2022 15:37:20 +0000 Subject: Re: [PATCH v3 28/29] test: serial: Add test for putc/puts To: Simon Glass Cc: Tom Rini , Linus Walleij , Liviu Dudau , Andre Przywara , U-Boot Mailing List References: <20220322205938.1721846-1-sean.anderson@seco.com> <20220322205938.1721846-29-sean.anderson@seco.com> From: Sean Anderson Message-ID: <6d341276-706e-3d7b-d30e-f35b68b96a96@seco.com> Date: Mon, 28 Mar 2022 11:37:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL0PR02CA0071.namprd02.prod.outlook.com (2603:10b6:207:3d::48) To DB7PR03MB4972.eurprd03.prod.outlook.com (2603:10a6:10:7d::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6495ece-f37f-43ce-43df-08da10d0d8a9 X-MS-TrafficTypeDiagnostic: PR3PR03MB6427:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q18AteSU3MfR6G810ovI1/r1tdeaAu+P97ux9gWoPlyVqTaMYojkiycAERXHBuglWqM1VD+cGMkLYrNvR5GRZTb2JCPvEppXH/BMxMjHVq49AMI99d1ndRakdb3hVDjN3oZOCcd5CMe3Rfid2rBHvO3X350f3D4PJM05y4FMUwd/j4LOuOOP5SMiLvt6YO8MZgAkX8bzE9o3PLaUWIPZ826PqFhXYorYfDfOa08/Uvaj9UxOkeDaHOJ5rqLbqv2Tr5KR07cDBml0CzPmTOjSDz9xJ9K0jboNEwM87TqHoOaue8cv4kFfYajxLjTb3n3Af7mBEGfa9crQvkXfZPZYTkIguaIdphmX7yPZ/7/QkCcvCItrnJU1KufAwFSPVvlRPycyRiGlzqKGByLjORMteiCo0PilzUJUZX+CJZP/5vTksS378JoApugCGVo7hOj+n3Ica5JU22ML3N8i1MDPOn0zRff5W5dYWuDxZylOh0BhtSN+zsAVL775ixxS3UlPmM5yvhbVRgV/FnWFEmyGHQbeCOvUkRuxrX9tQChTI78+LSv7U4dar70XumXkXjKBa0XF/bKAyftUQUKFL/V/201om7mJxaQvQ7VO4TAXhV5MW4Kt0oi8FpUCSPp3pGVmE9wK4ppKnfWZfEp7vDEWKvtvYWo+/003xYns4UHWhQ6W/EJaIdiZ59phaz7FFazagk4Jf3tMQ0B/tQEYnLvQnYAinn465ZA2beW23iwPw79kUadgSgViZW6Y+8tabzxjd+qB4p5nlpUHCoVx/KnKRg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4972.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38350700002)(6486002)(6916009)(26005)(186003)(508600001)(8676002)(38100700002)(6666004)(54906003)(6506007)(66946007)(2616005)(4326008)(31696002)(5660300002)(83380400001)(8936002)(66556008)(66476007)(36756003)(52116002)(86362001)(44832011)(2906002)(53546011)(6512007)(31686004)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUxCM05ob0QyT0NZWXBiQXo1azVBME1LbUN5YUNMUkZvRVcwano4MDViVGpS?= =?utf-8?B?elpWQ3d2dHZUVTh6Zmo2UDZwRm53dk5tRk9kRHZpR1RETVY1bEg4b2h2RTk0?= =?utf-8?B?ZTJPNUJXQ251TTBLbEdlNzBadEVFdTlYdHRMKy9VbjdaWEFVUCtpVm9wY3By?= =?utf-8?B?UGJnanpmRGd0Nmc0Q2xNWTJ0NzlnRGMyVFNibThMa0tvcXlxT1gzNTk2eWE1?= =?utf-8?B?aVFONXhkOG9zWmJiZXh6N2pBQVl5VUtwUUhsRTkyMkFrNnVQRGRPYjM2SEMx?= =?utf-8?B?c20rbGdQT1B6NGRqTDJrV3pUb09lSDBMQnF5TTF2TWNjUVZWdVZPbGJOeHlJ?= =?utf-8?B?ZzVkVU9HSll6MmVJbXcwYTRvQjQ5WkU5NnNvYkJ3dWU3cGRqbTBBRktrVWY4?= =?utf-8?B?MFErS1NoNFRCOWJpRHJ4WVFaSkMwR05uWU04Z3VrWGs3b0pGUUpZWU5VaTE5?= =?utf-8?B?cEtRSG8zbGVwWHU2NWN5LzlnTEJtM1h5UHZ6ZWNWZG9BeThlS2lhYjVJTExI?= =?utf-8?B?Z29hNnhmeFBoLy9MRGN6OXg2TUxRM2Z1V2Y5TTZjejQwN1FuT2JVTHZXNEQx?= =?utf-8?B?NHVsQzFiK2M2clp1RFE0clFnYlVQNng4em9TSTB3NlVFcTVmWVduK0Q1V0JL?= =?utf-8?B?WTBlanRRQlMyaGxlbHM4NW1ZOEF4ZGs5NEVFUkFzcDc1UndxM21jaGIxVUJW?= =?utf-8?B?TTBhazRxYit4UVRpWUIxaW5mdUhqS1JPZXdUYjdMUTZpOU1mYUJqODFsZ3dB?= =?utf-8?B?OHV2WklJbWIwc1o3UERsbXMzeFQrdGZtaGVWLy9ZN3g0NzNlRjdwZ0YwZFNY?= =?utf-8?B?SzkvN3p4QWZQUzVOMUlpQzlmcnZJTjFIYllyVnRvVzFtQ2tIUjZCMGtIdVh4?= =?utf-8?B?WWxwZW9pTkpkYmhkNzhlaWIyOVdObzYvcjl5dnBRQmw4OVlsSThCdUtSUkc0?= =?utf-8?B?S0c3b3RsTm93aFk5Rm5pWTdkd1Z3QkxBeWhML29yeU0wekZ4SEVLSGNZT0R6?= =?utf-8?B?bUdGRUorWVViTVc4VEg2SXdMZGo2a3ZkN0UvRkZ2WU1tY2tKbnBGbktqYnBs?= =?utf-8?B?QlZwZ0NkUzFiVHJZSXJKQnR0VFZjNWQyemYrY1dmV3JBZDFZZ1R2cnYxcmpn?= =?utf-8?B?RlhlUFRlaXlYaklDa3lJTjd3QUtKWlRoQWhzQ1dGbzFBejlBSVl6L2YyWE16?= =?utf-8?B?emV4TGxLcnVZNHBMV2RQY3BJeDJEVkFmRUVOS3V5d21KRmJySlBLNWYzK2Fz?= =?utf-8?B?d0xTQktHSEFRNnNHeVoyODF1NzBrVGFjbHRxakpKL1B4T1NhNVQ0cWxOVDZP?= =?utf-8?B?RmVFcFhwMHVENUZVMDhEdTVWdUZqZlk5OWdYVXQ1TU92UEdpUHZmWkd2bmNF?= =?utf-8?B?YUxnV1RjUjFhMFdZeThTcVRQZ3NWYW5uT0VORDliQi9QdU83K1h4SVRRSFJF?= =?utf-8?B?cFNSb3E1WVRDaFBUSVpJWmtKbWxCVVk1bVhWWkp0SkQxbStxUldVTUt4OHli?= =?utf-8?B?MjdWREl2WEZ1TlVSM1I3cmNBSEJiRFJQQVo2c2dkUEVSeGVuMjB5TkY2RlVC?= =?utf-8?B?TkZ6dDhNSEFsYTh5elFMK0dKSFM3M3RsOWthc1JDdDdnOWZNbSt6QVppQjJG?= =?utf-8?B?ZFYvKzZzamwwaElEbGI4OFo5c3I4OVU3dWlZWkp5SERKYWdGaWttTXpoNk5V?= =?utf-8?B?YUhDNC90UDU3dEZ4TXlZZDhsdDQxMFFNaDJKMGt1TTVrb3RsTll4Mm1LOTdo?= =?utf-8?B?b1dwWjdmOTFOaUxTUUlBK3Q3OGdUWDRnM1lCWGVIMk8xT1Nyby9JQ2gwU0pU?= =?utf-8?B?ejIwMDh6YVlCQmNwQi9IUUpUNm1mUjJ1U2tXMUVzd0dBa3ArdWRQYUlVWE5Y?= =?utf-8?B?RkY4QlEycUszelNZaHI3V2c4Z0Rja2thN1lpdUhKekwwb2xVbUFqbHEvRm5G?= =?utf-8?B?c1R6YXFRMjVPZzZqc0dzdFVJQ2g4amgxalZmRkRaM1ZYOWJIVklvSS9OQ29q?= =?utf-8?B?SHBUdTE4WGNiK1pKOVNoZE5aVXlYcHhNWlNrbjFRRG5ja0pmZkhzRVZzMEFp?= =?utf-8?B?bk1zRE1RSnI2czcxSDFJNDk5bHhveC9uY0FpbEVGaURmRmdSMTd4WUZuQXZH?= =?utf-8?B?WmVxSDJZQy92QmYreXVpUVBGVThQVXFsZGVHTTl3WkdsZnVyQzhzdjNDS2t5?= =?utf-8?B?SXd4d2lJendKTzJPSjhmend2bEFrejh5VVdFdTZZSGlDdkpWVGxKbkMvME81?= =?utf-8?B?WTA4bktKNDRsaXV4cldPTlkzcjRabGFTMzN6ci8xM3VlT1A0ZDZTTmJPRDZa?= =?utf-8?B?S1Q4YmpTcFJremttVWZOa3huMFZLRW93NkZoMlQ4U25xOTgvcVdsR2c3b0NJ?= =?utf-8?Q?t+Rg2PFjsoVvwpvQ=3D?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6495ece-f37f-43ce-43df-08da10d0d8a9 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 15:37:20.5403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NUR1yLmryKwh6/HiLqux/QNi7XsUAMpcogBs+S6mpnncM758NVH0eSxAVyaDNiDxCzZVWbocMO9o/7nbVdm0iA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6427 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/28/22 2:35 AM, Simon Glass wrote: > Hi Sean, > > On Tue, 22 Mar 2022 at 15:00, Sean Anderson wrote: >> >> This adds a test to ensure that puts is equivalent to putc called in a >> loop. We don't verify the contents of the message to avoid having to >> record console output a second time (though that could be added in the >> future). The globals are initialized to non-zero values to avoid a >> warning; in particular, the character count is off-by-one (but we always >> make relative measurements). >> >> Signed-off-by: Sean Anderson >> --- >> >> Changes in v3: >> - New >> >> arch/sandbox/include/asm/serial.h | 6 ++++++ >> drivers/serial/sandbox.c | 23 +++++++++++++++++++---- >> test/dm/serial.c | 19 +++++++++++++++++++ >> 3 files changed, 44 insertions(+), 4 deletions(-) > > Reviewed-by: Simon Glass > > But please can you add functions to change sandbox_serial_enabled (and > read from sandbox_serial_written) to asm/test.h since that is how > these sorts of things are done in other drivers. > Sure. --Sean