All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
	Thomas Huth <thuth@redhat.com>,
	berrange@redhat.com, Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose
Date: Thu, 8 Oct 2020 15:21:54 +0200	[thread overview]
Message-ID: <6d6247ef-94f3-3ee3-b0ad-28e870d8dc05@redhat.com> (raw)
In-Reply-To: <1836979.gfKjIU19vi@silver>

On 08/10/20 15:09, Christian Schoenebeck wrote:
>> But doesn't this (and patch 6 as well) break TAP output?  Using
>> g_test_message + g_test_verbose would be the best of both worlds.
> 
> If there was TAP output then yes, patches 4, 5, 6 would probably break it.
> 
> How/when is TAP output enabled? I don't see any TAP output by default.

With "--tap", but with glib 2.62 it will be enabled by default.  For
example on Fedora 32:

  $ ./test-mul64
  # random seed: R02S3efb20d48a41e1897cb761e02393c11b
  1..2
  # Start of host-utils tests
  ok 1 /host-utils/mulu64
  ok 2 /host-utils/muls64
  # End of host-utils tests

I'm okay I guess with using g_test_message on 2.62 or newer, and
assuming people don't use --tap --verbose on older versions.

Paolo

> which is inappropriate for multi-line messages as these proposed patches do.
> 
> Is that actually a real-life problem? I mean these patches only output 
> anything if --verbose CL switch is used, and I don't see any TAP output 
> enabled by default. And the --verbose CL switch is usually just used by 
> developers for debugging test case issues, isn't it?
> 
> Best regards,
> Christian Schoenebeck
> 
> 



  reply	other threads:[~2020-10-08 13:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02 16:15 [PATCH v3 00/11] 9pfs: add tests using local fs driver Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 08/11] tests/9pfs: introduce local tests Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 09/11] tests/9pfs: wipe local 9pfs test directory Christian Schoenebeck
2020-10-08 12:26   ` Christian Schoenebeck
2020-10-08 15:34     ` Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 07/11] tests/9pfs: change qtest name prefix to synth Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 02/11] libqos/qgraph: add qos_node_create_driver_named() Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 10/11] tests/9pfs: add virtio_9p_test_path() Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 04/11] tests/qtest/qos-test: dump qos graph if verbose Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 03/11] libqos/qgraph: add qos_dump_graph() Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose Christian Schoenebeck
2020-10-08 12:37   ` Paolo Bonzini
2020-10-08 13:09     ` Christian Schoenebeck
2020-10-08 13:21       ` Paolo Bonzini [this message]
2020-10-08 13:42         ` Christian Schoenebeck
2020-10-08 13:52           ` Paolo Bonzini
2020-10-08 15:38             ` Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 01/11] libqos/qgraph: add qemu_name to QOSGraphNode Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 06/11] tests/qtest/qos-test: dump QEMU command if verbose Christian Schoenebeck
2020-10-08 12:36   ` Paolo Bonzini
2020-10-08 13:11     ` Christian Schoenebeck
2020-10-02 16:15 ` [PATCH v3 11/11] tests/9pfs: add local Tmkdir test Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d6247ef-94f3-3ee3-b0ad-28e870d8dc05@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=e.emanuelegiuseppe@gmail.com \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.