From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE526C43381 for ; Thu, 7 Mar 2019 08:36:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F32420652 for ; Thu, 7 Mar 2019 08:36:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="wkOYUHAk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726328AbfCGIgc (ORCPT ); Thu, 7 Mar 2019 03:36:32 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:41464 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbfCGIga (ORCPT ); Thu, 7 Mar 2019 03:36:30 -0500 Received: by mail-wr1-f68.google.com with SMTP id n2so16366336wrw.8 for ; Thu, 07 Mar 2019 00:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=z3Ji1GCmHY2z0c9fHAuNCsiL41DSMdKf5/WykyTE3HE=; b=wkOYUHAky5gLl7efprLlqMeFQ06LUYEZa8PXS6u1o2WWlBTorgPmbk0lkQyQi4qoyW CnJPfShl6sLoSLRS076rMcb3fRAA370V42QyLtfGIUrPV2esYF1+9aCKO3GreRmxcRku 5Ufe+bbl3WFtgTrwOt66uAclBY1Pwuwij/cW6lxu4vqhPkf0e5rFJJ8V4RJ4y83XRFZL bVsvkq+SW4gxwOIy4QpdHWM4mhE0WxpDRFQsWDOKZ/RghONGDHeOoPVkmZWasONjwPv7 YmmRNtCzskNTBhlA/iiYkuECu33Hhb1QZtlOPXnOwBOyN3Lfy3DuNbvJ1CR9p8H4ILnJ RNOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=z3Ji1GCmHY2z0c9fHAuNCsiL41DSMdKf5/WykyTE3HE=; b=YFat9YzIxZ8IJdbpNtjBx7tT+cPeULmUyBCNVuGCzIIzCTuUaNJcKjGl1SDKhG5BCu erZIXNlPwUfEB4i3mZNSUTgJPj72C0/t3L5Qn7l7nv/3W2fcvJbQBO+ABThQTldknvnr K72Ymh/dyAeYM8NydrcAnvaks7HOvJmCBVL+exWauOiA5LGCzJJbQ8+tK80+orVJIfHE CO/1B3wMY3bDIgd261Mo4VvrB+A/OETzcT6FqVnZVIDKcyTkNHPvQy7+TtbujkZdEJMk Vc3v7bzr78pCpo8jk0KgYpM0BzJaf1uWwkVoOT8WLcNzPXfobLkSwjbtdc6F7Sivk8k+ e5yg== X-Gm-Message-State: APjAAAX5NKtImb/RDaPqdrilxY7wEAMLSC5woE2D12+2bx+gvT4JnifC 9hP+dNFDa9a/AZ8D/OqAKs6Jng8nJQru7w== X-Google-Smtp-Source: APXvYqw6rYK2BGt/nKVRRcqc8nZ3JL4G5BdVYpRhjzH6YS8IRm5qVmil+b6tp/qTO/DMqZor+o1IGQ== X-Received: by 2002:adf:fa10:: with SMTP id m16mr1417251wrr.188.1551947788109; Thu, 07 Mar 2019 00:36:28 -0800 (PST) Received: from [10.1.2.12] (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id g15sm5828079wmg.16.2019.03.07.00.36.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 00:36:27 -0800 (PST) Subject: Re: [PATCH v2 4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings To: Martin Blumenstingl Cc: gregkh@linuxfoundation.org, hminas@synopsys.com, balbi@kernel.org, kishon@ti.com, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20190304103846.2060-1-narmstrong@baylibre.com> <20190304103846.2060-5-narmstrong@baylibre.com> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: <6d68648d-d1a6-1352-b787-ee04a49f4eaa@baylibre.com> Date: Thu, 7 Mar 2019 09:36:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2019 22:27, Martin Blumenstingl wrote: > Hi Neil, > > On Mon, Mar 4, 2019 at 11:40 AM Neil Armstrong wrote: >> >> Adds the bindings for the Amlogic G12A USB Glue HW. >> >> The Amlogic G12A SoC Family embeds 2 USB Controllers : >> - a DWC3 IP configured as Host for USB2 and USB3 >> - a DWC2 IP configured as Peripheral USB2 Only >> >> A glue connects these both controllers to 2 USB2 PHYs, >> and optionnally to an USB3+PCIE Combo PHY shared with the PCIE controller. >> >> The Glue configures the UTMI 8bit interfaces for the USB2 PHYs, including >> routing of the OTG PHY between the DWC3 and DWC2 controllers, and >> setups the on-chip OTG mode selection for this PHY. >> >> The PHYs phandles are passed to the Glue node since the Glue controls the >> interface with the PHY, not the DWC3 controller. >> >> Signed-off-by: Neil Armstrong > Reviewed-by: Martin Blumenstingl > > [...] >> + dwc3: usb@ff500000 { >> + compatible = "snps,dwc3"; >> + reg = <0x0 0xff500000 0x0 0x100000>; >> + interrupts = ; >> + dr_mode = "host"; >> + snps,dis_u2_susphy_quirk; >> + snps,quirk-frame-length-adjustment; >> + }; > in v1 of the patch I asked whether we should pass the PHYs which are > connected to the dwc3 controller here as well (instead of only passing > them to the USBCTRL node). > we can still do this later on, the important part is: USBCTRL > interfaces with the PHYs -> that is already part of the binding. Indeed, it's not part of this binding doc, and we can do it if needed. But since the OTG setup is not handled by DWC3, there is no real use. Neil > > > Regards > Martin > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings From: Neil Armstrong Message-Id: <6d68648d-d1a6-1352-b787-ee04a49f4eaa@baylibre.com> Date: Thu, 7 Mar 2019 09:36:27 +0100 To: Martin Blumenstingl Cc: gregkh@linuxfoundation.org, hminas@synopsys.com, balbi@kernel.org, kishon@ti.com, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-ID: T24gMDYvMDMvMjAxOSAyMjoyNywgTWFydGluIEJsdW1lbnN0aW5nbCB3cm90ZToKPiBIaSBOZWls LAo+IAo+IE9uIE1vbiwgTWFyIDQsIDIwMTkgYXQgMTE6NDAgQU0gTmVpbCBBcm1zdHJvbmcgPG5h cm1zdHJvbmdAYmF5bGlicmUuY29tPiB3cm90ZToKPj4KPj4gQWRkcyB0aGUgYmluZGluZ3MgZm9y IHRoZSBBbWxvZ2ljIEcxMkEgVVNCIEdsdWUgSFcuCj4+Cj4+IFRoZSBBbWxvZ2ljIEcxMkEgU29D IEZhbWlseSBlbWJlZHMgMiBVU0IgQ29udHJvbGxlcnMgOgo+PiAtIGEgRFdDMyBJUCBjb25maWd1 cmVkIGFzIEhvc3QgZm9yIFVTQjIgYW5kIFVTQjMKPj4gLSBhIERXQzIgSVAgY29uZmlndXJlZCBh cyBQZXJpcGhlcmFsIFVTQjIgT25seQo+Pgo+PiBBIGdsdWUgY29ubmVjdHMgdGhlc2UgYm90aCBj b250cm9sbGVycyB0byAyIFVTQjIgUEhZcywKPj4gYW5kIG9wdGlvbm5hbGx5IHRvIGFuIFVTQjMr UENJRSBDb21ibyBQSFkgc2hhcmVkIHdpdGggdGhlIFBDSUUgY29udHJvbGxlci4KPj4KPj4gVGhl IEdsdWUgY29uZmlndXJlcyB0aGUgVVRNSSA4Yml0IGludGVyZmFjZXMgZm9yIHRoZSBVU0IyIFBI WXMsIGluY2x1ZGluZwo+PiByb3V0aW5nIG9mIHRoZSBPVEcgUEhZIGJldHdlZW4gdGhlIERXQzMg YW5kIERXQzIgY29udHJvbGxlcnMsIGFuZAo+PiBzZXR1cHMgdGhlIG9uLWNoaXAgT1RHIG1vZGUg c2VsZWN0aW9uIGZvciB0aGlzIFBIWS4KPj4KPj4gVGhlIFBIWXMgcGhhbmRsZXMgYXJlIHBhc3Nl ZCAgdG8gdGhlIEdsdWUgbm9kZSBzaW5jZSB0aGUgR2x1ZSBjb250cm9scyB0aGUKPj4gaW50ZXJm YWNlIHdpdGggdGhlIFBIWSwgbm90IHRoZSBEV0MzIGNvbnRyb2xsZXIuCj4+Cj4+IFNpZ25lZC1v ZmYtYnk6IE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT4KPiBSZXZpZXdl ZC1ieTogTWFydGluIEJsdW1lbnN0aW5nbCA8bWFydGluLmJsdW1lbnN0aW5nbEBnb29nbGVtYWls LmNvbT4KPiAKPiBbLi4uXQo+PiArICAgICAgICAgICAgICAgICAgICAgICBkd2MzOiB1c2JAZmY1 MDAwMDAgewo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAi c25wcyxkd2MzIjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MHgw IDB4ZmY1MDAwMDAgMHgwIDB4MTAwMDAwPjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMzAgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZHJfbW9kZSA9ICJob3N0IjsKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzbnBzLGRpc191Ml9zdXNwaHlfcXVpcms7Cj4+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc25wcyxxdWlyay1mcmFtZS1sZW5ndGgtYWRq dXN0bWVudDsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgfTsKPiBpbiB2MSBvZiB0aGUgcGF0 Y2ggSSBhc2tlZCB3aGV0aGVyIHdlIHNob3VsZCBwYXNzIHRoZSBQSFlzIHdoaWNoIGFyZQo+IGNv bm5lY3RlZCB0byB0aGUgZHdjMyBjb250cm9sbGVyIGhlcmUgYXMgd2VsbCAoaW5zdGVhZCBvZiBv bmx5IHBhc3NpbmcKPiB0aGVtIHRvIHRoZSBVU0JDVFJMIG5vZGUpLgo+IHdlIGNhbiBzdGlsbCBk byB0aGlzIGxhdGVyIG9uLCB0aGUgaW1wb3J0YW50IHBhcnQgaXM6IFVTQkNUUkwKPiBpbnRlcmZh Y2VzIHdpdGggdGhlIFBIWXMgLT4gdGhhdCBpcyBhbHJlYWR5IHBhcnQgb2YgdGhlIGJpbmRpbmcu CgpJbmRlZWQsIGl0J3Mgbm90IHBhcnQgb2YgdGhpcyBiaW5kaW5nIGRvYywgYW5kIHdlIGNhbiBk byBpdCBpZiBuZWVkZWQuCkJ1dCBzaW5jZSB0aGUgT1RHIHNldHVwIGlzIG5vdCBoYW5kbGVkIGJ5 IERXQzMsIHRoZXJlIGlzIG5vIHJlYWwgdXNlLgoKTmVpbAoKPiAKPiAKPiBSZWdhcmRzCj4gTWFy dGluCj4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695D6C43381 for ; Thu, 7 Mar 2019 08:36:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38D0B20652 for ; Thu, 7 Mar 2019 08:36:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FNlCiVY9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="wkOYUHAk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38D0B20652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=flYwkp5HdWCcnJjTdZb08iGplFRgrXy049SJekLIUq4=; b=FNlCiVY9KG7A6j mM+qEihrlC79i0thSm6kRP5uMK/y6d+VbTe7zapHKLZMBxjOVaXpQRibHlrrDowLp+Vv6sSnH5Luq uM4TsiY7p4voY7HrAzUCGC+z8HFCVDa9fsFo6z8l3TT52mPjF09fgTxaMeqf/fZpO1uqd9kuJ6yVa sgMzfUDCvtg9G8PbJ2flXVYFtiC0YL2KzHxrAVevriUG8N9jhrjvD8BJUOxTOSkaHtKPNUEBb7aEm 5mTbJxVf7U1qHETvdKwcMa+KB4vokmH/S1RK0tnidwyLwPUdpIuHNu/t3xt7BBCJfvOGd5k+CTEYo ojD5Bmi2F5ZIg1y6aUHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1oW3-0008H9-Og; Thu, 07 Mar 2019 08:36:35 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1oVx-0008FJ-UE for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2019 08:36:33 +0000 Received: by mail-wr1-x444.google.com with SMTP id d17so16352629wre.10 for ; Thu, 07 Mar 2019 00:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=z3Ji1GCmHY2z0c9fHAuNCsiL41DSMdKf5/WykyTE3HE=; b=wkOYUHAky5gLl7efprLlqMeFQ06LUYEZa8PXS6u1o2WWlBTorgPmbk0lkQyQi4qoyW CnJPfShl6sLoSLRS076rMcb3fRAA370V42QyLtfGIUrPV2esYF1+9aCKO3GreRmxcRku 5Ufe+bbl3WFtgTrwOt66uAclBY1Pwuwij/cW6lxu4vqhPkf0e5rFJJ8V4RJ4y83XRFZL bVsvkq+SW4gxwOIy4QpdHWM4mhE0WxpDRFQsWDOKZ/RghONGDHeOoPVkmZWasONjwPv7 YmmRNtCzskNTBhlA/iiYkuECu33Hhb1QZtlOPXnOwBOyN3Lfy3DuNbvJ1CR9p8H4ILnJ RNOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=z3Ji1GCmHY2z0c9fHAuNCsiL41DSMdKf5/WykyTE3HE=; b=BRBbZQNfAD+Ww/OZEeDZoNjJtSSfuv/AVOoGvQwx8Y6pbSorYFHeYsvUb6QAU+pXkf x+Q8dwFYdAqVDaNE87YZ57DJhTsn2P4w1mQi1mi+AHlzkh2ftMKkI3rpJyK6tQMxltT2 urw4tzp6KlvBVV2yg6XCunuHkLM7fBrOU+ZJJpGeVsfQZRdJ1+qtDFp8B9+5TJvEVQiA ia50wT2kNsvxOpfSPYD0wNTRp+w5Js2ovCNWdJlV4iuSZJrzYwPPg6zbQF/fBP7dKFLO UrQ0LpWZQDuNOq1tEq1ZOUyJ6QDomtHfBLdh99+Y8g9Mkl8L/qfIic97wskpsfQRoWOs pqqg== X-Gm-Message-State: APjAAAURTr1JRCJLRDU0AoWPsQ5Njk5eRHgja9wfm70I2zDvVbMwzTH2 09SS1wiCRjSim0PIx28sYAs7VVeM0MaK7w== X-Google-Smtp-Source: APXvYqw6rYK2BGt/nKVRRcqc8nZ3JL4G5BdVYpRhjzH6YS8IRm5qVmil+b6tp/qTO/DMqZor+o1IGQ== X-Received: by 2002:adf:fa10:: with SMTP id m16mr1417251wrr.188.1551947788109; Thu, 07 Mar 2019 00:36:28 -0800 (PST) Received: from [10.1.2.12] (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id g15sm5828079wmg.16.2019.03.07.00.36.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 00:36:27 -0800 (PST) Subject: Re: [PATCH v2 4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings To: Martin Blumenstingl References: <20190304103846.2060-1-narmstrong@baylibre.com> <20190304103846.2060-5-narmstrong@baylibre.com> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: <6d68648d-d1a6-1352-b787-ee04a49f4eaa@baylibre.com> Date: Thu, 7 Mar 2019 09:36:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190307_003632_100875_D6591424 X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/03/2019 22:27, Martin Blumenstingl wrote: > Hi Neil, > > On Mon, Mar 4, 2019 at 11:40 AM Neil Armstrong wrote: >> >> Adds the bindings for the Amlogic G12A USB Glue HW. >> >> The Amlogic G12A SoC Family embeds 2 USB Controllers : >> - a DWC3 IP configured as Host for USB2 and USB3 >> - a DWC2 IP configured as Peripheral USB2 Only >> >> A glue connects these both controllers to 2 USB2 PHYs, >> and optionnally to an USB3+PCIE Combo PHY shared with the PCIE controller. >> >> The Glue configures the UTMI 8bit interfaces for the USB2 PHYs, including >> routing of the OTG PHY between the DWC3 and DWC2 controllers, and >> setups the on-chip OTG mode selection for this PHY. >> >> The PHYs phandles are passed to the Glue node since the Glue controls the >> interface with the PHY, not the DWC3 controller. >> >> Signed-off-by: Neil Armstrong > Reviewed-by: Martin Blumenstingl > > [...] >> + dwc3: usb@ff500000 { >> + compatible = "snps,dwc3"; >> + reg = <0x0 0xff500000 0x0 0x100000>; >> + interrupts = ; >> + dr_mode = "host"; >> + snps,dis_u2_susphy_quirk; >> + snps,quirk-frame-length-adjustment; >> + }; > in v1 of the patch I asked whether we should pass the PHYs which are > connected to the dwc3 controller here as well (instead of only passing > them to the USBCTRL node). > we can still do this later on, the important part is: USBCTRL > interfaces with the PHYs -> that is already part of the binding. Indeed, it's not part of this binding doc, and we can do it if needed. But since the OTG setup is not handled by DWC3, there is no real use. Neil > > > Regards > Martin > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD40EC43381 for ; Thu, 7 Mar 2019 08:36:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B32120840 for ; Thu, 7 Mar 2019 08:36:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X6/5HRbn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="wkOYUHAk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B32120840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R3Y0ajE7StwoOanD/PdAVfC8ur9pCuLTSnaTbRxcwwY=; b=X6/5HRbnlQZl9J VpqScQZX8T3DQncsNmnKKOg98go+3JZTjLyaTgkcGDeuBsX2k61t5UwZE0vQnbt0pH//+jq2g5N1n IXHc5UAowSrCYzMClYBVvQG5GgrtEcrKGKy89ss7FHlK6rb4HJuS9YW/Ii5nW7uzjUExGqk99lyis mfKHF5g+rn87Pxd+bXpm5ykjWaHAsdeKVNRSi2GF6bZ1aiWms4BIrO9/7xXHmEItl/oroswunXj4m khblnhJrgjP8/6V2yrMNYyHmZ0e9Qw2ir0AcOy0ImtvESYh7xVsKthCcOKvizL5SOlLOO7+NW5B7r x5+WFZxiv380T2ooAciw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1oW2-0008GZ-Kt; Thu, 07 Mar 2019 08:36:34 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1oVx-0008FI-UD for linux-amlogic@lists.infradead.org; Thu, 07 Mar 2019 08:36:33 +0000 Received: by mail-wr1-x444.google.com with SMTP id w6so16360535wrs.4 for ; Thu, 07 Mar 2019 00:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=z3Ji1GCmHY2z0c9fHAuNCsiL41DSMdKf5/WykyTE3HE=; b=wkOYUHAky5gLl7efprLlqMeFQ06LUYEZa8PXS6u1o2WWlBTorgPmbk0lkQyQi4qoyW CnJPfShl6sLoSLRS076rMcb3fRAA370V42QyLtfGIUrPV2esYF1+9aCKO3GreRmxcRku 5Ufe+bbl3WFtgTrwOt66uAclBY1Pwuwij/cW6lxu4vqhPkf0e5rFJJ8V4RJ4y83XRFZL bVsvkq+SW4gxwOIy4QpdHWM4mhE0WxpDRFQsWDOKZ/RghONGDHeOoPVkmZWasONjwPv7 YmmRNtCzskNTBhlA/iiYkuECu33Hhb1QZtlOPXnOwBOyN3Lfy3DuNbvJ1CR9p8H4ILnJ RNOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=z3Ji1GCmHY2z0c9fHAuNCsiL41DSMdKf5/WykyTE3HE=; b=ZEmwfF+bD14QD5Efm3c3bZQiSJrKdtCw3TVP8Y3Z8sj1J0Eyp6Srz5jVXJatCINH7z wWOmjnG5WzSC/0qiLG6brfkMQSta3xTW7+slYWgEa72v3fh7iHNJD9eqr8yxGZ3N0qaN bOx7Ek2v5uJmsmrI35Y/pR50UgiWD7uHzXkraRMmDz32Ljv0IwvW4nGKVarUfF5gsNCZ s6+LUHlcGbcxtPoIh/bJ2eGv+HV856NO4Po29yGTo+vwI832MbkQZTpceYIyqulUiMk3 lZq2j77zN+0+BJoVPptFWG9ogRzzvrI2nSV3LxV/psLJzvZRT63fCe40uNlnAS0cmzp6 rGIw== X-Gm-Message-State: APjAAAXcSSaDViTjUGskaz2tDroEJKWA6SKs9LbkmszIiRLB3lDCBUjl X9v0f+OAZwVwuXLOta83FeQ8/Q== X-Google-Smtp-Source: APXvYqw6rYK2BGt/nKVRRcqc8nZ3JL4G5BdVYpRhjzH6YS8IRm5qVmil+b6tp/qTO/DMqZor+o1IGQ== X-Received: by 2002:adf:fa10:: with SMTP id m16mr1417251wrr.188.1551947788109; Thu, 07 Mar 2019 00:36:28 -0800 (PST) Received: from [10.1.2.12] (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id g15sm5828079wmg.16.2019.03.07.00.36.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 00:36:27 -0800 (PST) Subject: Re: [PATCH v2 4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings To: Martin Blumenstingl References: <20190304103846.2060-1-narmstrong@baylibre.com> <20190304103846.2060-5-narmstrong@baylibre.com> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: <6d68648d-d1a6-1352-b787-ee04a49f4eaa@baylibre.com> Date: Thu, 7 Mar 2019 09:36:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190307_003632_132539_F3C971F2 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 06/03/2019 22:27, Martin Blumenstingl wrote: > Hi Neil, > > On Mon, Mar 4, 2019 at 11:40 AM Neil Armstrong wrote: >> >> Adds the bindings for the Amlogic G12A USB Glue HW. >> >> The Amlogic G12A SoC Family embeds 2 USB Controllers : >> - a DWC3 IP configured as Host for USB2 and USB3 >> - a DWC2 IP configured as Peripheral USB2 Only >> >> A glue connects these both controllers to 2 USB2 PHYs, >> and optionnally to an USB3+PCIE Combo PHY shared with the PCIE controller. >> >> The Glue configures the UTMI 8bit interfaces for the USB2 PHYs, including >> routing of the OTG PHY between the DWC3 and DWC2 controllers, and >> setups the on-chip OTG mode selection for this PHY. >> >> The PHYs phandles are passed to the Glue node since the Glue controls the >> interface with the PHY, not the DWC3 controller. >> >> Signed-off-by: Neil Armstrong > Reviewed-by: Martin Blumenstingl > > [...] >> + dwc3: usb@ff500000 { >> + compatible = "snps,dwc3"; >> + reg = <0x0 0xff500000 0x0 0x100000>; >> + interrupts = ; >> + dr_mode = "host"; >> + snps,dis_u2_susphy_quirk; >> + snps,quirk-frame-length-adjustment; >> + }; > in v1 of the patch I asked whether we should pass the PHYs which are > connected to the dwc3 controller here as well (instead of only passing > them to the USBCTRL node). > we can still do this later on, the important part is: USBCTRL > interfaces with the PHYs -> that is already part of the binding. Indeed, it's not part of this binding doc, and we can do it if needed. But since the OTG setup is not handled by DWC3, there is no real use. Neil > > > Regards > Martin > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic