From: Randy Dunlap <rdunlap@infradead.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>, Jon Maloy <jmaloy@redhat.com>,
Ying Xue <ying.xue@windriver.com>,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module
Date: Mon, 17 Aug 2020 13:43:09 -0700 [thread overview]
Message-ID: <6d7aa56a-5324-87c9-4150-b73be7e3c0a6@infradead.org> (raw)
In-Reply-To: <CAM_iQpUQtof+dQseFjS6fxucUZe5tkhUW5EvK+XtZE=cRRq4-A@mail.gmail.com>
On 8/17/20 1:29 PM, Cong Wang wrote:
> On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> TIPC=m and IPV6=m builds just fine.
>>
>> Having tipc autoload ipv6 is a different problem. (IMO)
>>
>>
>> This Kconfig entry:
>> menuconfig TIPC
>> tristate "The TIPC Protocol"
>> depends on INET
>> + depends on IPV6 || IPV6=n
>>
>> says:
>> If IPV6=n, TIPC can be y/m/n.
>> If IPV6=y/m, TIPC is limited to whatever IPV6 is set to.
>
> Hmm, nowadays we _do_ have IPV6=y on popular distros.
> So this means TIPC would have to be builtin after this patch??
No, it does not mean that. We can still have IPV6=y and TIPC=m.
Hm, maybe I should have said this instead:
If IPV6=y/m, TIPC is limited _by_ whatever IPV6 is set to.
(instead of _to_ )
Does that help any?
The "limited" in Kconfig rules is a "less than or equal to"
limit, where 'm' < 'y'.
> Still sounds harsh, right?
>
> At least on my OpenSUSE I have CONFIG_IPV6=y and
> CONFIG_TIPC=m.
>
>> TIPC cannot be =y unless IPV6=y.
>
> Interesting, I never correctly understand that "depends on"
> behavior.
>
> But even if it builds, how could TIPC module find and load
> IPV6 module? Does IPV6 module automatically become its
> dependency now I think?
Sorry, I don't know about this.
--
~Randy
next prev parent reply other threads:[~2020-08-17 20:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 9:32 [PATCH net] tipc: not enable tipc when ipv6 works as a module Xin Long
2020-08-16 18:29 ` Cong Wang
2020-08-17 6:49 ` Xin Long
2020-08-17 18:31 ` Cong Wang
2020-08-17 18:49 ` Randy Dunlap
2020-08-17 18:55 ` Cong Wang
2020-08-17 19:00 ` Randy Dunlap
2020-08-17 19:26 ` Cong Wang
2020-08-17 19:55 ` Randy Dunlap
2020-08-17 20:29 ` Cong Wang
2020-08-17 20:43 ` Randy Dunlap [this message]
2020-08-17 20:59 ` Cong Wang
2020-08-17 21:39 ` David Miller
2020-08-17 22:20 ` Cong Wang
2020-08-18 7:59 ` Xin Long
2020-08-17 21:37 ` David Miller
2020-08-17 21:34 ` David Miller
2020-08-17 4:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d7aa56a-5324-87c9-4150-b73be7e3c0a6@infradead.org \
--to=rdunlap@infradead.org \
--cc=davem@davemloft.net \
--cc=jmaloy@redhat.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.