From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99035C3A5A1 for ; Fri, 23 Aug 2019 02:41:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DF7D233A0 for ; Fri, 23 Aug 2019 02:41:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pTCIk/NQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391270AbfHWClY (ORCPT ); Thu, 22 Aug 2019 22:41:24 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:57654 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389719AbfHWClY (ORCPT ); Thu, 22 Aug 2019 22:41:24 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x7N2fHnn040351; Thu, 22 Aug 2019 21:41:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1566528077; bh=pG93l+RMglvDxl8bb0IbXg5xaVYgCMI7e0/JyG61YKY=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=pTCIk/NQVNBCsLX4tPCJ9C5QZvRxRtoQVQ+Z4Jq1c049w3QRhK+bo34Z/Rzikz9tT 1KA2dlPAJVQ4E7mSA1wOfNhZCzju70n9ztDlEUO3BkqYzXgbyUsqeYaWRLWSCntK8N nCF4xJD1zd85qZKHgP7CsNhhgvPrYF1G967mwOy0= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x7N2fGVu096937 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Aug 2019 21:41:16 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 22 Aug 2019 21:41:16 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Thu, 22 Aug 2019 21:41:16 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x7N2fDl8119839; Thu, 22 Aug 2019 21:41:14 -0500 Subject: Re: [PATCH 10/12] phy: amlogic: G12A: Fix misuse of GENMASK macro To: Neil Armstrong , Joe Perches , Andrew Morton , Kevin Hilman CC: , , References: From: Kishon Vijay Abraham I Message-ID: <6d7abb4d-fe68-8d02-d985-7214118be126@ti.com> Date: Fri, 23 Aug 2019 08:11:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/07/19 12:53 PM, Neil Armstrong wrote: > On 10/07/2019 07:04, Joe Perches wrote: >> Arguments are supposed to be ordered high then low. >> >> Signed-off-by: Joe Perches >> --- >> drivers/phy/amlogic/phy-meson-g12a-usb2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c >> index 9065ffc85eb4..cd7eccab2649 100644 >> --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c >> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c >> @@ -66,7 +66,7 @@ >> #define PHY_CTRL_R14 0x38 >> #define PHY_CTRL_R14_I_RDP_EN BIT(0) >> #define PHY_CTRL_R14_I_RPU_SW1_EN BIT(1) >> - #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(2, 3) >> + #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(3, 2) >> #define PHY_CTRL_R14_PG_RSTN BIT(4) >> #define PHY_CTRL_R14_I_C2L_DATA_16_8 BIT(5) >> #define PHY_CTRL_R14_I_C2L_ASSERT_SINGLE_EN_ZERO BIT(6) >> > > Reviewed-by: Neil Armstrong Shouldn't this go to stable trees as well? -Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911D5C3A5A1 for ; Fri, 23 Aug 2019 02:41:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E991233A0 for ; Fri, 23 Aug 2019 02:41:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ocVc2JWw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pTCIk/NQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E991233A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HYysDpj8C8fU2Y+tBMhBWwXB8lwntIemQLlk3A3Z2R4=; b=ocVc2JWwAwewGh D5NwtAOLA4v8ie+vvjxAy4T9otrGBpaexy+vdjhqPCNO+3HP9FOb4OoF5PNlcAA5I3k2/eQ6CIAyD QwJ1DVzU8iuG6r2Bb5wqYeHmiHGQGK8+DJ5Z8wwGyp0HPWJxT0BqfwBFDj5OSsm5NBSuhL0o8xX+I vidLv3UDU+08wnVKam17X9jYohgvIaqUHno08Wf63UDjVv2phVkdGBo98ie4xFKn8oEBgtBCA1TDk rE5Nyz7eV8E1BDjs2zNJByMeDDNrWCyYqjAG0niAePGfeK6FTkJtlK96t9sdg4X+qWg9nMy8zXVhw fYNSXqa3mapyVD/7apGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0zW3-0003AW-LO; Fri, 23 Aug 2019 02:41:27 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0zVv-000367-7d; Fri, 23 Aug 2019 02:41:21 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x7N2fHnn040351; Thu, 22 Aug 2019 21:41:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1566528077; bh=pG93l+RMglvDxl8bb0IbXg5xaVYgCMI7e0/JyG61YKY=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=pTCIk/NQVNBCsLX4tPCJ9C5QZvRxRtoQVQ+Z4Jq1c049w3QRhK+bo34Z/Rzikz9tT 1KA2dlPAJVQ4E7mSA1wOfNhZCzju70n9ztDlEUO3BkqYzXgbyUsqeYaWRLWSCntK8N nCF4xJD1zd85qZKHgP7CsNhhgvPrYF1G967mwOy0= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x7N2fGVu096937 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Aug 2019 21:41:16 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 22 Aug 2019 21:41:16 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Thu, 22 Aug 2019 21:41:16 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x7N2fDl8119839; Thu, 22 Aug 2019 21:41:14 -0500 Subject: Re: [PATCH 10/12] phy: amlogic: G12A: Fix misuse of GENMASK macro To: Neil Armstrong , Joe Perches , Andrew Morton , Kevin Hilman References: From: Kishon Vijay Abraham I Message-ID: <6d7abb4d-fe68-8d02-d985-7214118be126@ti.com> Date: Fri, 23 Aug 2019 08:11:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190822_194119_451529_F97C91DC X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/07/19 12:53 PM, Neil Armstrong wrote: > On 10/07/2019 07:04, Joe Perches wrote: >> Arguments are supposed to be ordered high then low. >> >> Signed-off-by: Joe Perches >> --- >> drivers/phy/amlogic/phy-meson-g12a-usb2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c >> index 9065ffc85eb4..cd7eccab2649 100644 >> --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c >> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c >> @@ -66,7 +66,7 @@ >> #define PHY_CTRL_R14 0x38 >> #define PHY_CTRL_R14_I_RDP_EN BIT(0) >> #define PHY_CTRL_R14_I_RPU_SW1_EN BIT(1) >> - #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(2, 3) >> + #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(3, 2) >> #define PHY_CTRL_R14_PG_RSTN BIT(4) >> #define PHY_CTRL_R14_I_C2L_DATA_16_8 BIT(5) >> #define PHY_CTRL_R14_I_C2L_ASSERT_SINGLE_EN_ZERO BIT(6) >> > > Reviewed-by: Neil Armstrong Shouldn't this go to stable trees as well? -Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D864FC3A5A1 for ; Fri, 23 Aug 2019 02:41:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADD4E233A0 for ; Fri, 23 Aug 2019 02:41:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fkrr/obN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pTCIk/NQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADD4E233A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FeHvw+YJ5yfyZhnNOkqM//SW6EVA9lrxoz2tw741P0s=; b=fkrr/obNXZNtYO HMBq8hzFtVistMIAzhlqwJhoZuFZS65kRbJKSbNPbByw8vJnt+qZTnzSAh0uaI0zJq5n/6iwYza41 DSr/B3c2Ue/XcftPyIKT9+SvdIipAaze5O/26NCd2318QrhSFXUygRXFa1HN5T93t9g4Hh6es0OfE VCXS7I7l14m6ostcR1Dj5I7oW+nOTNAQeQLYEuO13hOk0gHV5jwHr/mM7IKrJu7Fxj+yfth3ANmFP R2X7GL/wMmZn/ArzJsCIOMlE6OlX5Hc5fmRV2bj55iy+edccAusdUXPyI4qQDvxcLG99U7VvS2Gxf gokPSlSYg0wH7mFrdZmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0zVz-00039P-IA; Fri, 23 Aug 2019 02:41:23 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0zVv-000367-7d; Fri, 23 Aug 2019 02:41:21 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x7N2fHnn040351; Thu, 22 Aug 2019 21:41:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1566528077; bh=pG93l+RMglvDxl8bb0IbXg5xaVYgCMI7e0/JyG61YKY=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=pTCIk/NQVNBCsLX4tPCJ9C5QZvRxRtoQVQ+Z4Jq1c049w3QRhK+bo34Z/Rzikz9tT 1KA2dlPAJVQ4E7mSA1wOfNhZCzju70n9ztDlEUO3BkqYzXgbyUsqeYaWRLWSCntK8N nCF4xJD1zd85qZKHgP7CsNhhgvPrYF1G967mwOy0= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x7N2fGVu096937 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Aug 2019 21:41:16 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 22 Aug 2019 21:41:16 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Thu, 22 Aug 2019 21:41:16 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x7N2fDl8119839; Thu, 22 Aug 2019 21:41:14 -0500 Subject: Re: [PATCH 10/12] phy: amlogic: G12A: Fix misuse of GENMASK macro To: Neil Armstrong , Joe Perches , Andrew Morton , Kevin Hilman References: From: Kishon Vijay Abraham I Message-ID: <6d7abb4d-fe68-8d02-d985-7214118be126@ti.com> Date: Fri, 23 Aug 2019 08:11:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190822_194119_451529_F97C91DC X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 22/07/19 12:53 PM, Neil Armstrong wrote: > On 10/07/2019 07:04, Joe Perches wrote: >> Arguments are supposed to be ordered high then low. >> >> Signed-off-by: Joe Perches >> --- >> drivers/phy/amlogic/phy-meson-g12a-usb2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c >> index 9065ffc85eb4..cd7eccab2649 100644 >> --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c >> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c >> @@ -66,7 +66,7 @@ >> #define PHY_CTRL_R14 0x38 >> #define PHY_CTRL_R14_I_RDP_EN BIT(0) >> #define PHY_CTRL_R14_I_RPU_SW1_EN BIT(1) >> - #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(2, 3) >> + #define PHY_CTRL_R14_I_RPU_SW2_EN GENMASK(3, 2) >> #define PHY_CTRL_R14_PG_RSTN BIT(4) >> #define PHY_CTRL_R14_I_C2L_DATA_16_8 BIT(5) >> #define PHY_CTRL_R14_I_C2L_ASSERT_SINGLE_EN_ZERO BIT(6) >> > > Reviewed-by: Neil Armstrong Shouldn't this go to stable trees as well? -Kishon _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic