All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: mreitz@redhat.com, quintela@redhat.com, dgilbert@redhat.com,
	stefanha@redhat.com, lvivier@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test postcopy migration
Date: Thu, 13 Apr 2017 13:44:56 -0500	[thread overview]
Message-ID: <6d7af73d-2dc1-88ab-0f66-0fa84661dbb0@redhat.com> (raw)
In-Reply-To: <1492104214-29994-4-git-send-email-kwolf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1850 bytes --]

On 04/13/2017 12:23 PM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/qemu-iotests/181     | 117 +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/181.out |  38 +++++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  3 files changed, 156 insertions(+)
>  create mode 100755 tests/qemu-iotests/181
>  create mode 100644 tests/qemu-iotests/181.out
> 

I don't see a 180.out mentioned on-list anywhere (but the choice of test
number is not too serious).

./check -raw 181

 === Write something on the source ===

+WARNING: Image format was not specified for 'TEST_DIR/t.raw' and
probing guessed raw.
+Automatically detecting the format is dangerous for raw images, write
operations on block 0 will be restricted.
+Specify the 'raw' format explicitly to remove the restrictions.


You'll want to fix that.


> +# Slow down migration so much that it definitely won't finish before we can
> +# switch to postcopy
> +silent=yes
> +_send_qemu_cmd $src 'migrate_set_speed 4k' "(qemu)"
> +_send_qemu_cmd $src 'migrate_set_capability postcopy-ram on' "(qemu)"
> +_send_qemu_cmd $src "migrate -d unix:${MIG_SOCKET}" "(qemu)"
> +_send_qemu_cmd $src 'migrate_start_postcopy' "(qemu)"
> +
> +QEMU_COMM_TIMEOUT=1 qemu_cmd_repeat=10 silent=yes \
> +    _send_qemu_cmd $src "info migrate" "completed\|failed"
> +silent=yes _send_qemu_cmd $src "" "(qemu)"

Do we want to tell the source to go back to a higher migrate_set_speed
once we know we are in postcopy mode?  But the test passed for me under
-qcow2 in less than 2 seconds, on an unloaded machine, so hopefully even
on a heavily loaded machine we aren't giving up due to timeouts.


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2017-04-13 18:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13 17:23 [Qemu-devel] [PATCH 0/3] migration: Call blk_resume_after_migration() for postcopy Kevin Wolf
2017-04-13 17:23 ` [Qemu-devel] [PATCH 1/3] " Kevin Wolf
2017-04-13 17:39   ` Eric Blake
2017-04-13 17:54     ` Kevin Wolf
2017-04-13 18:03       ` Eric Blake
2017-04-13 18:30         ` Kevin Wolf
2017-04-13 17:23 ` [Qemu-devel] [PATCH 2/3] qemu-iotests: Filter HMP readline escape characters Kevin Wolf
2017-04-13 17:38   ` Eric Blake
2017-04-13 17:44     ` Eric Blake
2017-04-19 14:45     ` Kevin Wolf
2017-04-13 17:23 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: Test postcopy migration Kevin Wolf
2017-04-13 18:44   ` Eric Blake [this message]
2017-04-19 14:38     ` Kevin Wolf
2017-04-18 12:04   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d7af73d-2dc1-88ab-0f66-0fa84661dbb0@redhat.com \
    --to=eblake@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.