RE: [meta-arago][dunfell][PATCH] gstreamer: Adding tracer-hooks build flag to enable GST_TRACERS

["Limaye, Aniket" <a-limaye@ti.com>]

Hi Ryan,

I have done the same and submitted a v2 patch here: https://lists.yoctoproject.org/g/meta-arago/message/13934



-----Original Message-----
From: Eatmon, Ryan <reatmon@ti.com> 
Sent: Friday, July 1, 2022 3:41 AM
To: Denys Dmytriyenko <denis@denix.org>
Cc: Limaye, Aniket <a-limaye@ti.com>; Bajjuri, Praneeth <praneeth@ti.com>; meta-arago@lists.yoctoproject.org; Mantena, Prasanth <p-mantena@ti.com>; prashanth.ka@pathpartnertech.com; R, Karthik <karthik.ramanan@ti.com>; Weaver, Lucas <l-weaver@ti.com>
Subject: Re: [meta-arago][dunfell][PATCH] gstreamer: Adding tracer-hooks build flag to enable GST_TRACERS


Aniket,

I like the last option that Denys proposed.  Adding it to the list in:

meta-arago-distro/conf/distro/arago.conf


That feels like the cleanest way of doing this.  Do you have enough to make that change and submit a new patch?



On 6/30/2022 16:20, Denys Dmytriyenko wrote:
> Correct. It could be a bbappend in meta-arago-distro, like the original patch,
> or it could be just added into meta-arago-distro/conf/distro/arago.conf like
> existing PACKAGECONFIG modifications there in lines 107-150:
> https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/conf/distro/arago.conf#n107
> 
> 
> On Thu, Jun 30, 2022 at 04:15:02PM -0500, Ryan Eatmon wrote:
>>
>> So you're saying it should be in meta-arago-distro?
>>
>>
>>
>> On 6/30/2022 12:25, Denys Dmytriyenko wrote:
>>> This is distro-specific configuration and should not be done in distro-agnostic meta-arago-extras layer.
>>>
>>>
>>> On Thu, Jun 30, 2022 at 11:58:09AM +0000, Aniket Limaye via lists.yoctoproject.org wrote:
>>>> +Karthik
>>>>
>>>> Praneeth,
>>>>
>>>> This is not specific to codec. This can be used for profiling latencies and such for any GStreamer elements.
>>>> It should not impact performance either. It just prints latency logs if an environment variable is set, similar to GST_DEBUG.
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: Bajjuri, Praneeth <praneeth@ti.com>
>>>> Sent: Thursday, June 30, 2022 3:29 PM
>>>> To: Limaye, Aniket <a-limaye@ti.com>; meta-arago@lists.yoctoproject.org; Mantena, Prasanth <p-mantena@ti.com>; prashanth.ka@pathpartnertech.com
>>>> Cc: Eatmon, Ryan <reatmon@ti.com>; Weaver, Lucas <l-weaver@ti.com>
>>>> Subject: Re: [meta-arago][dunfell][PATCH] gstreamer: Adding tracer-hooks build flag to enable GST_TRACERS
>>>>
>>>> Prashanth,Prasanth,
>>>>
>>>> Please review.
>>>>
>>>> On 6/29/2022 4:23 PM, Aniket Limaye wrote:
>>>>> Enables GST_TRACERS : an optional utility for profiling gstreamer applications
>>>>
>>>> Aniket,
>>>>
>>>> 1. What is the impact of this with codec performance?
>>>> 2. Why is this optional utility need to enabled?
>>>>
>>>>
>>>>>
>>>>> Signed-off-by: Aniket Limaye <a-limaye@ti.com>
>>>>> ---
>>>>>    .../gstreamer/gstreamer1.0_1.16.%.bbappend                   | 5 +++++
>>>>>    1 file changed, 5 insertions(+)
>>>>>    create mode 100644 meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0_1.16.%.bbappend
>>>>>
>>>>> diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0_1.16.%.bbappend b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0_1.16.%.bbappend
>>>>> new file mode 100644
>>>>> index 00000000..d7bdaa04
>>>>> --- /dev/null
>>>>> +++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0_1.16.%.bbappend
>>>>> @@ -0,0 +1,5 @@
>>>>> +
>>>>> +PACKAGECONFIG_append = " tracer-hooks"
>>>>> +
>>>>> +PR_append = ".arago0"
>>>>> +

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS