From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BCD2621A00AE6 for ; Tue, 11 Sep 2018 09:34:30 -0700 (PDT) From: "Kani, Toshi" Subject: Re: open sets ext4_da_aops for DAX existing files Date: Tue, 11 Sep 2018 16:34:03 +0000 Message-ID: <6d94d09e2539991db4853042b57bcf6274460f49.camel@hpe.com> References: <76e07643e9c36e4273588bd3e7f29d1393de4c3d.camel@hpe.com> <20180910142902.GA30197@quack2.suse.cz> <0768c59f2d5391ff7678370fbc72cb664fca25fd.camel@hpe.com> <20180911152706.GG6104@quack2.suse.cz> In-Reply-To: <20180911152706.GG6104@quack2.suse.cz> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "jack@suse.cz" , "Elliott, Robert (Persistent Memory)" Cc: "linux-fsdevel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: On Tue, 2018-09-11 at 17:27 +0200, Jan Kara wrote: > On Mon 10-09-18 17:58:10, Elliott, Robert (Persistent Memory) wrote: > > > > > > > -----Original Message----- > > > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of Kani, Toshi > > > Sent: Monday, September 10, 2018 9:52 AM > > > To: jack@suse.cz > > > Cc: linux-fsdevel@vger.kernel.org; linux-nvdimm@lists.01.org > > > Subject: Re: open sets ext4_da_aops for DAX existing files > > > > ... > > > > Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier > > > > in the ext4_iget()? Did this bug have any user visible manifestations? > > > > > > Yes, sync did not flush processor cache. > > > > > > > Please also add: > > > > > > > > Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086 > > > > > > > > so that stable automation picks this up. Thanks! > > > > > > > > > > Will do. > > > > > > > Also check if the same problem exists with ext2. > > The problem also exists in ext2 so that needs fixing as well. Right. Once my ext4 patch 2/2 is reviewed, I will duplicate it for ext2. Thanks, -Toshi _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t2353.austin.hpe.com ([15.233.44.26]:35896 "EHLO g2t2353.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbeIKVef (ORCPT ); Tue, 11 Sep 2018 17:34:35 -0400 From: "Kani, Toshi" To: "jack@suse.cz" , "Elliott, Robert (Persistent Memory)" CC: "linux-nvdimm@lists.01.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: open sets ext4_da_aops for DAX existing files Date: Tue, 11 Sep 2018 16:34:03 +0000 Message-ID: <6d94d09e2539991db4853042b57bcf6274460f49.camel@hpe.com> References: <76e07643e9c36e4273588bd3e7f29d1393de4c3d.camel@hpe.com> <20180910142902.GA30197@quack2.suse.cz> <0768c59f2d5391ff7678370fbc72cb664fca25fd.camel@hpe.com> <20180911152706.GG6104@quack2.suse.cz> In-Reply-To: <20180911152706.GG6104@quack2.suse.cz> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDE4LTA5LTExIGF0IDE3OjI3ICswMjAwLCBKYW4gS2FyYSB3cm90ZToNCj4gT24g TW9uIDEwLTA5LTE4IDE3OjU4OjEwLCBFbGxpb3R0LCBSb2JlcnQgKFBlcnNpc3RlbnQgTWVtb3J5 KSB3cm90ZToNCj4gPiANCj4gPiANCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ ID4gPiBGcm9tOiBMaW51eC1udmRpbW0gW21haWx0bzpsaW51eC1udmRpbW0tYm91bmNlc0BsaXN0 cy4wMS5vcmddIE9uIEJlaGFsZiBPZiBLYW5pLCBUb3NoaQ0KPiA+ID4gU2VudDogTW9uZGF5LCBT ZXB0ZW1iZXIgMTAsIDIwMTggOTo1MiBBTQ0KPiA+ID4gVG86IGphY2tAc3VzZS5jeg0KPiA+ID4g Q2M6IGxpbnV4LWZzZGV2ZWxAdmdlci5rZXJuZWwub3JnOyBsaW51eC1udmRpbW1AbGlzdHMuMDEu b3JnDQo+ID4gPiBTdWJqZWN0OiBSZTogb3BlbiBzZXRzIGV4dDRfZGFfYW9wcyBmb3IgREFYIGV4 aXN0aW5nIGZpbGVzDQo+ID4gDQo+ID4gLi4uDQo+ID4gPiA+IEdvb2QgY2F0Y2guIFdpbGwgeW91 IHNlbmQgYSBmaXg/IEkuZS4sIGNhbGwgZXh0NF9zZXRfaW5vZGVfZmxhZ3MoKSBlYXJsaWVyDQo+ ID4gPiA+IGluIHRoZSBleHQ0X2lnZXQoKT8gRGlkIHRoaXMgYnVnIGhhdmUgYW55IHVzZXIgdmlz aWJsZSBtYW5pZmVzdGF0aW9ucz8NCj4gPiA+IA0KPiA+ID4gWWVzLCBzeW5jIGRpZCBub3QgZmx1 c2ggcHJvY2Vzc29yIGNhY2hlLg0KPiA+ID4gDQo+ID4gPiA+IFBsZWFzZSBhbHNvIGFkZDoNCj4g PiA+ID4gDQo+ID4gPiA+IEZpeGVzOiA1ZjA2NjNiYjRhNjRmNTg4ZjBhMmRkNmQxYmU2OGQ0MGY5 YWYwMDg2DQo+ID4gPiA+IA0KPiA+ID4gPiBzbyB0aGF0IHN0YWJsZSBhdXRvbWF0aW9uIHBpY2tz IHRoaXMgdXAuIFRoYW5rcyENCj4gPiA+ID4gDQo+ID4gPiANCj4gPiA+IFdpbGwgZG8uDQo+ID4g PiANCj4gPiANCj4gPiBBbHNvIGNoZWNrIGlmIHRoZSBzYW1lIHByb2JsZW0gZXhpc3RzIHdpdGgg ZXh0Mi4NCj4gDQo+IFRoZSBwcm9ibGVtIGFsc28gZXhpc3RzIGluIGV4dDIgc28gdGhhdCBuZWVk cyBmaXhpbmcgYXMgd2VsbC4NCg0KUmlnaHQuICBPbmNlIG15IGV4dDQgcGF0Y2ggMi8yIGlzIHJl dmlld2VkLCBJIHdpbGwgZHVwbGljYXRlIGl0IGZvcg0KZXh0Mi4NCg0KVGhhbmtzLA0KLVRvc2hp DQo=