From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAAD5C83000 for ; Tue, 28 Apr 2020 14:05:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81C68206C0 for ; Tue, 28 Apr 2020 14:05:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C5WXnMu1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81C68206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTQrf-0003xB-Ck for qemu-devel@archiver.kernel.org; Tue, 28 Apr 2020 10:05:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39564) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTQlq-0000Pn-V1 for qemu-devel@nongnu.org; Tue, 28 Apr 2020 10:04:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTQhU-0007OF-Br for qemu-devel@nongnu.org; Tue, 28 Apr 2020 09:59:34 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:56968 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jTQhT-0007Nf-Ub for qemu-devel@nongnu.org; Tue, 28 Apr 2020 09:55:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588082102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z2upbfP9Ve2G2UQfFO+T8BEfrvhjb0lpgrZuUXSgi24=; b=C5WXnMu1Tvha4Ss6l7beGU6fTeck3rK7s8JV6rukYGMCS/Ztzyy/ZGClz300SS2kCwuzdB 2N6WKzSJCzJoTu22prcKyt/f34oF/k22KTNbet4g64N/hnwmhidwOlGjNUOWeGhBFRX/uY B2zQY3VMTESODRRj5cVsxOHb6NJn7S4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-f0xVDtgYPXufnCBFdJX49g-1; Tue, 28 Apr 2020 09:55:00 -0400 X-MC-Unique: f0xVDtgYPXufnCBFdJX49g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F3352835B42; Tue, 28 Apr 2020 13:54:59 +0000 (UTC) Received: from [10.10.116.80] (ovpn-116-80.rdu2.redhat.com [10.10.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 499E260D3D; Tue, 28 Apr 2020 13:54:59 +0000 (UTC) Subject: Re: [PATCH 2/4] block: Use bdrv_make_empty() where possible To: Max Reitz , qemu-block@nongnu.org References: <20200428132629.796753-1-mreitz@redhat.com> <20200428132629.796753-3-mreitz@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <6d94e65e-b65b-4583-c66e-86cc390a3ec9@redhat.com> Date: Tue, 28 Apr 2020 08:54:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200428132629.796753-3-mreitz@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/28 02:06:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/28/20 8:26 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/replication.c | 6 ++---- > block/vvfat.c | 4 +--- > 2 files changed, 3 insertions(+), 7 deletions(-) > Yes, definitely nicer :) May have some obvious fallout to add a 0 flag parameter, per my request on 1/4, but that doesn't stop me from giving: Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org