From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51644 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932588AbeCPAsm (ORCPT ); Thu, 15 Mar 2018 20:48:42 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2G0iwGw165560 for ; Thu, 15 Mar 2018 20:48:41 -0400 Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) by mx0b-001b2d01.pphosted.com with ESMTP id 2gr12pn1n0-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Thu, 15 Mar 2018 20:48:41 -0400 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 15 Mar 2018 18:48:40 -0600 Subject: Re: [PATCH net-next v3 0/7] ibmvnic: Update TX pool and TX routines To: netdev@vger.kernel.org Cc: jallen@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, davem@davemloft.net References: <1521129763-21030-1-git-send-email-tlfalcon@linux.vnet.ibm.com> From: Thomas Falcon Date: Thu, 15 Mar 2018 19:48:36 -0500 MIME-Version: 1.0 In-Reply-To: <1521129763-21030-1-git-send-email-tlfalcon@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Message-Id: <6d96003e-5806-e62e-f383-d00992278655@linux.vnet.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: On 03/15/2018 11:02 AM, Thomas Falcon wrote: > This patch restructures the TX pool data structure and provides a > separate TX pool array for TSO transmissions. This is already used > in some way due to our unique DMA situation, namely that we cannot > use single DMA mappings for packet data. Previously, both buffer > arrays used the same pool entry. This restructuring allows for > some additional cleanup in the driver code, especially in some > places in the device transmit routine. > > In addition, it allows us to more easily track the consumer > and producer indexes of a particular pool. This has been > further improved by better tracking of in-use buffers to > prevent possible data corruption in case an invalid buffer > entry is used. > > v3: Forgot to update TX pool cleaning function to handle new data > structures. Included 7th patch for that. > > v2: Fix typo in 3/6 commit subject line > > Thomas Falcon (7): > ibmvnic: Generalize TX pool structure > ibmvnic: Update and clean up reset TX pool routine > ibmvnic: Update release TX pool routine > ibmvnic: Update TX pool initialization routine > ibmvnic: Update TX and TX completion routines > ibmvnic: Improve TX buffer accounting > ibmvnic: Update TX pool cleaning routine > > drivers/net/ethernet/ibm/ibmvnic.c | 275 +++++++++++++++++++++---------------- > drivers/net/ethernet/ibm/ibmvnic.h | 8 +- > 2 files changed, 160 insertions(+), 123 deletions(-) > Sorry again, I need to send another version because of a bug in the 7th patch.