From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJbYU-00046q-UC for qemu-devel@nongnu.org; Thu, 25 Apr 2019 06:24:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJbYT-0005m9-Oz for qemu-devel@nongnu.org; Thu, 25 Apr 2019 06:24:38 -0400 From: Thomas Huth References: <20190424103747.10173-1-thuth@redhat.com> <20190424103747.10173-6-thuth@redhat.com> <6b284aaa-353c-92c1-b01b-21882e7ff9ef@redhat.com> Message-ID: <6d98dd44-158e-136b-fc0a-105a0c4a120f@redhat.com> Date: Thu, 25 Apr 2019 12:24:24 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/6] tests: Run the iotests during "make check" again List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wainer dos Santos Moschetta , qemu-devel@nongnu.org, Markus Armbruster , Christophe Fergeau Cc: Fam Zheng , Kevin Wolf , Ed Maste , qemu-block@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Max Reitz , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Li-Wen Hsu On 25/04/2019 07.57, Thomas Huth wrote: > On 24/04/2019 22.42, Wainer dos Santos Moschetta wrote: >> Hi Thomas, >> >> >> On 04/24/2019 07:37 AM, Thomas Huth wrote: >>> People often forget to run the iotests before submitting patches or >>> pull requests - this is likely due to the fact that we do not run the >>> tests during our mandatory "make check" tests yet. Now that we've got >>> a new "ci" group of iotests that should be fine to run in every envir= on- >>> ment, it should be OK to enable the iotests during "make check" again= . >>> Thus we now run the "ci" tests by default from the qemu-iotests-quick= .sh >>> script, and only use the former "quick" group (that contains some tes= ts >>> that are failing in some environments) when the user decided to run >>> "make check SPEED=3Dthorough" or something similar. >>> >>> Signed-off-by: Thomas Huth >>> --- >>> =C2=A0 tests/Makefile.include=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2= +- >>> =C2=A0 tests/qemu-iotests-quick.sh | 17 ++++++++++++++++- >>> =C2=A0 2 files changed, 17 insertions(+), 2 deletions(-) >> >> One of Patchew's runners failed with this patch series: >> https://patchew.org/QEMU/20190424103747.10173-1-thuth@redhat.com/ >> >> I encountered same failures with `make check` locally on Fedora 29 >> x86_64 (pulled latest qemu, and configured with defaults and >> x86_64-softmmu target): >> --- >> Not run: 233 >> Failures: 069 103 114 133 140 143 197 215 226 244 >=20 > Ok, thanks for the info. Looks like many tests are failing because qemu= -io suddenly prints its program name in front of the error messages? E.g.= : >=20 > --- /tmp/qemu-test/src/tests/qemu-iotests/069.out 2019-04-24 16:52:31.0= 00000000 +0000 > +++ /tmp/qemu-test/build/tests/qemu-iotests/069.out.bad 2019-04-24 16:5= 9:13.310226424 +0000 > @@ -4,5 +4,5 @@ > =20 > Formatting 'TEST_DIR/t.IMGFMT.base', fmt=3DIMGFMT size=3D131072 > Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D131072 backing_fil= e=3DTEST_DIR/t.IMGFMT.base > -can't open device TEST_DIR/t.IMGFMT: Could not open backing file: Coul= d not open 'TEST_DIR/t.IMGFMT.base': No such file or directory > +qemu-io: can't open device TEST_DIR/t.IMGFMT: Could not open backing f= ile: Could not open 'TEST_DIR/t.IMGFMT.base': No such file or directory >=20 > Does anybody from the block folks has a clue what might be going wrong = here? It's a regression in the current master branch, not caused by my series. The iotests also fail with vanilla master, e.g. reproducible with: cd tests/qemu-iotests ./check -qcow2 069 It's caused by Christophe's commit here: 99e98d7c9fc1a1639fad2c638733b02f4b43aebe qemu-io: Use error_[gs]et_progname() Christophe, could you please have a look? Thanks, Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8878C10F03 for ; Thu, 25 Apr 2019 10:25:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CC59214AE for ; Thu, 25 Apr 2019 10:25:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CC59214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:54908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJbZm-0004p9-P1 for qemu-devel@archiver.kernel.org; Thu, 25 Apr 2019 06:25:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJbYU-00046q-UC for qemu-devel@nongnu.org; Thu, 25 Apr 2019 06:24:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJbYT-0005m9-Oz for qemu-devel@nongnu.org; Thu, 25 Apr 2019 06:24:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40660) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hJbYQ-0005je-Qi; Thu, 25 Apr 2019 06:24:35 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ABC152DA988; Thu, 25 Apr 2019 10:24:33 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-68.ams2.redhat.com [10.36.116.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 217015D705; Thu, 25 Apr 2019 10:24:24 +0000 (UTC) From: Thomas Huth To: Wainer dos Santos Moschetta , qemu-devel@nongnu.org, Markus Armbruster , Christophe Fergeau References: <20190424103747.10173-1-thuth@redhat.com> <20190424103747.10173-6-thuth@redhat.com> <6b284aaa-353c-92c1-b01b-21882e7ff9ef@redhat.com> Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: <6d98dd44-158e-136b-fc0a-105a0c4a120f@redhat.com> Date: Thu, 25 Apr 2019 12:24:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 25 Apr 2019 10:24:33 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 5/6] tests: Run the iotests during "make check" again X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Ed Maste , qemu-block@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Max Reitz , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Li-Wen Hsu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190425102424.ZDSRS7PTgLrN9MgWTpJlldheq1KFyOznmXpZCUeHr04@z> On 25/04/2019 07.57, Thomas Huth wrote: > On 24/04/2019 22.42, Wainer dos Santos Moschetta wrote: >> Hi Thomas, >> >> >> On 04/24/2019 07:37 AM, Thomas Huth wrote: >>> People often forget to run the iotests before submitting patches or >>> pull requests - this is likely due to the fact that we do not run the >>> tests during our mandatory "make check" tests yet. Now that we've got >>> a new "ci" group of iotests that should be fine to run in every envir= on- >>> ment, it should be OK to enable the iotests during "make check" again= . >>> Thus we now run the "ci" tests by default from the qemu-iotests-quick= .sh >>> script, and only use the former "quick" group (that contains some tes= ts >>> that are failing in some environments) when the user decided to run >>> "make check SPEED=3Dthorough" or something similar. >>> >>> Signed-off-by: Thomas Huth >>> --- >>> =C2=A0 tests/Makefile.include=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2= +- >>> =C2=A0 tests/qemu-iotests-quick.sh | 17 ++++++++++++++++- >>> =C2=A0 2 files changed, 17 insertions(+), 2 deletions(-) >> >> One of Patchew's runners failed with this patch series: >> https://patchew.org/QEMU/20190424103747.10173-1-thuth@redhat.com/ >> >> I encountered same failures with `make check` locally on Fedora 29 >> x86_64 (pulled latest qemu, and configured with defaults and >> x86_64-softmmu target): >> --- >> Not run: 233 >> Failures: 069 103 114 133 140 143 197 215 226 244 >=20 > Ok, thanks for the info. Looks like many tests are failing because qemu= -io suddenly prints its program name in front of the error messages? E.g.= : >=20 > --- /tmp/qemu-test/src/tests/qemu-iotests/069.out 2019-04-24 16:52:31.0= 00000000 +0000 > +++ /tmp/qemu-test/build/tests/qemu-iotests/069.out.bad 2019-04-24 16:5= 9:13.310226424 +0000 > @@ -4,5 +4,5 @@ > =20 > Formatting 'TEST_DIR/t.IMGFMT.base', fmt=3DIMGFMT size=3D131072 > Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D131072 backing_fil= e=3DTEST_DIR/t.IMGFMT.base > -can't open device TEST_DIR/t.IMGFMT: Could not open backing file: Coul= d not open 'TEST_DIR/t.IMGFMT.base': No such file or directory > +qemu-io: can't open device TEST_DIR/t.IMGFMT: Could not open backing f= ile: Could not open 'TEST_DIR/t.IMGFMT.base': No such file or directory >=20 > Does anybody from the block folks has a clue what might be going wrong = here? It's a regression in the current master branch, not caused by my series. The iotests also fail with vanilla master, e.g. reproducible with: cd tests/qemu-iotests ./check -qcow2 069 It's caused by Christophe's commit here: 99e98d7c9fc1a1639fad2c638733b02f4b43aebe qemu-io: Use error_[gs]et_progname() Christophe, could you please have a look? Thanks, Thomas