From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBG2-0000zd-GQ for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:33:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkBFx-0005zT-7p for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:33:49 -0400 Received: from 4.mo68.mail-out.ovh.net ([46.105.59.63]:50329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBFx-0005yw-1Z for qemu-devel@nongnu.org; Wed, 14 Sep 2016 10:33:45 -0400 Received: from player788.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo68.mail-out.ovh.net (Postfix) with ESMTP id 31DF9FF8E56 for ; Wed, 14 Sep 2016 16:33:42 +0200 (CEST) References: <1473244183-31510-1-git-send-email-david@gibson.dropbear.id.au> <1473244183-31510-55-git-send-email-david@gibson.dropbear.id.au> <87twdiinve.fsf@linaro.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <6da95866-cb26-5cea-37be-7b62e5746b0b@kaod.org> Date: Wed, 14 Sep 2016 16:33:30 +0200 MIME-Version: 1.0 In-Reply-To: <87twdiinve.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , David Gibson Cc: peter.maydell@linaro.org, lvivier@redhat.com, thuth@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org On 09/14/2016 03:59 PM, Alex Benn=C3=A9e wrote: >=20 > David Gibson writes: >=20 >> From: C=C3=A9dric Le Goater >> >> The exact same routine will be used in PowerNV. >> >> Signed-off-by: C=C3=A9dric Le Goater >> Signed-off-by: David Gibson >=20 > This patch has broken 32 bit x86 builds on CentOS6 (I happened to be lo= oking > at something else and found it broken): >=20 > 14:57 alex@centos6-x86/i686 [qemu.git/bisect:???] >make > CC ppc-softmmu/hw/ppc/fdt.o > In file included from /home/alex/lsrc/qemu.git/hw/ppc/fdt.c:14: > /home/alex/lsrc/qemu.git/include/hw/ppc/fdt.h:15: error: redefiniti= on of typedef =E2=80=98CPUPPCState=E2=80=99 > /home/alex/lsrc/qemu.git/target-ppc/cpu-qom.h:41: note: previous de= claration of =E2=80=98CPUPPCState=E2=80=99 was here > make[1]: *** [hw/ppc/fdt.o] Error 1 > make: *** [subdir-ppc-softmmu] Error 2 ok. CentOS6 must be 4.4 compiler, which has that kind of problem. Could you try that quick fix ? Thanks, C. =20 >>From 0d0c0ac07ef82c656a8664241bef4f8e834a9b44 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?C=3DC3=3DA9dric=3D20Le=3D20Goater?=3D Date: Wed, 14 Sep 2016 16:27:26 +0200 Subject: [PATCH] hw/ppc: fix a compile breakage on CentOS 6 MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Old versions of gcc, like on CentOS 6, do not support multiple declarations of the same typedef. Let's remove the extra one in header file hw/ppc/fdt.h. Signed-off-by: C=C3=A9dric Le Goater --- include/hw/ppc/fdt.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/ppc/fdt.h b/include/hw/ppc/fdt.h index 2c68d1616f5c..b58ef616c45c 100644 --- a/include/hw/ppc/fdt.h +++ b/include/hw/ppc/fdt.h @@ -12,8 +12,6 @@ =20 #include "qemu/error-report.h" =20 -typedef struct CPUPPCState CPUPPCState; - #define _FDT(exp) \ do { \ int ret =3D (exp); \ --=20 2.7.4 =20