From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A10A6C388F9 for ; Sun, 8 Nov 2020 07:43:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0826720719 for ; Sun, 8 Nov 2020 07:43:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DL79mtMX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0826720719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbfM3-0003ym-Uh for qemu-devel@archiver.kernel.org; Sun, 08 Nov 2020 02:43:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbfLJ-0003Pj-0S for qemu-devel@nongnu.org; Sun, 08 Nov 2020 02:42:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:31216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kbfLG-000180-13 for qemu-devel@nongnu.org; Sun, 08 Nov 2020 02:42:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604821343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HkSWPKUc0BdnLHYwEYSogXlWed22bthlu4lmi2PKMjY=; b=DL79mtMXP0I9Fh+5BtldIrLyTA7+z5Eh5BDdcJ2k1FCnwceiAO26dLPkW2KJsdTO30OCpI NEsGC/mHvWc2fxmgdJomkX8ZuPERPxIYU/pxopf3OtGdCcnoZVbESv5c76jfVDVvn6eMkp biQV7E8/CcZhrRFu+bheAVcw0kQcgC8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-oXFKULL1Ny6xl9plKzSthA-1; Sun, 08 Nov 2020 02:42:21 -0500 X-MC-Unique: oXFKULL1Ny6xl9plKzSthA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 669B556C8B; Sun, 8 Nov 2020 07:42:20 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-53.ams2.redhat.com [10.36.112.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31D01272C4; Sun, 8 Nov 2020 07:42:13 +0000 (UTC) Subject: Re: [PATCH] qtest: Fix bad printf format specifiers To: Markus Armbruster References: <5FA28117.3020802@huawei.com> <67eca43e-99ea-f2ce-5d9e-a9cb5c7a3a83@redhat.com> <877dr0rz9t.fsf@dusky.pond.sub.org> From: Thomas Huth Message-ID: <6db65449-4984-5167-9518-86c39db39a1a@redhat.com> Date: Sun, 8 Nov 2020 08:42:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <877dr0rz9t.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/08 02:42:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: AlexChen , lvivier@redhat.com, QEMU Trivial , QEMU , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 05/11/2020 09.19, Markus Armbruster wrote: > Thomas Huth writes: > >> On 04/11/2020 11.23, AlexChen wrote: >>> We should use printf format specifier "%u" instead of "%d" for >>> argument of type "unsigned int". >>> >>> Reported-by: Euler Robot >>> Signed-off-by: Alex Chen >>> --- >>> tests/qtest/arm-cpu-features.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c >>> index d20094d5a7..bc681a95d5 100644 >>> --- a/tests/qtest/arm-cpu-features.c >>> +++ b/tests/qtest/arm-cpu-features.c >>> @@ -536,7 +536,7 @@ static void test_query_cpu_model_expansion_kvm(const void *data) >>> if (kvm_supports_sve) { >>> g_assert(vls != 0); >>> max_vq = 64 - __builtin_clzll(vls); >>> - sprintf(max_name, "sve%d", max_vq * 128); >>> + sprintf(max_name, "sve%u", max_vq * 128); >>> >>> /* Enabling a supported length is of course fine. */ >>> assert_sve_vls(qts, "host", vls, "{ %s: true }", max_name); >>> @@ -556,7 +556,7 @@ static void test_query_cpu_model_expansion_kvm(const void *data) >>> * unless all larger, supported vector lengths are also >>> * disabled. >>> */ >>> - sprintf(name, "sve%d", vq * 128); >>> + sprintf(name, "sve%u", vq * 128); >>> error = g_strdup_printf("cannot disable %s", name); >>> assert_error(qts, "host", error, >>> "{ %s: true, %s: false }", >>> @@ -569,7 +569,7 @@ static void test_query_cpu_model_expansion_kvm(const void *data) >>> * we need at least one vector length enabled. >>> */ >>> vq = __builtin_ffsll(vls); >>> - sprintf(name, "sve%d", vq * 128); >>> + sprintf(name, "sve%u", vq * 128); >>> error = g_strdup_printf("cannot disable %s", name); >>> assert_error(qts, "host", error, "{ %s: false }", name); >>> g_free(error); >>> @@ -581,7 +581,7 @@ static void test_query_cpu_model_expansion_kvm(const void *data) >>> } >>> } >>> if (vq <= SVE_MAX_VQ) { >>> - sprintf(name, "sve%d", vq * 128); >>> + sprintf(name, "sve%u", vq * 128); >>> error = g_strdup_printf("cannot enable %s", name); >>> assert_error(qts, "host", error, "{ %s: true }", name); >>> g_free(error); >>> >> >> max_vq and vq are both "uint32_t" and not "unsigned int" ... so if you want > > Not quite. They are, but the product isn't. Ouch. Ok. Then let's go with this v1 patch instead of v2. Thomas