All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Víctor Colombo" <victor.colombo@eldorado.org.br>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: clg@kaod.org, danielhb413@gmail.com, david@gibson.dropbear.id.au,
	groug@kaod.org, matheus.ferst@eldorado.org.br,
	lucas.araujo@eldorado.org.br, leandro.lupori@eldorado.org.br,
	lucas.coutinho@eldorado.org.br
Subject: Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers
Date: Mon, 5 Sep 2022 17:21:11 +0100	[thread overview]
Message-ID: <6dbd2eb5-efd6-073a-a106-4afbb8abcfc2@linaro.org> (raw)
In-Reply-To: <e3153a0e-4451-3b21-7821-6877d78868e8@eldorado.org.br>

On 9/5/22 17:19, Víctor Colombo wrote:
>> Existing bug, but this is missing to clear fp status to start.
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> r~
>>
> 
> Hello Richard, thanks for your review!
> gen_reset_fpstatus() is called by the inline implementation in
> do_helper_fsqrt() before calling the helper (patch 1).

Oops, ok.


> It's probably better to move the call to inside the helper.

I did write about a scheme by which all of these calls should go away.  I guess it has 
been a while...


r~


  reply	other threads:[~2022-09-05 16:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05 12:37 [PATCH 0/3] target/ppc: Move fsqrt[s] to decodetree Víctor Colombo
2022-09-05 12:37 ` [PATCH 1/3] target/ppc: Move fsqrt " Víctor Colombo
2022-09-05 15:48   ` Richard Henderson
2022-09-05 12:37 ` [PATCH 2/3] target/ppc: Move fsqrts " Víctor Colombo
2022-09-05 15:55   ` Richard Henderson
2022-09-05 12:37 ` [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers Víctor Colombo
2022-09-05 15:56   ` Richard Henderson
2022-09-05 16:19     ` Víctor Colombo
2022-09-05 16:21       ` Richard Henderson [this message]
2022-09-05 16:31         ` Víctor Colombo
2022-09-05 17:20           ` Richard Henderson
2022-09-06 14:22             ` Víctor Colombo
2022-09-08  7:52               ` Richard Henderson
2022-09-06 20:07 ` [PATCH 0/3] target/ppc: Move fsqrt[s] to decodetree Daniel Henrique Barboza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6dbd2eb5-efd6-073a-a106-4afbb8abcfc2@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=leandro.lupori@eldorado.org.br \
    --cc=lucas.araujo@eldorado.org.br \
    --cc=lucas.coutinho@eldorado.org.br \
    --cc=matheus.ferst@eldorado.org.br \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=victor.colombo@eldorado.org.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.