From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55A7CC25B50 for ; Sat, 21 Jan 2023 16:12:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbjAUQMg (ORCPT ); Sat, 21 Jan 2023 11:12:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjAUQMg (ORCPT ); Sat, 21 Jan 2023 11:12:36 -0500 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CC281E9D4 for ; Sat, 21 Jan 2023 08:12:34 -0800 (PST) Received: from [192.168.1.139] ([37.4.248.41]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MPrXf-1p6yVu2Go7-00Muru; Sat, 21 Jan 2023 17:12:09 +0100 Message-ID: <6dc81996-6ffc-c1bc-6c3f-ca65055c94a2@i2se.com> Date: Sat, 21 Jan 2023 17:12:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 3/7] serial: imx: do not sysrq broken chars Content-Language: en-US To: Sergey Organov , linux-serial@vger.kernel.org Cc: Fabio Estevam , Greg Kroah-Hartman , Jiri Slaby , Richard Genoud , Sascha Hauer , Shawn Guo , Tim Harvey , =?UTF-8?Q?Tomasz_Mo=c5=84?= , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Johan Hovold , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Sherry Sun , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Pengutronix Kernel Team References: <87bko4e65y.fsf@osv.gnss.ru> <20230121153639.15402-1-sorganov@gmail.com> <20230121153639.15402-4-sorganov@gmail.com> From: Stefan Wahren In-Reply-To: <20230121153639.15402-4-sorganov@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:2YADwGzkJ2977gcN2dZbwsjc/4ttSWw7nzInE6yna05u6rGzVgz t6iOnkoNzAUelkDVjAgwpIDfzPH2v9u56AWQjNDpCRKwNJEJ7iYFj3q1OOunwRiogZGPxRQ hczz0Cn1u37yZTAX5YebVzYVhv/UEDM91teZ/fK/wJ4+WaOUpNMvQmZwfXRplu8D6OrBvTg NDJMq4RRfGlWAGn7iSL8A== UI-OutboundReport: notjunk:1;M01:P0:Xj/MohnC4sw=;PGjFhCpmLQamjWN9SrdDJzNi9mI sUF4zS+PBJhwPHtOlziiDad1rGPYd32MN5TDv6SbIJh5SSr9HB/Qz/IyD0kMBoFr1arwvT49P KgUaalF2V39VLcMFkYO6qNXAbuenZGWQc3xrXCbzYqKjdl/BlUd1gCvN1UuHl9YBbCQ+L0mPr +6weGI0UGuD6QmXTOkwl2Fu7esaeemRN2MPDauwsdHqZr9wyiomg2iQYHWY2fUpLdgD7/SHQD qv9iDL7CPJytKAb4agnbQcqx4qdtyAVBF4j5WI2zG+AsuCsrmPj2/ziYUbjeDi+QAHbrLu4ik KdAS1w7XpMu+Ic9OJY77DP51NqztE1JGrMwlccnDuWnDSpcBTnyzgBKgD6DhU0PHimQFWWjRj vPr2oPIv1bEryVzwARAqr7A72dlc/09Cmj7JmUv+vhR3hKZVY0l0ZDMBxI0a5npIQjwaj0XS4 ZR/DSRtW/LnWzAGPwf2XgsHnu7yd234b34EJTRjjxXQ7jsjJHgwxCpGby+EPgiuDWYSt7DWtR ZvQzkizcAdajEgCtsooPqsNNzlvgTStDmONQWyjdusvy0UKxcOJQYJtf42nge2JZtwBkGmwpV 7263XTkPqrrtKTk5HKPrEKbNhhgpluFza0NPIjVwheyiZXtotKVpa8+CoefQjH2zh1TiRbxNK KkXKMHnkRcpUBhWmdeW4vpLB0/W3Qjdw+2aF1BA1Iw== Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hi Sergey, Am 21.01.23 um 16:36 schrieb Sergey Organov: > Do not call uart_handle_sysrq_char() if we got any receive error along with > the character, as we don't want random junk to be considered a sysrq. > > Signed-off-by: Sergey Organov this looks like a bugfix to me. Since the relevant code is pretty old, i'm not sure about the fixes tag here: Fixes: 279a9acc9b72 ("2.6.11 import") ? > --- > drivers/tty/serial/imx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index e7fce31e460d..e709118fe85c 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -911,9 +911,6 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) > continue; > } > > - if (uart_handle_sysrq_char(&sport->port, (unsigned char)rx)) > - continue; > - > if (unlikely(rx & URXD_ERR)) { > if (rx & URXD_BRK) > sport->port.icount.brk++; > @@ -942,6 +939,8 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) > flg = TTY_OVERRUN; > > sport->port.sysrq = 0; > + } else if (uart_handle_sysrq_char(&sport->port, (unsigned char)rx)) { > + continue; > } > > if (sport->port.ignore_status_mask & URXD_DUMMY_READ) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56116C004D4 for ; Sat, 21 Jan 2023 16:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qj0CltqTwZDM/gOnKNW+Y9RksMp1EvspmG3QJTSwY1A=; b=OovE927OIN7Hsn hXpm8zM8YwbcsT/cuVRySeW49+TcARYlJetIpT1Wp8f9iSo6AkC7QRLNFRJ/z37zASl/5Mk9wM3y3 Ep6laijaGJ3s5Czsgn47/t7KKzOc2FZMCVoaDLPQZKnQJVuFzgd7gaizgxa73LsqEcZiggMYbOQk3 3Gq8jFYF3ZGJx34LyPDcXOGJ5EdFMabNn2zXQsMkzu0NOuPoxyuMJ49QPGCXsepaVwTt80Amtzco3 H6H/ubPYWWDSZGBFOmXmOCkyPdt1YaKTMg4j4SN/iGFZvCCjAAVPPHUELWtbn/1Xuvz2Ziq30TFBW TZWUwFibgM2NGmQjpMMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJGTm-00E8Ev-IA; Sat, 21 Jan 2023 16:12:30 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJGTi-00E8EW-Ex for linux-arm-kernel@lists.infradead.org; Sat, 21 Jan 2023 16:12:28 +0000 Received: from [192.168.1.139] ([37.4.248.41]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MPrXf-1p6yVu2Go7-00Muru; Sat, 21 Jan 2023 17:12:09 +0100 Message-ID: <6dc81996-6ffc-c1bc-6c3f-ca65055c94a2@i2se.com> Date: Sat, 21 Jan 2023 17:12:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 3/7] serial: imx: do not sysrq broken chars Content-Language: en-US To: Sergey Organov , linux-serial@vger.kernel.org Cc: Fabio Estevam , Greg Kroah-Hartman , Jiri Slaby , Richard Genoud , Sascha Hauer , Shawn Guo , Tim Harvey , =?UTF-8?Q?Tomasz_Mo=c5=84?= , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Johan Hovold , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Sherry Sun , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Pengutronix Kernel Team References: <87bko4e65y.fsf@osv.gnss.ru> <20230121153639.15402-1-sorganov@gmail.com> <20230121153639.15402-4-sorganov@gmail.com> From: Stefan Wahren In-Reply-To: <20230121153639.15402-4-sorganov@gmail.com> X-Provags-ID: V03:K1:2YADwGzkJ2977gcN2dZbwsjc/4ttSWw7nzInE6yna05u6rGzVgz t6iOnkoNzAUelkDVjAgwpIDfzPH2v9u56AWQjNDpCRKwNJEJ7iYFj3q1OOunwRiogZGPxRQ hczz0Cn1u37yZTAX5YebVzYVhv/UEDM91teZ/fK/wJ4+WaOUpNMvQmZwfXRplu8D6OrBvTg NDJMq4RRfGlWAGn7iSL8A== UI-OutboundReport: notjunk:1;M01:P0:Xj/MohnC4sw=;PGjFhCpmLQamjWN9SrdDJzNi9mI sUF4zS+PBJhwPHtOlziiDad1rGPYd32MN5TDv6SbIJh5SSr9HB/Qz/IyD0kMBoFr1arwvT49P KgUaalF2V39VLcMFkYO6qNXAbuenZGWQc3xrXCbzYqKjdl/BlUd1gCvN1UuHl9YBbCQ+L0mPr +6weGI0UGuD6QmXTOkwl2Fu7esaeemRN2MPDauwsdHqZr9wyiomg2iQYHWY2fUpLdgD7/SHQD qv9iDL7CPJytKAb4agnbQcqx4qdtyAVBF4j5WI2zG+AsuCsrmPj2/ziYUbjeDi+QAHbrLu4ik KdAS1w7XpMu+Ic9OJY77DP51NqztE1JGrMwlccnDuWnDSpcBTnyzgBKgD6DhU0PHimQFWWjRj vPr2oPIv1bEryVzwARAqr7A72dlc/09Cmj7JmUv+vhR3hKZVY0l0ZDMBxI0a5npIQjwaj0XS4 ZR/DSRtW/LnWzAGPwf2XgsHnu7yd234b34EJTRjjxXQ7jsjJHgwxCpGby+EPgiuDWYSt7DWtR ZvQzkizcAdajEgCtsooPqsNNzlvgTStDmONQWyjdusvy0UKxcOJQYJtf42nge2JZtwBkGmwpV 7263XTkPqrrtKTk5HKPrEKbNhhgpluFza0NPIjVwheyiZXtotKVpa8+CoefQjH2zh1TiRbxNK KkXKMHnkRcpUBhWmdeW4vpLB0/W3Qjdw+2aF1BA1Iw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230121_081226_836342_3FE0ACB6 X-CRM114-Status: GOOD ( 17.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sergey, Am 21.01.23 um 16:36 schrieb Sergey Organov: > Do not call uart_handle_sysrq_char() if we got any receive error along with > the character, as we don't want random junk to be considered a sysrq. > > Signed-off-by: Sergey Organov this looks like a bugfix to me. Since the relevant code is pretty old, i'm not sure about the fixes tag here: Fixes: 279a9acc9b72 ("2.6.11 import") ? > --- > drivers/tty/serial/imx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index e7fce31e460d..e709118fe85c 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -911,9 +911,6 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) > continue; > } > > - if (uart_handle_sysrq_char(&sport->port, (unsigned char)rx)) > - continue; > - > if (unlikely(rx & URXD_ERR)) { > if (rx & URXD_BRK) > sport->port.icount.brk++; > @@ -942,6 +939,8 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) > flg = TTY_OVERRUN; > > sport->port.sysrq = 0; > + } else if (uart_handle_sysrq_char(&sport->port, (unsigned char)rx)) { > + continue; > } > > if (sport->port.ignore_status_mask & URXD_DUMMY_READ) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel