From: Robert Hoo <robert.hu@linux.intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com,
jmattson@google.com, joro@8bytes.org, chang.seok.bae@intel.com,
kvm@vger.kernel.org, robert.hu@intel.com
Subject: Re: [RFC PATCH 03/12] kvm/vmx: Introduce the new tertiary processor-based VM-execution controls
Date: Tue, 06 Apr 2021 11:37:56 +0800 [thread overview]
Message-ID: <6dd6b2f954642ae16fc24f58dda224af0657a248.camel@linux.intel.com> (raw)
In-Reply-To: <YGsu+ckrwEsZSUoN@google.com>
On Mon, 2021-04-05 at 15:38 +0000, Sean Christopherson wrote:
> On Mon, Jan 25, 2021, Robert Hoo wrote:
> > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
> > index f6f66e5..94f1c27 100644
> > --- a/arch/x86/kvm/vmx/vmx.h
> > +++ b/arch/x86/kvm/vmx/vmx.h
> > @@ -373,6 +373,14 @@ static inline u8 vmx_get_rvi(void)
> > BUILD_CONTROLS_SHADOW(exec, CPU_BASED_VM_EXEC_CONTROL)
> > BUILD_CONTROLS_SHADOW(secondary_exec, SECONDARY_VM_EXEC_CONTROL)
> >
> > +static inline void tertiary_exec_controls_set(struct vcpu_vmx
> > *vmx, u64 val)
> > +{
> > + if (vmx->loaded_vmcs->controls_shadow.tertiary_exec != val) {
> > + vmcs_write64(TERTIARY_VM_EXEC_CONTROL, val);
> > + vmx->loaded_vmcs->controls_shadow.tertiary_exec = val;
> > + }
> > +}
>
> Add a "bits" param to the builder macros and use string
> concatenation, then the
> tertiary controls can share those macros.
>
> diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
> index 7886a08505cc..328039157535 100644
> --- a/arch/x86/kvm/vmx/vmx.h
> +++ b/arch/x86/kvm/vmx/vmx.h
> @@ -398,25 +398,25 @@ static inline u8 vmx_get_rvi(void)
> return vmcs_read16(GUEST_INTR_STATUS) & 0xff;
> }
>
> -#define BUILD_CONTROLS_SHADOW(lname,
> uname) \
> -static inline void lname##_controls_set(struct vcpu_vmx *vmx, u32
> val) \
> -{
> \
> - if (vmx->loaded_vmcs->controls_shadow.lname != val)
> { \
> - vmcs_write32(uname,
> val); \
> - vmx->loaded_vmcs->controls_shadow.lname =
> val; \
> - }
> \
> -}
> \
> -static inline u32 lname##_controls_get(struct vcpu_vmx
> *vmx) \
> -{
> \
> - return vmx->loaded_vmcs-
> >controls_shadow.lname; \
> -}
> \
> -static inline void lname##_controls_setbit(struct vcpu_vmx *vmx, u32
> val) \
> -{
> \
> - lname##_controls_set(vmx, lname##_controls_get(vmx) |
> val); \
> -}
> \
> -static inline void lname##_controls_clearbit(struct vcpu_vmx *vmx,
> u32 val) \
> -{
> \
> - lname##_controls_set(vmx, lname##_controls_get(vmx) &
> ~val); \
> +#define BUILD_CONTROLS_SHADOW(lname, uname,
> bits) \
> +static inline void lname##_controls_set(struct vcpu_vmx *vmx,
> u##bits val) \
> +{
> \
> + if (vmx->loaded_vmcs->controls_shadow.lname != val)
> { \
> + vmcs_write##bits(uname,
> val); \
> + vmx->loaded_vmcs->controls_shadow.lname =
> val; \
> + }
> \
> +}
> \
> +static inline u##bits lname##_controls_get(struct vcpu_vmx
> *vmx) \
> +{
> \
> + return vmx->loaded_vmcs-
> >controls_shadow.lname; \
> +}
> \
> +static inline void lname##_controls_setbit(struct vcpu_vmx *vmx,
> u##bits val) \
> +{
> \
> + lname##_controls_set(vmx, lname##_controls_get(vmx) |
> val); \
> +}
> \
> +static inline void lname##_controls_clearbit(struct vcpu_vmx *vmx,
> u##bits val) \
> +{
> \
> + lname##_controls_set(vmx, lname##_controls_get(vmx) &
> ~val); \
> }
> BUILD_CONTROLS_SHADOW(vm_entry, VM_ENTRY_CONTROLS)
> BUILD_CONTROLS_SHADOW(vm_exit, VM_EXIT_CONTROLS)
>
Nice. I like this. Thanks Sean.
Shall I separated this hunk a patch and have your "Signed-off-by:"?
> > +
> > static inline void vmx_register_cache_reset(struct kvm_vcpu *vcpu)
> > {
> > vcpu->arch.regs_avail = ~((1 << VCPU_REGS_RIP) | (1 <<
> > VCPU_REGS_RSP)
> > --
> > 1.8.3.1
> >
next prev parent reply other threads:[~2021-04-06 3:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 9:06 [RFC PATCH 00/12] KVM: Support Intel KeyLocker Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 01/12] x86/keylocker: Move LOADIWKEY opcode definition from keylocker.c to keylocker.h Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 02/12] x86/cpufeature: Add CPUID.19H:{EBX,ECX} cpuid leaves Robert Hoo
2021-04-05 15:32 ` Sean Christopherson
2021-04-06 3:34 ` Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 03/12] kvm/vmx: Introduce the new tertiary processor-based VM-execution controls Robert Hoo
2021-01-25 9:41 ` Vitaly Kuznetsov
2021-01-26 9:27 ` Robert Hoo
2021-02-03 6:32 ` Robert Hoo
2021-02-03 8:45 ` Vitaly Kuznetsov
2021-04-05 15:38 ` Sean Christopherson
2021-04-06 3:37 ` Robert Hoo [this message]
2021-01-25 9:06 ` [RFC PATCH 04/12] kvm/vmx: enable LOADIWKEY vm-exit support in " Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 05/12] kvm/vmx: Add KVM support on KeyLocker operations Robert Hoo
2021-04-05 16:25 ` Sean Christopherson
2021-04-08 5:44 ` Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 06/12] kvm/cpuid: Enumerate KeyLocker feature in KVM Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 07/12] kvm/vmx/nested: Support new IA32_VMX_PROCBASED_CTLS3 vmx feature control MSR Robert Hoo
2021-04-05 15:44 ` Sean Christopherson
2021-04-08 5:45 ` Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 08/12] kvm/vmx: Refactor vmx_compute_tertiary_exec_control() Robert Hoo
2021-04-05 15:46 ` Sean Christopherson
2021-04-08 5:45 ` Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 09/12] kvm/vmx/vmcs12: Add Tertiary Exec-Control field in vmcs12 Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 10/12] kvm/vmx/nested: Support tertiary VM-Exec control in vmcs02 Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 11/12] kvm/vmx/nested: Support CR4.KL in nested Robert Hoo
2021-01-25 9:06 ` [RFC PATCH 12/12] kvm/vmx/nested: Enable nested LOADIWKey VM-exit Robert Hoo
2021-04-05 16:03 ` [RFC PATCH 00/12] KVM: Support Intel KeyLocker Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dd6b2f954642ae16fc24f58dda224af0657a248.camel@linux.intel.com \
--to=robert.hu@linux.intel.com \
--cc=chang.seok.bae@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=robert.hu@intel.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.