From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DDAC46460 for ; Fri, 31 May 2019 15:02:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A4BA23774 for ; Fri, 31 May 2019 15:02:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="J0mJR0rY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbfEaPCW (ORCPT ); Fri, 31 May 2019 11:02:22 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45528 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726547AbfEaPCW (ORCPT ); Fri, 31 May 2019 11:02:22 -0400 Received: by mail-wr1-f65.google.com with SMTP id b18so6712680wrq.12 for ; Fri, 31 May 2019 08:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yhVi3GTFCQvvTIxl5mOOdrJTPKmESuh+XsvZuHIBFUA=; b=J0mJR0rYbu7nLXSjhS2+ZbFJdnv5aUwWyTszsu5dt3yPf3YX8TrJVy8ES8a3v/0JBD 2wL+73E34KfUz2DwRGECSq9Rk6kRsnZzQTtn5nrhxO5c7CcidX6RvoD3B1Rv/iuiF8Un tsWUNKFY/AOEstNJVHdihksOAFNs9HR78/tM3IqeTLkx4WKxHNTf1J4wCLzSZ8QAGm/y uM9XwSon/jIun8o1gzwHxRHjqODnKlqzsnyezjtyGnN4wHP0xdvzfBlLvmlcLFbtOnuw mg2fGVxQVRzLNKjEafr3tWV/vi8fSDiZDqrY3Dh7xOmco0bJShp89adqEpQimpA65kRI ue2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yhVi3GTFCQvvTIxl5mOOdrJTPKmESuh+XsvZuHIBFUA=; b=n0BG/Z0V4iYFHzxdZ67muaHJbM14NGfgW9x2gp+iiDFMMjfvcJb5uCkk+8scALmOAl e1pcjKwLpcOc4Gq1A36VOdzQ74xkPE1HwIOEu0O6VuK9X82KEOO7UAXyhwnvvBeZhX59 dSn8NNSAUmbsrZmUVJCreRSYwOxgTYbspLYGmHyab8WdhewFAzvTFYbkLTar71/COywQ srRSIHlBbxUT9z+1I7jLJdR66JpEEKzkJtfo06Pkmykl72dDVGHe9MVJb/Ev+ig0oXea OWHHxb3W5Gv9cs4e8SEZVQlRQSAwWhDutoCRk1xWmAsKG47rteIaQ4OGvtzKB84Uss1M RoUg== X-Gm-Message-State: APjAAAV6vboGJ8gm5cELTOyAZsww7TWyFlf8ZYDQVWRiJxgRYmwaynXA ZpP+vyjwlmrNn+ugAeLRTTo1QA== X-Google-Smtp-Source: APXvYqys8NqsVcs78h+7pzuMj6F9INb4P295nbS8UFgQK4YSDSuwHD81dGbsvau2gG921pNHh+h4rA== X-Received: by 2002:adf:b643:: with SMTP id i3mr7333639wre.284.1559314940594; Fri, 31 May 2019 08:02:20 -0700 (PDT) Received: from [192.168.112.17] (nikaet.starlink.ru. [94.141.168.29]) by smtp.gmail.com with ESMTPSA id u205sm7254690wmu.47.2019.05.31.08.02.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 08:02:20 -0700 (PDT) Subject: Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0 To: Vivien Didelot Cc: Andrew Lunn , Florian Fainelli , "David S. Miller" , Heiner Kallweit , =?UTF-8?Q?Marek_Beh=c3=ban?= , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Healy References: <20190531073514.2171-1-nikita.yoush@cogentembedded.com> <20190531103105.GE23464@t480s.localdomain> <20190531143758.GB23821@lunn.ch> <422482dc-8887-0f92-c8c9-f9d639882c77@cogentembedded.com> <20190531110017.GB2075@t480s.localdomain> From: Nikita Yushchenko Message-ID: <6dd8f8d5-9453-ab94-3aae-18eb5e35b051@cogentembedded.com> Date: Fri, 31 May 2019 18:02:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190531110017.GB2075@t480s.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Kernel currently does, but it is caught in >> mv88e6xxx_port_check_hw_vlan() and returns -ENOTSUPP from there. > > But VID 0 has a special meaning for the kernel, it means the port's private > database (when it is isolated, non-bridged), it is not meant to be programmed > in the switch. That's why I would've put that knowledge into the DSA layer, > which job is to translate the kernel operations to the (dumb) DSA drivers. > > I hope I'm seeing things correctly here. I'm ok with either solution.