From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A4B8C433F5 for ; Thu, 29 Sep 2022 17:07:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0228010EB4E; Thu, 29 Sep 2022 17:07:02 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B634010EB4C; Thu, 29 Sep 2022 17:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664471216; x=1696007216; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=qqP7bXZfWN3ubK4nqoz1CZPrDOhfJnd0ShZ+86KT7Og=; b=jVv6ltVpEqwjnt7f7mAd5H3eoKMiC8l5EWOZ2eN5arsqOpncsziVRA18 nu8JSAsaBwPyYgo5OECnXlBZoGvoHTXfPl0liMFA1Vm8GOjVq41lOknCE yie9UOuTsrSVHVWeIF0mJGMHgVbDXFtXfPGsxrRPW7+7OQY97OaA8CLmW 1SwKaE9tVlJWIeJkOnmezg7kF/cyLVuOAdvJ/5LyBbq5hQPSKanBlrraV eDp0j3DiNohmCAmmOUdz2f3Lp8c3as+4SftnWVsJtQ+sQP49UZQLZDkaC 7sTKd9FHYnhbwS2OBF6yGQlqP/9SxK/sbKnub0uK/US5Y/QW1aZ/tr7Gy Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="289128323" X-IronPort-AV: E=Sophos;i="5.93,355,1654585200"; d="scan'208";a="289128323" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 10:04:43 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="684926921" X-IronPort-AV: E=Sophos;i="5.93,355,1654585200"; d="scan'208";a="684926921" Received: from bpingot-mobl1.ger.corp.intel.com (HELO [10.252.6.106]) ([10.252.6.106]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 10:04:40 -0700 Message-ID: <6de15aaf-e88a-5cfc-3216-58d9c5ba5fba@intel.com> Date: Thu, 29 Sep 2022 18:04:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.3.0 Subject: Re: [PATCH 04/16] drm/i915/vm_bind: Add support to create persistent vma Content-Language: en-GB To: Niranjana Vishwanathapura , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20220928061918.6340-1-niranjana.vishwanathapura@intel.com> <20220928061918.6340-5-niranjana.vishwanathapura@intel.com> From: Matthew Auld In-Reply-To: <20220928061918.6340-5-niranjana.vishwanathapura@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: matthew.brost@intel.com, paulo.r.zanoni@intel.com, tvrtko.ursulin@intel.com, jani.nikula@intel.com, lionel.g.landwerlin@intel.com, thomas.hellstrom@intel.com, jason@jlekstrand.net, andi.shyti@linux.intel.com, daniel.vetter@intel.com, christian.koenig@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: > Add i915_vma_instance_persistent() to create persistent vmas. > Persistent vmas will use i915_gtt_view to support partial binding. > > vma_lookup is tied to segment of the object instead of section > of VA space. Hence, it do not support aliasing. ie., multiple > mappings (at different VA) point to the same gtt_view of object. > Skip vma_lookup for persistent vmas to support aliasing. > > Signed-off-by: Niranjana Vishwanathapura > Signed-off-by: Andi Shyti Acked-by: Matthew Auld From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 388A1C4332F for ; Thu, 29 Sep 2022 17:07:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B6B110EB55; Thu, 29 Sep 2022 17:07:06 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B634010EB4C; Thu, 29 Sep 2022 17:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664471216; x=1696007216; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=qqP7bXZfWN3ubK4nqoz1CZPrDOhfJnd0ShZ+86KT7Og=; b=jVv6ltVpEqwjnt7f7mAd5H3eoKMiC8l5EWOZ2eN5arsqOpncsziVRA18 nu8JSAsaBwPyYgo5OECnXlBZoGvoHTXfPl0liMFA1Vm8GOjVq41lOknCE yie9UOuTsrSVHVWeIF0mJGMHgVbDXFtXfPGsxrRPW7+7OQY97OaA8CLmW 1SwKaE9tVlJWIeJkOnmezg7kF/cyLVuOAdvJ/5LyBbq5hQPSKanBlrraV eDp0j3DiNohmCAmmOUdz2f3Lp8c3as+4SftnWVsJtQ+sQP49UZQLZDkaC 7sTKd9FHYnhbwS2OBF6yGQlqP/9SxK/sbKnub0uK/US5Y/QW1aZ/tr7Gy Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="289128323" X-IronPort-AV: E=Sophos;i="5.93,355,1654585200"; d="scan'208";a="289128323" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 10:04:43 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="684926921" X-IronPort-AV: E=Sophos;i="5.93,355,1654585200"; d="scan'208";a="684926921" Received: from bpingot-mobl1.ger.corp.intel.com (HELO [10.252.6.106]) ([10.252.6.106]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 10:04:40 -0700 Message-ID: <6de15aaf-e88a-5cfc-3216-58d9c5ba5fba@intel.com> Date: Thu, 29 Sep 2022 18:04:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.3.0 Content-Language: en-GB To: Niranjana Vishwanathapura , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20220928061918.6340-1-niranjana.vishwanathapura@intel.com> <20220928061918.6340-5-niranjana.vishwanathapura@intel.com> From: Matthew Auld In-Reply-To: <20220928061918.6340-5-niranjana.vishwanathapura@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 04/16] drm/i915/vm_bind: Add support to create persistent vma X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: paulo.r.zanoni@intel.com, jani.nikula@intel.com, thomas.hellstrom@intel.com, daniel.vetter@intel.com, christian.koenig@amd.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: > Add i915_vma_instance_persistent() to create persistent vmas. > Persistent vmas will use i915_gtt_view to support partial binding. > > vma_lookup is tied to segment of the object instead of section > of VA space. Hence, it do not support aliasing. ie., multiple > mappings (at different VA) point to the same gtt_view of object. > Skip vma_lookup for persistent vmas to support aliasing. > > Signed-off-by: Niranjana Vishwanathapura > Signed-off-by: Andi Shyti Acked-by: Matthew Auld