From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B84C433E1 for ; Wed, 26 Aug 2020 08:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E87B207BC for ; Wed, 26 Aug 2020 08:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbgHZIzn (ORCPT ); Wed, 26 Aug 2020 04:55:43 -0400 Received: from spam.zju.edu.cn ([61.164.42.155]:34038 "EHLO zju.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727793AbgHZIzn (ORCPT ); Wed, 26 Aug 2020 04:55:43 -0400 Received: by ajax-webmail-mail-app2 (Coremail) ; Wed, 26 Aug 2020 16:55:14 +0800 (GMT+08:00) X-Originating-IP: [210.32.144.184] Date: Wed, 26 Aug 2020 16:55:14 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: dinghao.liu@zju.edu.cn To: "Chen-Yu Tsai" Cc: "Kangjie Lu" , linux-rtc@vger.kernel.org, "Alessandro Zummo" , "Alexandre Belloni" , linux-kernel , "Maxime Ripard" , linux-arm-kernel Subject: Re: Re: [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.12 build 20200616(0f5d8152) Copyright (c) 2002-2020 www.mailtech.cn zju.edu.cn In-Reply-To: References: <20200823075815.23457-1-dinghao.liu@zju.edu.cn> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Message-ID: <6de4a430.8e03.17429fa786d.Coremail.dinghao.liu@zju.edu.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: by_KCgD3n51yI0ZfOXIzAg--.52907W X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAgwEBlZdtPrA+AABsw X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJTRUUUbGCS07vEb7Iv0x C_JF4lV2xY67kC6x804xWlV2xY67CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DMIAI bVAFxVCF77xC64kEw24lV2xY67C26IkvcIIF6IxKo4kEV4ylV2xY628lY4IE4IxF12IF4w CS07vE84x0c7CEj48ve4kI8wCS07vE84ACjcxK6xIIjxv20xvE14v26w1j6s0DMIAIbVA2 z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWxJr0_GcWlV2xY628EF7xvwVC2z280aVAFwI0_Gc CE3s1lV2xY628EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wCS07vEe2I262IYc4CY6c8I j28IcVAaY2xG8wCS07vE5I8CrVACY4xI64kE6c02F40Ex7xfMIAIbVAv7VC0I7IYx2IY67 AKxVWUJVWUGwCS07vEYx0Ex4A2jsIE14v26r1j6r4UMIAIbVAm72CE4IkC6x0Yz7v_Jr0_ Gr1lV2xY6x02cVAKzwCS07vEc2xSY4AK67AK6r43MIAIbVCY0x0Ix7I2Y4AK64vIr41lV2 xY6xAIw28IcVCjz48v1sIEY20_GFWkJr1UJwCS07vE4x8a6x804xWlV2xY6xC20s026xCa FVCjc4AY6r1j6r4UMIAIbVC20s026c02F40E14v26r1j6r18MIAIbVC20s026x8GjcxK67 AKxVWUGVWUWwCS07vEx4CE17CEb7AF67AKxVWUtVW8ZwCS07vEIxAIcVC0I7IYx2IY67AK xVWUJVWUCwCS07vEIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIAIbVCI42IY6xAIw2 0EY4v20xvaj40_WFyUJVCq3wCS07vEIxAIcVC2z280aVAFwI0_Jr0_Gr1lV2xY6IIF0xvE x4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUU== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiBPbiBTdW4sIEF1ZyAyMywgMjAyMCBhdCAzOjU5IFBNIERpbmdoYW8gTGl1IDxkaW5naGFvLmxp dUB6anUuZWR1LmNuPiB3cm90ZToKPiA+Cj4gPiBXaGVuIGNsa19od19yZWdpc3Rlcl9maXhlZF9y YXRlX3dpdGhfYWNjdXJhY3koKSBmYWlscywKPiA+IGNsa19kYXRhIHNob3VsZCBiZSBmcmVlZC4g SXQncyB0aGUgc2FtZSBmb3IgdGhlIHN1YnNlcXVlbnQKPiA+IGVycm9yIHBhdGhzLgo+IAo+IEkg c3VwcG9zZSB5b3Ugc2hvdWxkIGFsc28gdW5yZWdpc3RlciB0aGUgYWxyZWFkeSByZWdpc3RlcmVk IGNsb2Nrcwo+IGluIHRoZSBsYXR0ZXIgdHdvIGVycm9yIHBhdGhzPwo+IAoKU291bmRzIHJlYXNv bmFibGUuIEJ1dCBJIGZpbmQgdGhhdCB0aGUgZXhpc3Rpbmcga2VybmVsIGNvZGUgdGFrZXMgZGlm ZmVyZW50CnN0cmF0ZWdpZXMgZm9yIHRoaXMgY2FzZS4gb2Zfc2FtYTVkNF9zY2tjX3NldHVwKCkg dXNlcyBjbGtfaHdfdW5yZWdpc3RlcigpIAphZnRlciBjbGtfaHdfcmVnaXN0ZXJfZml4ZWRfcmF0 ZV93aXRoX2FjY3VyYWN5KCksIHdoaWxlIF9vZl9maXhlZF9jbGtfc2V0dXAoKQp1c2VzIGNsa19o d191bnJlZ2lzdGVyX2ZpeGVkX3JhdGUoKS4gQnV0IGF0OTFzYW05MjZ4X3BtY19zZXR1cCgpIGp1 c3QgZG9lcwpub3RoaW5nIGluIHRoaXMgY2FzZS4KCkFsc28sIHRjb25fY2gxX3NldHVwKCkgdXNl cyBjbGtfdW5yZWdpc3RlcigpIGFmdGVyIGNsa19yZWdpc3RlcigpLCB3aGlsZQpjbGtfcmVnaXN0 ZXJfdmNvX3BsbCgpIGp1c3QgZG9lcyBub3RoaW5nLiAKClNvIEknbSBub3Qgc3VyZSBpZiB3ZSBz aG91bGQgcmVnaXN0ZXIgaGVyZSBhbmQgd2hpY2ggdW5yZWdpc3RlciBmdW5jdGlvbiB0byAKdXNl LiBXb3VsZCB5b3UgcGxlYXNlIGdpdmUgbWUgbW9yZSBzcGVjaWZpYyBhZHZpY2UgYWJvdXQgdGhp cyBwcm9ibGVtPwoKUmVnYXJkcywKRGluZ2hhbw== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 051D6C433E3 for ; Wed, 26 Aug 2020 08:56:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B57D020786 for ; Wed, 26 Aug 2020 08:56:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="STWvL+S8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B57D020786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:MIME-Version:References:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=esG2IBfT1ljJYj8NgDEatl3DDueuEoM5+1BXQzqAuRY=; b=STWvL+S8mD3SUqPcxofr3GxQE Amb/5J1h6DJyS663jvnKOL+9E4kYKkM3H7ouXvmeMVE1RANL7P+vbdtvUTGyeXK6mz20sWpBJRqL2 tZ8caLg6HFMdC2goLzMbJsThE9iHd4SEQ8qy8R9Rqljiix73huf2f8n6YUNq3VgKVhY9OZ7SDYqZo Yf9eVR6haxPDoRVdn4KxOWrDWFdmf5DMH475rjo1PzjBzvaFCycm5yO8LQWDCEvAMe1zccGVA38TT hLjKFdAv6ih2DsvXQObOl9z/9AqwmI+LjkR2oUAN7z6GiCo8ONQPML9zF+DvOR8Y0znLuQ1MR9LYJ cj9BM4EoQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kArDb-0001V9-4p; Wed, 26 Aug 2020 08:55:43 +0000 Received: from mail.zju.edu.cn ([61.164.42.155] helo=zju.edu.cn) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kArDY-0001PT-Gd for linux-arm-kernel@lists.infradead.org; Wed, 26 Aug 2020 08:55:42 +0000 Received: by ajax-webmail-mail-app2 (Coremail) ; Wed, 26 Aug 2020 16:55:14 +0800 (GMT+08:00) X-Originating-IP: [210.32.144.184] Date: Wed, 26 Aug 2020 16:55:14 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: dinghao.liu@zju.edu.cn To: "Chen-Yu Tsai" Subject: Re: Re: [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.12 build 20200616(0f5d8152) Copyright (c) 2002-2020 www.mailtech.cn zju.edu.cn In-Reply-To: References: <20200823075815.23457-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Message-ID: <6de4a430.8e03.17429fa786d.Coremail.dinghao.liu@zju.edu.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: by_KCgD3n51yI0ZfOXIzAg--.52907W X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAgwEBlZdtPrA+AABsw X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJTRUUUbGCS07vEb7Iv0x C_JF4lV2xY67kC6x804xWlV2xY67CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DMIAI bVAFxVCF77xC64kEw24lV2xY67C26IkvcIIF6IxKo4kEV4ylV2xY628lY4IE4IxF12IF4w CS07vE84x0c7CEj48ve4kI8wCS07vE84ACjcxK6xIIjxv20xvE14v26w1j6s0DMIAIbVA2 z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWxJr0_GcWlV2xY628EF7xvwVC2z280aVAFwI0_Gc CE3s1lV2xY628EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wCS07vEe2I262IYc4CY6c8I j28IcVAaY2xG8wCS07vE5I8CrVACY4xI64kE6c02F40Ex7xfMIAIbVAv7VC0I7IYx2IY67 AKxVWUJVWUGwCS07vEYx0Ex4A2jsIE14v26r1j6r4UMIAIbVAm72CE4IkC6x0Yz7v_Jr0_ Gr1lV2xY6x02cVAKzwCS07vEc2xSY4AK67AK6r43MIAIbVCY0x0Ix7I2Y4AK64vIr41lV2 xY6xAIw28IcVCjz48v1sIEY20_GFWkJr1UJwCS07vE4x8a6x804xWlV2xY6xC20s026xCa FVCjc4AY6r1j6r4UMIAIbVC20s026c02F40E14v26r1j6r18MIAIbVC20s026x8GjcxK67 AKxVWUGVWUWwCS07vEx4CE17CEb7AF67AKxVWUtVW8ZwCS07vEIxAIcVC0I7IYx2IY67AK xVWUJVWUCwCS07vEIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIAIbVCI42IY6xAIw2 0EY4v20xvaj40_WFyUJVCq3wCS07vEIxAIcVC2z280aVAFwI0_Jr0_Gr1lV2xY6IIF0xvE x4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUU== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200826_045541_026395_D179C376 X-CRM114-Status: UNSURE ( 7.25 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , Kangjie Lu , linux-kernel , Maxime Ripard , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Sun, Aug 23, 2020 at 3:59 PM Dinghao Liu wrote: > > > > When clk_hw_register_fixed_rate_with_accuracy() fails, > > clk_data should be freed. It's the same for the subsequent > > error paths. > > I suppose you should also unregister the already registered clocks > in the latter two error paths? > Sounds reasonable. But I find that the existing kernel code takes different strategies for this case. of_sama5d4_sckc_setup() uses clk_hw_unregister() after clk_hw_register_fixed_rate_with_accuracy(), while _of_fixed_clk_setup() uses clk_hw_unregister_fixed_rate(). But at91sam926x_pmc_setup() just does nothing in this case. Also, tcon_ch1_setup() uses clk_unregister() after clk_register(), while clk_register_vco_pll() just does nothing. So I'm not sure if we should register here and which unregister function to use. Would you please give me more specific advice about this problem? Regards, Dinghao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel