From: liweihang <liweihang@huawei.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"leon@kernel.org" <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH v2 for-next 7/7] RDMA/core: Remove redundant BUG_ON
Date: Tue, 13 Apr 2021 03:46:03 +0000 [thread overview]
Message-ID: <6df048fba865495aa55ece110e3ab2a9@huawei.com> (raw)
In-Reply-To: 20210412175132.GA1140114@nvidia.com
On 2021/4/13 1:51, Jason Gunthorpe wrote:
> On Wed, Apr 07, 2021 at 04:15:53PM +0800, Weihang Li wrote:
>> It's ok if the refcount of cm_id is zero when release the reference of it,
>> there is no need to call BUG_ON.
>
> Huh? No it isn't.
>
> If you want to remove this BUG_ON then convert this to a refcount_t
> and rely on refcount debugging instead.
>
> Jason
>
I see. I will try using refcount_t instead.
Thank you
Weihang
next prev parent reply other threads:[~2021-04-13 3:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 8:15 [PATCH v2 for-next 0/7] RDMA/core: Correct some coding-style issues Weihang Li
2021-04-07 8:15 ` [PATCH v2 for-next 1/7] RDMA/core: Print the function name by __func__ instead of an fixed string Weihang Li
2021-04-07 8:15 ` [PATCH v2 for-next 2/7] RDMA/core: Remove the redundant return statements Weihang Li
2021-04-07 8:15 ` [PATCH v2 for-next 3/7] RDMA/core: Add necessary spaces Weihang Li
2021-04-07 8:15 ` [PATCH v2 for-next 4/7] RDMA/core: Remove redundant spaces Weihang Li
2021-04-07 8:15 ` [PATCH v2 for-next 5/7] RDMA/core: Correct format of braces Weihang Li
2021-04-07 8:15 ` [PATCH v2 for-next 6/7] RDMA/core: Correct format of block comments Weihang Li
2021-04-07 8:15 ` [PATCH v2 for-next 7/7] RDMA/core: Remove redundant BUG_ON Weihang Li
2021-04-12 17:51 ` Jason Gunthorpe
2021-04-13 3:46 ` liweihang [this message]
2021-04-07 12:26 ` [PATCH v2 for-next 0/7] RDMA/core: Correct some coding-style issues Leon Romanovsky
2021-04-12 17:59 ` Jason Gunthorpe
2021-04-13 2:37 ` liweihang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6df048fba865495aa55ece110e3ab2a9@huawei.com \
--to=liweihang@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.