From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAEAA81AB1; Thu, 28 Mar 2024 15:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711638541; cv=none; b=FUin7t3z822Ow0QrNIlnxzw+JRrKeZXSnsCQY6dPy7DQfsHBgofs4QCAKkzCfw+b8OJjs7R0g5x7SbXrI4M/rwq/6EF4y+8qePFFOnyzsLQR1UHlFpEwLNvvUY7jzdCcu73IMMzNFP1KyGORY+KGUT16E7I9nXm4w98R8Iy2G3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711638541; c=relaxed/simple; bh=4RMpfFVGWhEWafnefWiakyA1PM0ClZPXcn1uGjIvT/k=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=MLBBokwIL1FQmsP40qxK5ehJI+JErHI6gW0qj5RpschzRVL9KrylHGpw2Eo42lv/Hwr+3jN2O3Od+GFHpj/5FOD6uDiZyYAEHBP5Er/IrgXf83paPB6Fx6ZBKVD60AzkFc2ZYROjyj/Qao1IjwwM5PsHgPrC/RjzhAzOuPP7+zE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=zpu+15rj; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="zpu+15rj" Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42SENT78017636; Thu, 28 Mar 2024 16:08:23 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=iLOweYbCsmn698CJ46dWyC3tf2LxrlF3WpWQb+3oxRE=; b=zp u+15rjkBN0yym8/YKQUXKM7KkDrPXNb9xjRmvtVUWcwUoAA7fwTn2+GqQbrvk1fD 07bu7tF8IK1QJaSKPiZDfuu6HSMjHkn9NObrsultisKGcOfQHHseo1zme7sMk3BY 8wiGfR4FwPkyXwXQeSRWiDPDWABG7RXz85nwtKpB4IurCvxQNxyA5dvJIRbxhqWM LiMrXzMQAO0SnLYOJwIlt4zg0lvvFdZ8rjPlEQSv6RHauyNw34Uz/jU59xwIN4W9 vDg32W4tGw5vo06quCrMLd3mr4pOquc8b5ELSfyQmv8EvWnt6FnnPnGXV0tMLuPK 7cx7o3DgklHKP0reBu0g== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3x1n39tw26-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Mar 2024 16:08:23 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 7EC9B40044; Thu, 28 Mar 2024 16:08:19 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id BFE3F2248BB; Thu, 28 Mar 2024 16:07:03 +0100 (CET) Received: from [10.201.21.128] (10.201.21.128) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 28 Mar 2024 16:07:02 +0100 Message-ID: <6df41c81-0aa4-48a5-a069-d8a742f412ef@foss.st.com> Date: Thu, 28 Mar 2024 16:07:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/1] dt-bindings: net: dwmac: Document STM32 property st,ext-phyclk Content-Language: en-US To: Marek Vasut , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown CC: , , , , References: <20240328140803.324141-1-christophe.roullier@foss.st.com> <20240328140803.324141-2-christophe.roullier@foss.st.com> <480d4064-b553-4005-ad98-499a862703ff@denx.de> From: Christophe ROULLIER In-Reply-To: <480d4064-b553-4005-ad98-499a862703ff@denx.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-28_15,2024-03-27_01,2023-05-22_02 On 3/28/24 15:19, Marek Vasut wrote: > On 3/28/24 3:08 PM, Christophe Roullier wrote: > > [...] > >> | RMII    |    -   |     eth-ck    | eth-ck        |       n/a        | >> |         |        | st,ext-phyclk | st,eth-ref-clk-sel >> |                  | >> |         |        |               | or st,ext-phyclk >> |                  | >> >> --------------------------------------------------------------------------- >> >> >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Christophe Roullier >> --- >>   Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 7 +++++++ >>   1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> index fc8c96b08d7dc..b35eae80ed6ac 100644 >> --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> @@ -82,6 +82,13 @@ properties: >>         Should be phandle/offset pair. The phandle to the syscon node >> which >>         encompases the glue register, and the offset of the control >> register >>   +st,ext-phyclk: > > Don't you need two spaces in front of the 'st,' here ? Sorry, that's right. > >> +    description: >> +      set this property in RMII mode when you have PHY without >> crystal 50MHz and want to >> +      select RCC clock instead of ETH_REF_CLK. OR in RGMII mode when >> you want to select >> +      RCC clock instead of ETH_CLK125. >> +    type: boolean >> + > > With that fixed: > > Reviewed-by: Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74D23CD1284 for ; Thu, 28 Mar 2024 15:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EQE+Bm74hJO/7Wq9lAkKfjxMk7lfP40tbUffQh3nAdE=; b=A9D4cFqZzApacW uq0t3jEuAR90SHGthPkmAp4wgSnnpxpPuDxCDmNbkSzHhJ+IfYxf1IP9gTgTuMiacrsge7mElzZuh IjVnVlp3K5bZac4iO6pDRaDFpukPFSsuGTOtQfWQtuMSWmpNC7XT7chvOAk1M+pOAQc//etF9Z6// lrLmNvtNW1/WTFzn8uAmTV94C34iE3vS2jWKag/sweZYiARO0VZ+ZC1V8HXYn7LrlY1Oc1FuOSSuw l1GnPsRC0gv/LOuJI2aND0b1OImzUqY1E74jzjxoK96GHX24siKfAYFTQl7Fryc7MOBI0kXxA03o6 wxG9QxEJ7X0p+/9Rgq1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rprN7-0000000ESjJ-3SEj; Thu, 28 Mar 2024 15:08:53 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rprN4-0000000ESgA-0xO9 for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 15:08:52 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42SENT78017636; Thu, 28 Mar 2024 16:08:23 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=iLOweYbCsmn698CJ46dWyC3tf2LxrlF3WpWQb+3oxRE=; b=zp u+15rjkBN0yym8/YKQUXKM7KkDrPXNb9xjRmvtVUWcwUoAA7fwTn2+GqQbrvk1fD 07bu7tF8IK1QJaSKPiZDfuu6HSMjHkn9NObrsultisKGcOfQHHseo1zme7sMk3BY 8wiGfR4FwPkyXwXQeSRWiDPDWABG7RXz85nwtKpB4IurCvxQNxyA5dvJIRbxhqWM LiMrXzMQAO0SnLYOJwIlt4zg0lvvFdZ8rjPlEQSv6RHauyNw34Uz/jU59xwIN4W9 vDg32W4tGw5vo06quCrMLd3mr4pOquc8b5ELSfyQmv8EvWnt6FnnPnGXV0tMLuPK 7cx7o3DgklHKP0reBu0g== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3x1n39tw26-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Mar 2024 16:08:23 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 7EC9B40044; Thu, 28 Mar 2024 16:08:19 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id BFE3F2248BB; Thu, 28 Mar 2024 16:07:03 +0100 (CET) Received: from [10.201.21.128] (10.201.21.128) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 28 Mar 2024 16:07:02 +0100 Message-ID: <6df41c81-0aa4-48a5-a069-d8a742f412ef@foss.st.com> Date: Thu, 28 Mar 2024 16:07:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/1] dt-bindings: net: dwmac: Document STM32 property st,ext-phyclk Content-Language: en-US To: Marek Vasut , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown CC: , , , , References: <20240328140803.324141-1-christophe.roullier@foss.st.com> <20240328140803.324141-2-christophe.roullier@foss.st.com> <480d4064-b553-4005-ad98-499a862703ff@denx.de> From: Christophe ROULLIER In-Reply-To: <480d4064-b553-4005-ad98-499a862703ff@denx.de> X-Originating-IP: [10.201.21.128] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-28_15,2024-03-27_01,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_080850_573505_66735208 X-CRM114-Status: GOOD ( 14.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDMvMjgvMjQgMTU6MTksIE1hcmVrIFZhc3V0IHdyb3RlOgo+IE9uIDMvMjgvMjQgMzowOCBQ TSwgQ2hyaXN0b3BoZSBSb3VsbGllciB3cm90ZToKPgo+IFsuLi5dCj4KPj4gfCBSTUlJwqDCoMKg IHzCoMKgwqAgLcKgwqAgfMKgwqDCoMKgIGV0aC1ja8KgwqDCoCB8IGV0aC1ja8KgwqDCoMKgwqDC oMKgIHzCoMKgwqDCoMKgwqAgbi9hwqDCoMKgwqDCoMKgwqAgfAo+PiB8wqDCoMKgwqDCoMKgwqDC oCB8wqDCoMKgwqDCoMKgwqAgfCBzdCxleHQtcGh5Y2xrIHwgc3QsZXRoLXJlZi1jbGstc2VsIAo+ PiB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8Cj4+IHzCoMKgwqDCoMKgwqDC oMKgIHzCoMKgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IG9yIHN0 LGV4dC1waHljbGsgCj4+IHzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHwKPj4K Pj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tIAo+Pgo+Pgo+PiBSZXZpZXdlZC1ieTogS3J6eXN6dG9mIEtv emxvd3NraSA8a3J6eXN6dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPgo+PiBTaWduZWQtb2ZmLWJ5 OiBDaHJpc3RvcGhlIFJvdWxsaWVyIDxjaHJpc3RvcGhlLnJvdWxsaWVyQGZvc3Muc3QuY29tPgo+ PiAtLS0KPj4gwqAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9zdG0zMi1k d21hYy55YW1sIHwgNyArKysrKysrCj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMo KykKPj4KPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9u ZXQvc3RtMzItZHdtYWMueWFtbCAKPj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvbmV0L3N0bTMyLWR3bWFjLnlhbWwKPj4gaW5kZXggZmM4Yzk2YjA4ZDdkYy4uYjM1ZWFlODBl ZDZhYyAxMDA2NDQKPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25l dC9zdG0zMi1kd21hYy55YW1sCj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9uZXQvc3RtMzItZHdtYWMueWFtbAo+PiBAQCAtODIsNiArODIsMTMgQEAgcHJvcGVydGll czoKPj4gwqDCoMKgwqDCoMKgwqAgU2hvdWxkIGJlIHBoYW5kbGUvb2Zmc2V0IHBhaXIuIFRoZSBw aGFuZGxlIHRvIHRoZSBzeXNjb24gbm9kZSAKPj4gd2hpY2gKPj4gwqDCoMKgwqDCoMKgwqAgZW5j b21wYXNlcyB0aGUgZ2x1ZSByZWdpc3RlciwgYW5kIHRoZSBvZmZzZXQgb2YgdGhlIGNvbnRyb2wg Cj4+IHJlZ2lzdGVyCj4+IMKgICtzdCxleHQtcGh5Y2xrOgo+Cj4gRG9uJ3QgeW91IG5lZWQgdHdv IHNwYWNlcyBpbiBmcm9udCBvZiB0aGUgJ3N0LCcgaGVyZSA/ClNvcnJ5LCB0aGF0J3MgcmlnaHQu Cj4KPj4gK8KgwqDCoCBkZXNjcmlwdGlvbjoKPj4gK8KgwqDCoMKgwqAgc2V0IHRoaXMgcHJvcGVy dHkgaW4gUk1JSSBtb2RlIHdoZW4geW91IGhhdmUgUEhZIHdpdGhvdXQgCj4+IGNyeXN0YWwgNTBN SHogYW5kIHdhbnQgdG8KPj4gK8KgwqDCoMKgwqAgc2VsZWN0IFJDQyBjbG9jayBpbnN0ZWFkIG9m IEVUSF9SRUZfQ0xLLiBPUiBpbiBSR01JSSBtb2RlIHdoZW4gCj4+IHlvdSB3YW50IHRvIHNlbGVj dAo+PiArwqDCoMKgwqDCoCBSQ0MgY2xvY2sgaW5zdGVhZCBvZiBFVEhfQ0xLMTI1Lgo+PiArwqDC oMKgIHR5cGU6IGJvb2xlYW4KPj4gKwo+Cj4gV2l0aCB0aGF0IGZpeGVkOgo+Cj4gUmV2aWV3ZWQt Ynk6IE1hcmVrIFZhc3V0IDxtYXJleEBkZW54LmRlPgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=