From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D3E8C001B0 for ; Thu, 22 Jun 2023 19:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230387AbjFVTtE (ORCPT ); Thu, 22 Jun 2023 15:49:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbjFVTtC (ORCPT ); Thu, 22 Jun 2023 15:49:02 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2324F1FE8; Thu, 22 Jun 2023 12:49:01 -0700 (PDT) Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35MJFd5R000374; Thu, 22 Jun 2023 19:48:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=tmENBKFGIrm+W5xEE+TLaiJBxZpQvSPgrr9e7uSqw6o=; b=aaMWb/ztQ97ox+3GJcQ5L1iF4TeUEePjpAuwT+oWW6eVqhVuyWeJ1rCE8loGnU0Oy94n B4ZGsWuUvCNo3tZuRJfuCdSYoL/W2+2a+peBnSbzkt/sh6f12JmqdHeGKa+S7R+HZzo+ x22acOUCjFkCUS2907Z27Et7sXE+u8rQowh7oNifJdL1HwA2bxf6K06gHmC6hS2y261W Jcq5MWHXt4iE3OwHhbV8XJkVQZTFeR3feTKBVg7P0BMN78mTfoR063lMtREUzRzFGDQh OUq15CsGZDCYoD/f7RkJUzrJVUIzPPSMZlBCRK5Sq9qM73kvjpkFP1On+l+37OBZHFhw GA== Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rcva1gmqu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 19:48:39 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35MJbDXX010301; Thu, 22 Jun 2023 19:48:38 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([9.208.129.118]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3r94f726ac-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 19:48:38 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35MJmaoV65339684 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jun 2023 19:48:37 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9D77858051; Thu, 22 Jun 2023 19:48:36 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5994C5805C; Thu, 22 Jun 2023 19:48:36 +0000 (GMT) Received: from [9.61.34.182] (unknown [9.61.34.182]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 22 Jun 2023 19:48:36 +0000 (GMT) Message-ID: <6dff003d-c727-e4a3-b5d3-f58beb2b02cb@linux.ibm.com> Date: Thu, 22 Jun 2023 14:48:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 3/4] spi: Split transfers larger than max size To: Vincent Whitchurch , broonie@kernel.org, krzysztof.kozlowski@linaro.org, andi@etezian.org Cc: kernel@axis.com, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220927112117.77599-1-vincent.whitchurch@axis.com> <20220927112117.77599-4-vincent.whitchurch@axis.com> Content-Language: en-US From: Eddie James In-Reply-To: <20220927112117.77599-4-vincent.whitchurch@axis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UGpeUflZAMyn6SP0xeEJT2IivBDUQeK2 X-Proofpoint-ORIG-GUID: UGpeUflZAMyn6SP0xeEJT2IivBDUQeK2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-22_14,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1011 phishscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306220167 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/27/22 06:21, Vincent Whitchurch wrote: > A couple of drivers call spi_split_transfers_maxsize() from their > ->prepare_message() callbacks to split transfers which are too big for > them to handle. Add support in the core to do this based on > ->max_transfer_size() to avoid code duplication. Hello, I've been testing AT25 functionality in linux 6.1 and I believe this patch is breaking the AT25 protocol. It will split a write command up such that some of the data is in a different transfer than  the write enable and address. According to my understanding of the AT25 spec, that doesn't work... Someone correct me if I'm wrong though. Do we need a flag to enable/disable this behavior depending on the client perhaps? Thanks, Eddie > > Signed-off-by: Vincent Whitchurch > --- > drivers/spi/spi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index f41a8c2752b8..44e4352d948b 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -1649,6 +1649,15 @@ static int __spi_pump_transfer_message(struct spi_controller *ctlr, > > trace_spi_message_start(msg); > > + ret = spi_split_transfers_maxsize(ctlr, msg, > + spi_max_transfer_size(msg->spi), > + GFP_KERNEL | GFP_DMA); > + if (ret) { > + msg->status = ret; > + spi_finalize_current_message(ctlr); > + return ret; > + } > + > if (ctlr->prepare_message) { > ret = ctlr->prepare_message(ctlr, msg); > if (ret) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA7AEEB64DA for ; Thu, 22 Jun 2023 19:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kQZN0662Fz6SZl+5pDqjbCqYpq5kC8i9ydVjR58lf2s=; b=Lr6fUNJjT800eE NbsMSRehJNxMZ2atCgDs9VUNZ8FfVdB8zaVqm09scXe2bjc5A/yqqFCDRUoxLZynydwNmCRTur6gR uuLK7EixJhtcphPPTFnq9Sqw16tbjmIh6KjfIXIRN/uawsTnviGTC4Az5xmOmWmtTLjzxt51WV6v9 yLYaMCh5skguy5zIClwJ4QAPwM0k2z2hhvVUUwCfvdGr1GGkeCFX3IqJsE9sm8Oe9VxjLckP6a+dO lXVZotqg3oIN6ENMFAIxskKP/VcgX5KFSYsbLbDwpnxApB5lcSKTdoB8XkyAUsUvtXe30gbdSHj90 nvWGSwPe9wwrFA3lxhCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCQIc-001ai6-1g; Thu, 22 Jun 2023 19:48:58 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCQIZ-001ah3-1Y for linux-arm-kernel@lists.infradead.org; Thu, 22 Jun 2023 19:48:57 +0000 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35MJFd5R000374; Thu, 22 Jun 2023 19:48:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=tmENBKFGIrm+W5xEE+TLaiJBxZpQvSPgrr9e7uSqw6o=; b=aaMWb/ztQ97ox+3GJcQ5L1iF4TeUEePjpAuwT+oWW6eVqhVuyWeJ1rCE8loGnU0Oy94n B4ZGsWuUvCNo3tZuRJfuCdSYoL/W2+2a+peBnSbzkt/sh6f12JmqdHeGKa+S7R+HZzo+ x22acOUCjFkCUS2907Z27Et7sXE+u8rQowh7oNifJdL1HwA2bxf6K06gHmC6hS2y261W Jcq5MWHXt4iE3OwHhbV8XJkVQZTFeR3feTKBVg7P0BMN78mTfoR063lMtREUzRzFGDQh OUq15CsGZDCYoD/f7RkJUzrJVUIzPPSMZlBCRK5Sq9qM73kvjpkFP1On+l+37OBZHFhw GA== Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rcva1gmqu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 19:48:39 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35MJbDXX010301; Thu, 22 Jun 2023 19:48:38 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([9.208.129.118]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3r94f726ac-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 19:48:38 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35MJmaoV65339684 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jun 2023 19:48:37 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9D77858051; Thu, 22 Jun 2023 19:48:36 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5994C5805C; Thu, 22 Jun 2023 19:48:36 +0000 (GMT) Received: from [9.61.34.182] (unknown [9.61.34.182]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 22 Jun 2023 19:48:36 +0000 (GMT) Message-ID: <6dff003d-c727-e4a3-b5d3-f58beb2b02cb@linux.ibm.com> Date: Thu, 22 Jun 2023 14:48:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 3/4] spi: Split transfers larger than max size To: Vincent Whitchurch , broonie@kernel.org, krzysztof.kozlowski@linaro.org, andi@etezian.org Cc: kernel@axis.com, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220927112117.77599-1-vincent.whitchurch@axis.com> <20220927112117.77599-4-vincent.whitchurch@axis.com> Content-Language: en-US From: Eddie James In-Reply-To: <20220927112117.77599-4-vincent.whitchurch@axis.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UGpeUflZAMyn6SP0xeEJT2IivBDUQeK2 X-Proofpoint-ORIG-GUID: UGpeUflZAMyn6SP0xeEJT2IivBDUQeK2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-22_14,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1011 phishscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306220167 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230622_124855_866335_E1DFDF3D X-CRM114-Status: GOOD ( 26.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDkvMjcvMjIgMDY6MjEsIFZpbmNlbnQgV2hpdGNodXJjaCB3cm90ZToKPiBBIGNvdXBsZSBv ZiBkcml2ZXJzIGNhbGwgc3BpX3NwbGl0X3RyYW5zZmVyc19tYXhzaXplKCkgZnJvbSB0aGVpcgo+ IC0+cHJlcGFyZV9tZXNzYWdlKCkgY2FsbGJhY2tzIHRvIHNwbGl0IHRyYW5zZmVycyB3aGljaCBh cmUgdG9vIGJpZyBmb3IKPiB0aGVtIHRvIGhhbmRsZS4gIEFkZCBzdXBwb3J0IGluIHRoZSBjb3Jl IHRvIGRvIHRoaXMgYmFzZWQgb24KPiAtPm1heF90cmFuc2Zlcl9zaXplKCkgdG8gYXZvaWQgY29k ZSBkdXBsaWNhdGlvbi4KCgpIZWxsbywKCkkndmUgYmVlbiB0ZXN0aW5nIEFUMjUgZnVuY3Rpb25h bGl0eSBpbiBsaW51eCA2LjEgYW5kIEkgYmVsaWV2ZSB0aGlzIApwYXRjaCBpcyBicmVha2luZyB0 aGUgQVQyNSBwcm90b2NvbC4gSXQgd2lsbCBzcGxpdCBhIHdyaXRlIGNvbW1hbmQgdXAgCnN1Y2gg dGhhdCBzb21lIG9mIHRoZSBkYXRhIGlzIGluIGEgZGlmZmVyZW50IHRyYW5zZmVyIHRoYW7CoCB0 aGUgd3JpdGUgCmVuYWJsZSBhbmQgYWRkcmVzcy4gQWNjb3JkaW5nIHRvIG15IHVuZGVyc3RhbmRp bmcgb2YgdGhlIEFUMjUgc3BlYywgdGhhdCAKZG9lc24ndCB3b3JrLi4uIFNvbWVvbmUgY29ycmVj dCBtZSBpZiBJJ20gd3JvbmcgdGhvdWdoLiBEbyB3ZSBuZWVkIGEgCmZsYWcgdG8gZW5hYmxlL2Rp c2FibGUgdGhpcyBiZWhhdmlvciBkZXBlbmRpbmcgb24gdGhlIGNsaWVudCBwZXJoYXBzPwoKClRo YW5rcywKCkVkZGllCgoKPgo+IFNpZ25lZC1vZmYtYnk6IFZpbmNlbnQgV2hpdGNodXJjaCA8dmlu Y2VudC53aGl0Y2h1cmNoQGF4aXMuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9zcGkvc3BpLmMgfCA5 ICsrKysrKysrKwo+ICAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvc3BpL3NwaS5jIGIvZHJpdmVycy9zcGkvc3BpLmMKPiBpbmRleCBmNDFh OGMyNzUyYjguLjQ0ZTQzNTJkOTQ4YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3NwaS9zcGkuYwo+ ICsrKyBiL2RyaXZlcnMvc3BpL3NwaS5jCj4gQEAgLTE2NDksNiArMTY0OSwxNSBAQCBzdGF0aWMg aW50IF9fc3BpX3B1bXBfdHJhbnNmZXJfbWVzc2FnZShzdHJ1Y3Qgc3BpX2NvbnRyb2xsZXIgKmN0 bHIsCj4gICAKPiAgIAl0cmFjZV9zcGlfbWVzc2FnZV9zdGFydChtc2cpOwo+ICAgCj4gKwlyZXQg PSBzcGlfc3BsaXRfdHJhbnNmZXJzX21heHNpemUoY3RsciwgbXNnLAo+ICsJCQkJCSAgc3BpX21h eF90cmFuc2Zlcl9zaXplKG1zZy0+c3BpKSwKPiArCQkJCQkgIEdGUF9LRVJORUwgfCBHRlBfRE1B KTsKPiArCWlmIChyZXQpIHsKPiArCQltc2ctPnN0YXR1cyA9IHJldDsKPiArCQlzcGlfZmluYWxp emVfY3VycmVudF9tZXNzYWdlKGN0bHIpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICAg CWlmIChjdGxyLT5wcmVwYXJlX21lc3NhZ2UpIHsKPiAgIAkJcmV0ID0gY3Rsci0+cHJlcGFyZV9t ZXNzYWdlKGN0bHIsIG1zZyk7Cj4gICAJCWlmIChyZXQpIHsKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK