From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpW95-0007SZ-AO for qemu-devel@nongnu.org; Thu, 29 Sep 2016 03:52:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpW92-0002Na-M4 for qemu-devel@nongnu.org; Thu, 29 Sep 2016 03:52:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpW92-0002NT-Fw for qemu-devel@nongnu.org; Thu, 29 Sep 2016 03:52:40 -0400 References: <1475108205-6043-1-git-send-email-david@gibson.dropbear.id.au> From: Paolo Bonzini Message-ID: <6e031cba-1d59-ccf5-1b28-e37b610c6ae7@redhat.com> Date: Thu, 29 Sep 2016 09:52:35 +0200 MIME-Version: 1.0 In-Reply-To: <1475108205-6043-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/4] QOM class properties - do we need them? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , afaerber@suse.de, peter.maydell@linaro.org Cc: armbru@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org On 29/09/2016 02:16, David Gibson wrote: > Alternatively, if we *don't* want to remove class properties, should > we instead be trying to convert the many, many "instance" properties > whose existence is actually per-class to be class properties? Yes, this was the point of introducing them. :) Paolo > David Gibson (4): > qcrypto: Remove usage of class properties > s390: Don't use class properties > tests: Remove tests for class properties > qom: Abolish class properties > > crypto/secret.c | 58 +++++++------- > crypto/tlscreds.c | 44 +++++----- > crypto/tlscredsanon.c | 16 ++-- > crypto/tlscredsx509.c | 26 +++--- > include/qom/object.h | 42 ---------- > qom/object.c | 195 --------------------------------------------- > target-s390x/cpu.c | 1 - > target-s390x/cpu_models.c | 47 +++++------ > tests/check-qom-proplist.c | 30 +++---- > 9 files changed, 106 insertions(+), 353 deletions(-) >