From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hal Rosenstock Subject: Re: [rdma-core/srp_daemon PATCH] Correct method field for PathRecord request Date: Wed, 12 Apr 2017 10:34:47 -0400 Message-ID: <6e04d44e-fab3-1477-7de4-d3c679301f38@dev.mellanox.co.il> References: <1491924533-2548-1-git-send-email-honli@redhat.com> <20170411154944.GA19917@obsidianresearch.com> <20170412132923.GB16375@dhcp-13-42.nay.redhat.com> <20170412141800.GA20223@dhcp-13-42.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170412141800.GA20223-Y5OA6DF/u0nid9cnFhDO8BcY2uh10dtjAL8bYrjMMd8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Honggang LI Cc: Jason Gunthorpe , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 4/12/2017 10:18 AM, Honggang LI wrote: > On Wed, Apr 12, 2017 at 09:34:20AM -0400, Hal Rosenstock wrote: >> On 4/12/2017 9:29 AM, Honggang LI wrote: >>> On Tue, Apr 11, 2017 at 09:49:44AM -0600, Jason Gunthorpe wrote: >>>> On Tue, Apr 11, 2017 at 11:28:53PM +0800, Honggang LI wrote: >>>>> From: Honggang Li >>>>> >>>>> According to InfiniBand Architecture Release 1.2.1, Table 208 >>>>> Example PathRecord Request MAD Header Fields, MADHeader:Method >>>>> should setup to 0x12 (SubnAdmGetTable()). >>>> >>>> That is just an example, Table 192 shows that Get and GetTable are >>>> both valid query types. >>> >>> I don't understand this as "Table 192 PortInfoRecord" seems nothing to >>> do with PathRecord request. >> >> In IBA 1.3 volume 1, it's Table 209 Subnet Administration >> Attribute/Method Map shows PathRecord methods are Get and GetTable. >> > > http://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/truescale-infiniband-12300-switch-brief.pdf > Interoperability > • Compliant with IBTA* specifications 1.0a, 1.1, 1.2, and 1.2. > > It seems the embedded subnet manager does not support IBA 1.3 It's same for IBA 1.2.1. This part hasn't changed. >>>> >>>> I however expect that the SM will fail when using GetTable if the >>>> query returns more than one result, could that be what is happening? >>>> When you convert it to GET_TABLE does it return more than one result? >>> >>> strace output shows srptools always received MAD packet in 320 bytes. So >>> the embedded subnet manager only returns one result. >> >> What is MAD status ? > > ib_user_mad->status = 0x0 > > I attached the MAD packet dump out with strace. Please see the > attachments p4.in amd p4.decode. p4.decode has: rp_dm_rmpp_sa_mad->method = 0x81 //IB_MAD_METHOD_GET_RESP opensm/include/iba/ib_types.h // GetResp() Method (13.4.5) Proper response to GetTable (0x12) method is GetTableResponse (0x92) method but this is GetResp (0x81) response. -- Hal >> >> -- Hal >> >>>> >>>> Jason >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html