From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754960AbdDDPqj convert rfc822-to-8bit (ORCPT ); Tue, 4 Apr 2017 11:46:39 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:53965 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754579AbdDDPpt (ORCPT ); Tue, 4 Apr 2017 11:45:49 -0400 From: Hugues FRUCHET To: Rob Herring CC: Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Mauro Carvalho Chehab , Hans Verkuil , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , Benjamin Gaignard , Yannick FERTRE Subject: Re: [PATCH v2 1/8] dt-bindings: Document STM32 DCMI bindings Thread-Topic: [PATCH v2 1/8] dt-bindings: Document STM32 DCMI bindings Thread-Index: AQHSrJabDvwxH1gGLEmgVUmfqqZpp6G1OjQA Date: Tue, 4 Apr 2017 15:45:17 +0000 Message-ID: <6e0b4d39-50de-3f0e-3702-3bbd462473c3@st.com> References: <1490887667-8880-1-git-send-email-hugues.fruchet@st.com> <1490887667-8880-2-git-send-email-hugues.fruchet@st.com> <20170403162309.eikbsmfbxw6admdc@rob-hp-laptop> In-Reply-To: <20170403162309.eikbsmfbxw6admdc@rob-hp-laptop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.46] Content-Type: text/plain; charset="Windows-1252" Content-ID: <10FBBF3E65F02F40AE0C0977BDBCDA9E@st.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-04_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Rob for review, find answers below. On 04/03/2017 06:23 PM, Rob Herring wrote: > On Thu, Mar 30, 2017 at 05:27:40PM +0200, Hugues Fruchet wrote: >> This adds documentation of device tree bindings for the STM32 DCMI >> (Digital Camera Memory Interface). >> >> Signed-off-by: Hugues Fruchet >> --- >> .../devicetree/bindings/media/st,stm32-dcmi.txt | 85 ++++++++++++++++++++++ >> 1 file changed, 85 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> >> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> new file mode 100644 >> index 0000000..8180f63 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> @@ -0,0 +1,85 @@ >> +STMicroelectronics STM32 Digital Camera Memory Interface (DCMI) >> + >> +Required properties: >> +- compatible: "st,stm32-dcmi" > > Same block and same errata on all stm32 variants? Yes, it is the same IP block on all stm32 variants. > >> +- reg: physical base address and length of the registers set for the device >> +- interrupts: should contain IRQ line for the DCMI >> +- clocks: list of clock specifiers, corresponding to entries in >> + the clock-names property >> +- clock-names: must contain "mclk", which is the DCMI peripherial clock >> +- resets: reference to a reset controller >> +- reset-names: see Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> + >> +DCMI supports a single port node with parallel bus. It should contain one >> +'port' child node with child 'endpoint' node. Please refer to the bindings >> +defined in Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +Example: >> + >> +Device node example >> +------------------- >> + dcmi: dcmi@50050000 { >> + compatible = "st,stm32-dcmi"; >> + reg = <0x50050000 0x400>; >> + interrupts = <78>; >> + resets = <&rcc STM32F4_AHB2_RESET(DCMI)>; >> + clocks = <&rcc 0 STM32F4_AHB2_CLOCK(DCMI)>; >> + clock-names = "mclk"; > >> + pinctrl-names = "default"; >> + pinctrl-0 = <&dcmi_pins>; > > Not documented. Fixed in v3. > >> + dmas = <&dma2 1 1 0x414 0x3>; >> + dma-names = "tx"; > > Not documented. Fixed in v3. > >> + status = "disabled"; > > Drop status from examples. Fixed in v3. > >> + }; >> + >> +Board setup example > > Please don't split examples. That's just source level details and not > part of the ABI. Fixed in v3. > >> +------------------- >> +This example is extracted from STM32F429-EVAL board devicetree. >> +Please note that on this board, the camera sensor reset & power-down >> +line level are inverted (so reset is active high and power-down is >> +active low). >> + >> +/ { >> + [...] >> + clocks { >> + clk_ext_camera: clk-ext-camera { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <24000000>; >> + }; >> + }; >> + [...] >> +}; >> + >> +&dcmi { >> + status = "okay"; >> + >> + port { >> + dcmi_0: endpoint@0 { >> + remote-endpoint = <&ov2640_0>; >> + bus-width = <8>; >> + hsync-active = <0>; >> + vsync-active = <0>; >> + pclk-sample = <1>; >> + }; >> + }; >> +}; >> + >> +&i2c@1 { >> + [...] >> + ov2640: camera@30 { >> + compatible = "ovti,ov2640"; >> + reg = <0x30>; >> + resetb-gpios = <&stmpegpio 2 GPIO_ACTIVE_HIGH>; >> + pwdn-gpios = <&stmpegpio 0 GPIO_ACTIVE_LOW>; >> + clocks = <&clk_ext_camera>; >> + clock-names = "xvclk"; >> + status = "okay"; >> + >> + port { >> + ov2640_0: endpoint { >> + remote-endpoint = <&dcmi_0>; >> + }; >> + }; >> + }; >> +}; >> -- >> 1.9.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hugues FRUCHET Subject: Re: [PATCH v2 1/8] dt-bindings: Document STM32 DCMI bindings Date: Tue, 4 Apr 2017 15:45:17 +0000 Message-ID: <6e0b4d39-50de-3f0e-3702-3bbd462473c3@st.com> References: <1490887667-8880-1-git-send-email-hugues.fruchet@st.com> <1490887667-8880-2-git-send-email-hugues.fruchet@st.com> <20170403162309.eikbsmfbxw6admdc@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170403162309.eikbsmfbxw6admdc@rob-hp-laptop> Content-Language: en-US Content-ID: <10FBBF3E65F02F40AE0C0977BDBCDA9E@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , "devicetree@vger.kernel.org" , Benjamin Gaignard , Alexandre TORGUE , "linux-kernel@vger.kernel.org" , Hans Verkuil , Maxime Coquelin , Mauro Carvalho Chehab , Yannick FERTRE , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" List-Id: devicetree@vger.kernel.org Thanks Rob for review, find answers below. On 04/03/2017 06:23 PM, Rob Herring wrote: > On Thu, Mar 30, 2017 at 05:27:40PM +0200, Hugues Fruchet wrote: >> This adds documentation of device tree bindings for the STM32 DCMI >> (Digital Camera Memory Interface). >> >> Signed-off-by: Hugues Fruchet >> --- >> .../devicetree/bindings/media/st,stm32-dcmi.txt | 85 ++++++++++++++++++++++ >> 1 file changed, 85 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> >> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> new file mode 100644 >> index 0000000..8180f63 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> @@ -0,0 +1,85 @@ >> +STMicroelectronics STM32 Digital Camera Memory Interface (DCMI) >> + >> +Required properties: >> +- compatible: "st,stm32-dcmi" > > Same block and same errata on all stm32 variants? Yes, it is the same IP block on all stm32 variants. > >> +- reg: physical base address and length of the registers set for the device >> +- interrupts: should contain IRQ line for the DCMI >> +- clocks: list of clock specifiers, corresponding to entries in >> + the clock-names property >> +- clock-names: must contain "mclk", which is the DCMI peripherial clock >> +- resets: reference to a reset controller >> +- reset-names: see Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> + >> +DCMI supports a single port node with parallel bus. It should contain one >> +'port' child node with child 'endpoint' node. Please refer to the bindings >> +defined in Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +Example: >> + >> +Device node example >> +------------------- >> + dcmi: dcmi@50050000 { >> + compatible = "st,stm32-dcmi"; >> + reg = <0x50050000 0x400>; >> + interrupts = <78>; >> + resets = <&rcc STM32F4_AHB2_RESET(DCMI)>; >> + clocks = <&rcc 0 STM32F4_AHB2_CLOCK(DCMI)>; >> + clock-names = "mclk"; > >> + pinctrl-names = "default"; >> + pinctrl-0 = <&dcmi_pins>; > > Not documented. Fixed in v3. > >> + dmas = <&dma2 1 1 0x414 0x3>; >> + dma-names = "tx"; > > Not documented. Fixed in v3. > >> + status = "disabled"; > > Drop status from examples. Fixed in v3. > >> + }; >> + >> +Board setup example > > Please don't split examples. That's just source level details and not > part of the ABI. Fixed in v3. > >> +------------------- >> +This example is extracted from STM32F429-EVAL board devicetree. >> +Please note that on this board, the camera sensor reset & power-down >> +line level are inverted (so reset is active high and power-down is >> +active low). >> + >> +/ { >> + [...] >> + clocks { >> + clk_ext_camera: clk-ext-camera { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <24000000>; >> + }; >> + }; >> + [...] >> +}; >> + >> +&dcmi { >> + status = "okay"; >> + >> + port { >> + dcmi_0: endpoint@0 { >> + remote-endpoint = <&ov2640_0>; >> + bus-width = <8>; >> + hsync-active = <0>; >> + vsync-active = <0>; >> + pclk-sample = <1>; >> + }; >> + }; >> +}; >> + >> +&i2c@1 { >> + [...] >> + ov2640: camera@30 { >> + compatible = "ovti,ov2640"; >> + reg = <0x30>; >> + resetb-gpios = <&stmpegpio 2 GPIO_ACTIVE_HIGH>; >> + pwdn-gpios = <&stmpegpio 0 GPIO_ACTIVE_LOW>; >> + clocks = <&clk_ext_camera>; >> + clock-names = "xvclk"; >> + status = "okay"; >> + >> + port { >> + ov2640_0: endpoint { >> + remote-endpoint = <&dcmi_0>; >> + }; >> + }; >> + }; >> +}; >> -- >> 1.9.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx08-00178001.pphosted.com ([91.207.212.93]:53965 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754579AbdDDPpt (ORCPT ); Tue, 4 Apr 2017 11:45:49 -0400 From: Hugues FRUCHET To: Rob Herring CC: Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Mauro Carvalho Chehab , Hans Verkuil , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , Benjamin Gaignard , Yannick FERTRE Subject: Re: [PATCH v2 1/8] dt-bindings: Document STM32 DCMI bindings Date: Tue, 4 Apr 2017 15:45:17 +0000 Message-ID: <6e0b4d39-50de-3f0e-3702-3bbd462473c3@st.com> References: <1490887667-8880-1-git-send-email-hugues.fruchet@st.com> <1490887667-8880-2-git-send-email-hugues.fruchet@st.com> <20170403162309.eikbsmfbxw6admdc@rob-hp-laptop> In-Reply-To: <20170403162309.eikbsmfbxw6admdc@rob-hp-laptop> Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-ID: <10FBBF3E65F02F40AE0C0977BDBCDA9E@st.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org List-ID: Thanks Rob for review, find answers below. On 04/03/2017 06:23 PM, Rob Herring wrote: > On Thu, Mar 30, 2017 at 05:27:40PM +0200, Hugues Fruchet wrote: >> This adds documentation of device tree bindings for the STM32 DCMI >> (Digital Camera Memory Interface). >> >> Signed-off-by: Hugues Fruchet >> --- >> .../devicetree/bindings/media/st,stm32-dcmi.txt | 85 ++++++++++++++++++++++ >> 1 file changed, 85 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> >> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> new file mode 100644 >> index 0000000..8180f63 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> @@ -0,0 +1,85 @@ >> +STMicroelectronics STM32 Digital Camera Memory Interface (DCMI) >> + >> +Required properties: >> +- compatible: "st,stm32-dcmi" > > Same block and same errata on all stm32 variants? Yes, it is the same IP block on all stm32 variants. > >> +- reg: physical base address and length of the registers set for the device >> +- interrupts: should contain IRQ line for the DCMI >> +- clocks: list of clock specifiers, corresponding to entries in >> + the clock-names property >> +- clock-names: must contain "mclk", which is the DCMI peripherial clock >> +- resets: reference to a reset controller >> +- reset-names: see Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> + >> +DCMI supports a single port node with parallel bus. It should contain one >> +'port' child node with child 'endpoint' node. Please refer to the bindings >> +defined in Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +Example: >> + >> +Device node example >> +------------------- >> + dcmi: dcmi@50050000 { >> + compatible = "st,stm32-dcmi"; >> + reg = <0x50050000 0x400>; >> + interrupts = <78>; >> + resets = <&rcc STM32F4_AHB2_RESET(DCMI)>; >> + clocks = <&rcc 0 STM32F4_AHB2_CLOCK(DCMI)>; >> + clock-names = "mclk"; > >> + pinctrl-names = "default"; >> + pinctrl-0 = <&dcmi_pins>; > > Not documented. Fixed in v3. > >> + dmas = <&dma2 1 1 0x414 0x3>; >> + dma-names = "tx"; > > Not documented. Fixed in v3. > >> + status = "disabled"; > > Drop status from examples. Fixed in v3. > >> + }; >> + >> +Board setup example > > Please don't split examples. That's just source level details and not > part of the ABI. Fixed in v3. > >> +------------------- >> +This example is extracted from STM32F429-EVAL board devicetree. >> +Please note that on this board, the camera sensor reset & power-down >> +line level are inverted (so reset is active high and power-down is >> +active low). >> + >> +/ { >> + [...] >> + clocks { >> + clk_ext_camera: clk-ext-camera { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <24000000>; >> + }; >> + }; >> + [...] >> +}; >> + >> +&dcmi { >> + status = "okay"; >> + >> + port { >> + dcmi_0: endpoint@0 { >> + remote-endpoint = <&ov2640_0>; >> + bus-width = <8>; >> + hsync-active = <0>; >> + vsync-active = <0>; >> + pclk-sample = <1>; >> + }; >> + }; >> +}; >> + >> +&i2c@1 { >> + [...] >> + ov2640: camera@30 { >> + compatible = "ovti,ov2640"; >> + reg = <0x30>; >> + resetb-gpios = <&stmpegpio 2 GPIO_ACTIVE_HIGH>; >> + pwdn-gpios = <&stmpegpio 0 GPIO_ACTIVE_LOW>; >> + clocks = <&clk_ext_camera>; >> + clock-names = "xvclk"; >> + status = "okay"; >> + >> + port { >> + ov2640_0: endpoint { >> + remote-endpoint = <&dcmi_0>; >> + }; >> + }; >> + }; >> +}; >> -- >> 1.9.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: hugues.fruchet@st.com (Hugues FRUCHET) Date: Tue, 4 Apr 2017 15:45:17 +0000 Subject: [PATCH v2 1/8] dt-bindings: Document STM32 DCMI bindings In-Reply-To: <20170403162309.eikbsmfbxw6admdc@rob-hp-laptop> References: <1490887667-8880-1-git-send-email-hugues.fruchet@st.com> <1490887667-8880-2-git-send-email-hugues.fruchet@st.com> <20170403162309.eikbsmfbxw6admdc@rob-hp-laptop> Message-ID: <6e0b4d39-50de-3f0e-3702-3bbd462473c3@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Thanks Rob for review, find answers below. On 04/03/2017 06:23 PM, Rob Herring wrote: > On Thu, Mar 30, 2017 at 05:27:40PM +0200, Hugues Fruchet wrote: >> This adds documentation of device tree bindings for the STM32 DCMI >> (Digital Camera Memory Interface). >> >> Signed-off-by: Hugues Fruchet >> --- >> .../devicetree/bindings/media/st,stm32-dcmi.txt | 85 ++++++++++++++++++++++ >> 1 file changed, 85 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> >> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> new file mode 100644 >> index 0000000..8180f63 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt >> @@ -0,0 +1,85 @@ >> +STMicroelectronics STM32 Digital Camera Memory Interface (DCMI) >> + >> +Required properties: >> +- compatible: "st,stm32-dcmi" > > Same block and same errata on all stm32 variants? Yes, it is the same IP block on all stm32 variants. > >> +- reg: physical base address and length of the registers set for the device >> +- interrupts: should contain IRQ line for the DCMI >> +- clocks: list of clock specifiers, corresponding to entries in >> + the clock-names property >> +- clock-names: must contain "mclk", which is the DCMI peripherial clock >> +- resets: reference to a reset controller >> +- reset-names: see Documentation/devicetree/bindings/reset/st,stm32-rcc.txt >> + >> +DCMI supports a single port node with parallel bus. It should contain one >> +'port' child node with child 'endpoint' node. Please refer to the bindings >> +defined in Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +Example: >> + >> +Device node example >> +------------------- >> + dcmi: dcmi at 50050000 { >> + compatible = "st,stm32-dcmi"; >> + reg = <0x50050000 0x400>; >> + interrupts = <78>; >> + resets = <&rcc STM32F4_AHB2_RESET(DCMI)>; >> + clocks = <&rcc 0 STM32F4_AHB2_CLOCK(DCMI)>; >> + clock-names = "mclk"; > >> + pinctrl-names = "default"; >> + pinctrl-0 = <&dcmi_pins>; > > Not documented. Fixed in v3. > >> + dmas = <&dma2 1 1 0x414 0x3>; >> + dma-names = "tx"; > > Not documented. Fixed in v3. > >> + status = "disabled"; > > Drop status from examples. Fixed in v3. > >> + }; >> + >> +Board setup example > > Please don't split examples. That's just source level details and not > part of the ABI. Fixed in v3. > >> +------------------- >> +This example is extracted from STM32F429-EVAL board devicetree. >> +Please note that on this board, the camera sensor reset & power-down >> +line level are inverted (so reset is active high and power-down is >> +active low). >> + >> +/ { >> + [...] >> + clocks { >> + clk_ext_camera: clk-ext-camera { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <24000000>; >> + }; >> + }; >> + [...] >> +}; >> + >> +&dcmi { >> + status = "okay"; >> + >> + port { >> + dcmi_0: endpoint at 0 { >> + remote-endpoint = <&ov2640_0>; >> + bus-width = <8>; >> + hsync-active = <0>; >> + vsync-active = <0>; >> + pclk-sample = <1>; >> + }; >> + }; >> +}; >> + >> +&i2c at 1 { >> + [...] >> + ov2640: camera at 30 { >> + compatible = "ovti,ov2640"; >> + reg = <0x30>; >> + resetb-gpios = <&stmpegpio 2 GPIO_ACTIVE_HIGH>; >> + pwdn-gpios = <&stmpegpio 0 GPIO_ACTIVE_LOW>; >> + clocks = <&clk_ext_camera>; >> + clock-names = "xvclk"; >> + status = "okay"; >> + >> + port { >> + ov2640_0: endpoint { >> + remote-endpoint = <&dcmi_0>; >> + }; >> + }; >> + }; >> +}; >> -- >> 1.9.1 >>