From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998F0C48BDF for ; Thu, 24 Jun 2021 10:45:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C02C611CB for ; Thu, 24 Jun 2021 10:45:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C02C611CB Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.146680.270036 (Exim 4.92) (envelope-from ) id 1lwMrT-0003wk-6w; Thu, 24 Jun 2021 10:45:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 146680.270036; Thu, 24 Jun 2021 10:45:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwMrT-0003wd-1D; Thu, 24 Jun 2021 10:45:31 +0000 Received: by outflank-mailman (input) for mailman id 146680; Thu, 24 Jun 2021 10:45:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lwMrR-0003wN-LH for xen-devel@lists.xenproject.org; Thu, 24 Jun 2021 10:45:29 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 296616c1-0f70-43d7-ab33-a3162f2b550f; Thu, 24 Jun 2021 10:45:28 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2E24D1FD35; Thu, 24 Jun 2021 10:45:27 +0000 (UTC) Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id E0CAB11A97; Thu, 24 Jun 2021 10:45:26 +0000 (UTC) Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id zdveM0Zi1GBTbAAALh3uQQ (envelope-from ); Thu, 24 Jun 2021 10:45:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 296616c1-0f70-43d7-ab33-a3162f2b550f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1624531527; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E7cVxLqvqo3PLW6jrqqbFokYkCRbWenjtRHMhRpYifc=; b=Qk8Ue81slrZRV462BnnkWpUwKFsTvJYKmq2muRb5HzZfoMxW9WHCEo2xTlyDpTJNhHuPdQ Eab2ShtR/k5seSfFwoXm92VMVXTxS8VBbR/I7UBCmgrw8hbnJ/RZXDZLxashq24Q9rQCOx ED/qUu3J3eKfSidlgvifOsWgNiK+TDg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1624531527; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E7cVxLqvqo3PLW6jrqqbFokYkCRbWenjtRHMhRpYifc=; b=Qk8Ue81slrZRV462BnnkWpUwKFsTvJYKmq2muRb5HzZfoMxW9WHCEo2xTlyDpTJNhHuPdQ Eab2ShtR/k5seSfFwoXm92VMVXTxS8VBbR/I7UBCmgrw8hbnJ/RZXDZLxashq24Q9rQCOx ED/qUu3J3eKfSidlgvifOsWgNiK+TDg= Subject: Re: [PATCH 09/10] tools/xenstored: Dump delayed requests To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, doebel@amazon.de, Julien Grall , Ian Jackson , Wei Liu References: <20210616144324.31652-1-julien@xen.org> <20210616144324.31652-10-julien@xen.org> <5b6455f3-9b44-2cf3-e53d-1f235977a4e2@suse.com> From: Juergen Gross Message-ID: <6e17cbd5-a819-2ed6-6f73-784cda2b9a5c@suse.com> Date: Thu, 24 Jun 2021 12:45:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="STaUbYCXc7fCqIbHNTHESdzQk5wtQ2QpT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --STaUbYCXc7fCqIbHNTHESdzQk5wtQ2QpT Content-Type: multipart/mixed; boundary="aztsCj61IwGDAZHRD8Dzmr672w3s8rZxf"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, doebel@amazon.de, Julien Grall , Ian Jackson , Wei Liu Message-ID: <6e17cbd5-a819-2ed6-6f73-784cda2b9a5c@suse.com> Subject: Re: [PATCH 09/10] tools/xenstored: Dump delayed requests References: <20210616144324.31652-1-julien@xen.org> <20210616144324.31652-10-julien@xen.org> <5b6455f3-9b44-2cf3-e53d-1f235977a4e2@suse.com> In-Reply-To: --aztsCj61IwGDAZHRD8Dzmr672w3s8rZxf Content-Type: multipart/mixed; boundary="------------02F1D18DB2EA1423ACD93D9D" Content-Language: en-US This is a multi-part message in MIME format. --------------02F1D18DB2EA1423ACD93D9D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 24.06.21 12:28, Julien Grall wrote: > Hi Juergen, >=20 > On 24/06/2021 10:41, Juergen Gross wrote: >> On 16.06.21 16:43, Julien Grall wrote: >>> From: Julien Grall >>> >>> Currently, only Live-Update request can be delayed. In a follow-up, >>> we will want to delay more requests (e.g. transaction start). >>> Therefore we want to preserve delayed requests across Live-Update. >>> >>> Delayed requests are just complete "in" buffer. So the code is >>> refactored to allow sharing the code to dump "in" buffer. >>> >>> Signed-off-by: Julien Grall >>> --- >>> =C2=A0 tools/xenstore/xenstored_core.c | 42 +++++++++++++++++++++++++= -------- >>> =C2=A0 1 file changed, 32 insertions(+), 10 deletions(-) >>> >>> diff --git a/tools/xenstore/xenstored_core.c=20 >>> b/tools/xenstore/xenstored_core.c >>> index 5b7ab7f74013..9eca58682b51 100644 >>> --- a/tools/xenstore/xenstored_core.c >>> +++ b/tools/xenstore/xenstored_core.c >>> @@ -2403,25 +2403,47 @@ const char *dump_state_global(FILE *fp) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return NULL; >>> =C2=A0 } >>> +static const char *dump_input_buffered_data(FILE *fp, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 con= ststruct buffered_data *in, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uns= igned int *total_len) >>> +{ >>> +=C2=A0=C2=A0=C2=A0 unsigned int hlen =3D in->inhdr ? in->used : size= of(in->hdr); >>> + >>> +=C2=A0=C2=A0=C2=A0 *total_len +=3D hlen; >>> +=C2=A0=C2=A0=C2=A0 if (fp && fwrite(&in->hdr, hlen, 1, fp) !=3D 1) >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "Dump read data er= ror"; >>> +=C2=A0=C2=A0=C2=A0 if (!in->inhdr && in->used) { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *total_len +=3D in->used;= >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (fp && fwrite(in->buff= er,in->used, 1, fp) !=3D 1) >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 r= eturn "Dump read data error"; >>> +=C2=A0=C2=A0=C2=A0 } >>> + >>> +=C2=A0=C2=A0=C2=A0 return NULL; >>> +} >>> + >>> =C2=A0 /* Called twice: first with fp =3D=3D NULL to get length, then=20 for=20 >>> writing data. */ >>> =C2=A0 const char *dump_state_buffered_data(FILE *fp, const struct=20 >>> connection *c, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct xs= _state_connection *sc) >>> =C2=A0 { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int len =3D 0, used; >>> -=C2=A0=C2=A0=C2=A0 struct buffered_data *out, *in =3D c->in; >>> +=C2=A0=C2=A0=C2=A0 struct buffered_data *out; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool partial =3D true; >>> +=C2=A0=C2=A0=C2=A0 struct delayed_request *req; >>> +=C2=A0=C2=A0=C2=A0 const char *ret; >>> -=C2=A0=C2=A0=C2=A0 if (in) { >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 len =3D in->inhdr ? in->u= sed: sizeof(in->hdr); >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (fp && fwrite(&in->hdr= , len, 1, fp) !=3D 1) >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 r= eturn "Dump read data error"; >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!in->inhdr && in->use= d) { >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 l= en +=3D in->used; >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 i= f (fp && fwrite(in->buffer, in->used, 1, fp) !=3D 1) >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 return "Dump read data error"; >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> +=C2=A0=C2=A0=C2=A0 /* Dump any command that was delayed */ >>> +=C2=A0=C2=A0=C2=A0 list_for_each_entry(req, &c->delayed, list) { >> >> Please add a comment here that the following if() serves especially to= >> avoid dumping the data for do_lu_start(). >=20 > Would you be happy to give your acked-by/reviewed-by if I add the=20 > following on commit? >=20 > " > We only want to preserve commands that wasn't processed at all. All the=20 s/wasn't/weren't/ > other delayed requests (such as do_lu_start()) must be processed before=20 > Live-Update. > " With that change I'm fine. Juergen --------------02F1D18DB2EA1423ACD93D9D Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------02F1D18DB2EA1423ACD93D9D-- --aztsCj61IwGDAZHRD8Dzmr672w3s8rZxf-- --STaUbYCXc7fCqIbHNTHESdzQk5wtQ2QpT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmDUYkYFAwAAAAAACgkQsN6d1ii/Ey/+ 8gf/YeGAQngLQXDoOWhF7M/sgh82dsz+hrHCI0dUFrRwadzLXN6Nzm84lv8e9LngdfyYWCNkuEFK RfLfz9dXrbLHQt3qegTPGn8zbk6hbLAwfaOddmDjJdAVzZKEpNE4qtxWMESkWWY7v1I1xJu3KUbD b5OFThU3v3FciFyird+CFfYB0pdTcBVOVGNCLXWi1erDGCpX9izpHcD8TCHDqpTuZ5OXTutNlMpP iqEAMfoM8HALDw8uygTOsR/liOXLXHcC5DT1v8kHOqB6G4Zi1i8vTmz5nexprKaPQwI1K/dvNwyd 9qaZ8VJMSs8htBVF64EK9hZIv8jyJ0iRY/kWHkopSA== =62KN -----END PGP SIGNATURE----- --STaUbYCXc7fCqIbHNTHESdzQk5wtQ2QpT--