From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Pandiyan, Dhinakaran" Subject: Re: [PATCH] drm/i915: Be defensive and don't assume PSR has any commit to sync against Date: Tue, 4 Sep 2018 20:54:03 +0000 Message-ID: <6e1e3faeb3372faf9d9d412ec776277fb4c26547.camel@intel.com> References: <20180904162902.2578-1-chris@chris-wilson.co.uk> <20180904173953.GI5565@intel.com> <153608305453.2853.15799668426378990226@skylake-alporthouse-com> <20180904175932.GJ5565@intel.com> <20180904180629.GK5565@intel.com> <153608476616.2853.7336345533645014202@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 044F489E26 for ; Tue, 4 Sep 2018 20:54:16 +0000 (UTC) In-Reply-To: <153608476616.2853.7336345533645014202@skylake-alporthouse-com> Content-Language: en-US Content-ID: <57F810BE98FF9D469E376190EA632672@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "ville.syrjala@linux.intel.com" , "chris@chris-wilson.co.uk" Cc: "intel-gfx@lists.freedesktop.org" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE4LTA5LTA0IGF0IDE5OjEyICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6DQo+ IFF1b3RpbmcgVmlsbGUgU3lyasOkbMOkICgyMDE4LTA5LTA0IDE5OjA2OjI5KQ0KPiA+IE9uIFR1 ZSwgU2VwIDA0LCAyMDE4IGF0IDA4OjU5OjMyUE0gKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90 ZToNCj4gPiA+IE9uIFR1ZSwgU2VwIDA0LCAyMDE4IGF0IDA2OjQ0OjE0UE0gKzAxMDAsIENocmlz IFdpbHNvbiB3cm90ZToNCj4gPiA+ID4gUXVvdGluZyBWaWxsZSBTeXJqw6Rsw6QgKDIwMTgtMDkt MDQgMTg6Mzk6NTMpDQo+ID4gPiA+ID4gT24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDU6Mjk6MDJQ TSArMDEwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOg0KPiA+ID4gPiA+ID4gSWYgdGhlIHByZXZpb3Vz IG1vZGVzZXQgY29tbWl0IGhhcyBjb21wbGV0ZWQgYW5kIGlzIG5vDQo+ID4gPiA+ID4gPiBsb25n ZXIgcGFydCBvZg0KPiA+ID4gPiA+ID4gdGhlIGNydGMgc3RhdGUsIHNraXAgd2FpdGluZyBmb3Ig aXQuDQo+ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJl ZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDc3DQo+ID4gPiA+ID4gPiA5Mg0KPiA+ID4g PiA+ID4gRml4ZXM6IGM0NDMwMWZjZTYxNCAoImRybS9pOTE1OiBBbGxvdyBjb250cm9sIG9mIFBT UiBhdA0KPiA+ID4gPiA+ID4gcnVudGltZSB0aHJvdWdoIGRlYnVnZnMsIHY2IikNCj4gPiA+ID4g PiA+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pg0KPiA+ID4gPiA+ID4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBs aW51eC5pbnRlbC5jb20+DQo+ID4gPiA+ID4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZp dmlAaW50ZWwuY29tPg0KPiA+ID4gPiA+ID4gQ2M6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5h a2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPg0KPiA+ID4gPiA+ID4gLS0tDQo+ID4gPiA+ID4gPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCAxNiArKysrKysrKysrLS0tLS0tDQo+ ID4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25z KC0pDQo+ID4gPiA+ID4gPiANCj4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wc3IuYw0KPiA+ID4gPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9wc3IuYw0KPiA+ID4gPiA+ID4gaW5kZXggMjE5ODRkNGMwOGVkLi5iZGRjOWM3YzY4MWUg MTAwNjQ0DQo+ID4gPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3Iu Yw0KPiA+ID4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMNCj4g PiA+ID4gPiA+IEBAIC04MzQsNiArODM0LDcgQEAgaW50IGludGVsX3Bzcl9zZXRfZGVidWdmc19t b2RlKHN0cnVjdA0KPiA+ID4gPiA+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsDQo+ID4g PiA+ID4gPiAgICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gJmRldl9wcml2LT5kcm07DQo+ ID4gPiA+ID4gPiAgICAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsN Cj4gPiA+ID4gPiA+ICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlID0g TlVMTDsNCj4gPiA+ID4gPiA+ICsgICAgIHN0cnVjdCBkcm1fY3J0Y19jb21taXQgKmNvbW1pdCA9 IE5VTEw7DQo+ID4gPiA+ID4gPiAgICAgICBzdHJ1Y3QgZHJtX2NydGMgKmNydGM7DQo+ID4gPiA+ ID4gPiAgICAgICBzdHJ1Y3QgaW50ZWxfZHAgKmRwOw0KPiA+ID4gPiA+ID4gICAgICAgaW50IHJl dDsNCj4gPiA+ID4gPiA+IEBAIC04NjAsMTIgKzg2MSwxNSBAQCBpbnQgaW50ZWxfcHNyX3NldF9k ZWJ1Z2ZzX21vZGUoc3RydWN0DQo+ID4gPiA+ID4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwNCj4gPiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ID4g PiA+ID4gIA0KPiA+ID4gPiA+ID4gICAgICAgICAgICAgICBjcnRjX3N0YXRlID0gdG9faW50ZWxf Y3J0Y19zdGF0ZShjcnRjLQ0KPiA+ID4gPiA+ID4gPnN0YXRlKTsNCj4gPiA+ID4gPiA+IC0gICAg ICAgICAgICAgcmV0ID0NCj4gPiA+ID4gPiA+IHdhaXRfZm9yX2NvbXBsZXRpb25faW50ZXJydXB0 aWJsZSgmY3J0Y19zdGF0ZS0+YmFzZS5jb21taXQtDQo+ID4gPiA+ID4gPiA+aHdfZG9uZSk7DQo+ ID4gPiA+ID4gPiAtICAgICB9IGVsc2UNCj4gPiA+ID4gPiA+IC0gICAgICAgICAgICAgcmV0ID0N Cj4gPiA+ID4gPiA+IHdhaXRfZm9yX2NvbXBsZXRpb25faW50ZXJydXB0aWJsZSgmY29ubl9zdGF0 ZS0+Y29tbWl0LQ0KPiA+ID4gPiA+ID4gPmh3X2RvbmUpOw0KPiA+ID4gPiA+ID4gLQ0KPiA+ID4g PiA+ID4gLSAgICAgaWYgKHJldCkNCj4gPiA+ID4gPiA+IC0gICAgICAgICAgICAgcmV0dXJuIHJl dDsNCj4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgY29tbWl0ID0gY3J0Y19zdGF0ZS0+YmFzZS5j b21taXQ7DQo+ID4gPiA+ID4gPiArICAgICB9IGVsc2Ugew0KPiA+ID4gPiA+ID4gKyAgICAgICAg ICAgICBjb21taXQgPSBjb25uX3N0YXRlLT5jb21taXQ7DQo+ID4gPiA+ID4gDQo+ID4gPiA+ID4g SSBjYW4ndCBldmVuIGZpbmQgd2hlcmUgd2UgY2xlYXIgc3RhdGUtPmNvbW1pdCBhZnRlciBpdHMN Cj4gPiA+ID4gPiBkb25lLg0KPiA+ID4gPiA+IERvIHdlIGp1c3QgbGVhdmUgaXQgcG9pbnRpbmcg YXQgZnJlZWQgbWVtb3J5IG9yIHNvbWV0aGluZz8NCj4gPiA+ID4gPiBBbHNvIEkNCj4gPiA+ID4g PiBjYW4ndCBmaWd1cmUgb3V0IHdoeSBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfaHdfZG9uZSgp DQo+ID4gPiA+ID4gY29waWVzDQo+ID4gPiA+ID4gdGhlIGNvbW1pdCBhbHNvIHRvIHRoZSBvbGQg c3RhdGUuDQo+ID4gPiA+IA0KPiA+ID4gPiBMZXQgbWUgYmUgdGhlIG1lc3NlbmdlciB0aGVuIDsp IGNvbW1pdCBpcyBOVUxMIGF0IHRoaXMgcG9pbnQsIEkNCj4gPiA+ID4ganVzdA0KPiA+ID4gPiBw cmVzdW1lZCBpdCB3YXMgaW50ZW50aW9uYWwuDQo+ID4gPiANCj4gPiA+IE15IGV4cGVjdGF0aW9u IHdvdWxkIGJlIHRoYXQgaXQgZ2V0cyBjbGVhcmVkIHNvbWV3aGVyZSwgYnV0IEkNCj4gPiA+IHNp bXBseQ0KPiA+ID4gY2FuJ3QgZmluZCBhbnkgc3VjaCBjb2RlLg0KPiA+IA0KPiA+IEFjdHVhbGx5 IGl0IGxvb2tzIGxpa2UgdGhlcmUgaXMgbm8gc3VjaCBjb2RlLiBUaGUgZXZlbnQgYmFzZWQNCj4g PiByZWxlYXNlX2NydGNfY29tbWl0KCkgdGhpbmcgZ2V0cyBpdHMgb3duIHJlZmVyZW5jZSBzbyBw cmVzdW1hYmx5DQo+ID4gdGhlDQo+ID4gb3JpZ2luYWwgcmVmZXJlbmNlIHN0YXlzIHdpdGggdGhl IHN0YXRlIHVudGlsIHRoZSBzdGF0ZSBpdHNlbGYgZ2V0cw0KPiA+IGRlc3Ryb3llZC4NCj4gDQo+ IEhhcHB5IHdpdGggdGhlIGl0IG5ldmVyIGhhZCBhIGNvbW1pdCB0aGVvcnksIG9yIGlzIHRoaXMg YSBkZWVwZXINCj4gcHJvYmxlbQ0KPiB0aGF0IG5lZWRzIHJvb3QgY2F1c2luZz8NCg0KSnVzdCBz byB0aGF0IEkgdW5kZXJzdGFuZCB0aGlzIGNvcnJlY3RseSwgZXZlbiBpZiB0aGVyZSB3YXMgYSBw cmlvcg0KY29tbWl0LCBzdGF0ZS0+Y29tbWl0IHdvdWxkIGhhdmUgYmVlbiBmcmVlZCB3aGVuIGNv bXBsZXRpb24gd2FzDQpzaWduYWxlZC4gSXMgdGhhdCByaWdodD8NCg0KDQo+IC1DaHJpcwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK