From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH 11/17] ARM: dts: Add missing mcasp node for omap4 Date: Mon, 4 Sep 2017 09:55:48 +0300 Message-ID: <6e1f8163-d457-22f1-4d96-9f278c22144c@ti.com> References: <20170828211918.11573-1-tony@atomide.com> <20170828211918.11573-12-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20170828211918.11573-12-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tony Lindgren , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: =?UTF-8?Q?Beno=c3=aet_Cousson?= , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Girdwood , Mark Brown List-Id: devicetree@vger.kernel.org =EF=BB=BF Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Bu= siness ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-29 00:19, Tony Lindgren wrote: > On omap4 we're missing the mcasp node with it's related "ti,hwmods" > property that the SoC interconnect code needs. >=20 > Note that this will only show up as a bug with "doesn't have > mpu register target base" boot errors when the legacy platform > data is removed. >=20 > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Peter Ujfalusi > Signed-off-by: Tony Lindgren > --- > Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt | 1 + > arch/arm/boot/dts/omap4.dtsi | 9 ++++= +++++ > 2 files changed, 10 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.= txt b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt > --- a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt > +++ b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt > @@ -6,6 +6,7 @@ Required properties: > "ti,da830-mcasp-audio" : for both DA830 & DA850 platforms > "ti,am33xx-mcasp-audio" : for AM33xx platforms (AM33xx, AM43xx, TI81xx) > "ti,dra7-mcasp-audio" : for DRA7xx platforms > + "ti,omap4-mcasp-audio" : for OMAP4 platforms > =20 > - reg : Should contain reg specifiers for the entries in the reg-names p= roperty. > - reg-names : Should contain: > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -750,6 +750,15 @@ > status =3D "disabled"; > }; > =20 > + mcasp: mcasp@40128000 { > + compatible =3D "ti,omap4-mcasp-audio"; > + reg =3D <0x40128000 0x400>, /* MPU private access */ > + <0x49028000 0x400>; /* L3 Interconnect */ > + reg-names =3D "mpu", "dma"; > + interrupts =3D ; interrupt-names =3D "tx"; Can you add the DMA as well: dmas =3D <&sdma 8>; dma-names =3D "tx"; The RX of McASP is disabled, no RX DMA request. > + ti,hwmods =3D "mcasp"; > + }; > + > slimbus1: slimbus@4012c000 { > compatible =3D "ti,omap4-slimbus"; > reg =3D <0x4012c000 0x400>, /* MPU private access */ >=20 - P=C3=A9ter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html