From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 870F9C43334 for ; Fri, 8 Jul 2022 07:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237138AbiGHHx5 (ORCPT ); Fri, 8 Jul 2022 03:53:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237490AbiGHHxt (ORCPT ); Fri, 8 Jul 2022 03:53:49 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD82D2CE01 for ; Fri, 8 Jul 2022 00:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657266828; x=1688802828; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=226n02MK38Ht0X6q4rCIPnDL++KJz3PSWDz7ZAUD+1w=; b=HKz3qwxDYMVMqAhWITTPB116RJrukIagwdJys6K0Xqndjd24hAPG2SoK Bhx37uQnTAbwNC2AsB+p1RNgR0lWYmmN2wRjLQe+SW2RxYFS+kgIxuAEb RyNtoA7F7kMDSTCt2AS+f1eD7ZCWZ0Ln+y8hVTO5X7TW6zxyXbdyRcC4c 4KCoTinxLK8l3Yh5rezZmcbyl7HQXF+1MpRFebpeCMeKZ8oxpElkbrWU7 AOMnWPYjxy/tV1RWo4zlXaxfa+qSCaqrDonQ4d2WHle50xsY/FAiNreC8 xZtgL4fq1Xtwz1UMjCBMGTd4+obER5DRy45NTY6f9VhOzYKcPNjhnX8US g==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="282974159" X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="282974159" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 00:53:47 -0700 X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="661691042" Received: from cmchugh-mobl.ger.corp.intel.com (HELO [10.213.229.21]) ([10.213.229.21]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 00:53:45 -0700 Message-ID: <6e387f90-dce3-486d-83e9-26a975777265@intel.com> Date: Fri, 8 Jul 2022 08:53:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH v10 04/11] drm/i915/gem: selftest should not attempt mmap of private regions Content-Language: en-GB To: Robert Beckett , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter Cc: kernel@collabora.com, =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , linux-kernel@vger.kernel.org References: <20220707200230.1657555-1-bob.beckett@collabora.com> <20220707200230.1657555-5-bob.beckett@collabora.com> From: Matthew Auld In-Reply-To: <20220707200230.1657555-5-bob.beckett@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/2022 21:02, Robert Beckett wrote: > During testing make can_mmap consider whether the region is private. Do we still need this with: 938d2fd17d17 ("drm/i915/selftests: skip the mman tests for stolen") ? > > Signed-off-by: Robert Beckett > Reviewed-by: Thomas Hellström > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > index 5bc93a1ce3e3..76181e28c75e 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > @@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type) > struct drm_i915_private *i915 = to_i915(obj->base.dev); > bool no_map; > > + if (obj->mm.region && obj->mm.region->private) > + return false; > + > if (obj->ops->mmap_offset) > return type == I915_MMAP_TYPE_FIXED; > else if (type == I915_MMAP_TYPE_FIXED) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C806C433EF for ; Fri, 8 Jul 2022 07:53:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 58CAC10F972; Fri, 8 Jul 2022 07:53:49 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BE9510F972; Fri, 8 Jul 2022 07:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657266828; x=1688802828; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=226n02MK38Ht0X6q4rCIPnDL++KJz3PSWDz7ZAUD+1w=; b=HKz3qwxDYMVMqAhWITTPB116RJrukIagwdJys6K0Xqndjd24hAPG2SoK Bhx37uQnTAbwNC2AsB+p1RNgR0lWYmmN2wRjLQe+SW2RxYFS+kgIxuAEb RyNtoA7F7kMDSTCt2AS+f1eD7ZCWZ0Ln+y8hVTO5X7TW6zxyXbdyRcC4c 4KCoTinxLK8l3Yh5rezZmcbyl7HQXF+1MpRFebpeCMeKZ8oxpElkbrWU7 AOMnWPYjxy/tV1RWo4zlXaxfa+qSCaqrDonQ4d2WHle50xsY/FAiNreC8 xZtgL4fq1Xtwz1UMjCBMGTd4+obER5DRy45NTY6f9VhOzYKcPNjhnX8US g==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="284245278" X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="284245278" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 00:53:47 -0700 X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="661691042" Received: from cmchugh-mobl.ger.corp.intel.com (HELO [10.213.229.21]) ([10.213.229.21]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 00:53:45 -0700 Message-ID: <6e387f90-dce3-486d-83e9-26a975777265@intel.com> Date: Fri, 8 Jul 2022 08:53:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH v10 04/11] drm/i915/gem: selftest should not attempt mmap of private regions Content-Language: en-GB To: Robert Beckett , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter References: <20220707200230.1657555-1-bob.beckett@collabora.com> <20220707200230.1657555-5-bob.beckett@collabora.com> From: Matthew Auld In-Reply-To: <20220707200230.1657555-5-bob.beckett@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , kernel@collabora.com, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 07/07/2022 21:02, Robert Beckett wrote: > During testing make can_mmap consider whether the region is private. Do we still need this with: 938d2fd17d17 ("drm/i915/selftests: skip the mman tests for stolen") ? > > Signed-off-by: Robert Beckett > Reviewed-by: Thomas Hellström > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > index 5bc93a1ce3e3..76181e28c75e 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > @@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type) > struct drm_i915_private *i915 = to_i915(obj->base.dev); > bool no_map; > > + if (obj->mm.region && obj->mm.region->private) > + return false; > + > if (obj->ops->mmap_offset) > return type == I915_MMAP_TYPE_FIXED; > else if (type == I915_MMAP_TYPE_FIXED) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C156C43334 for ; Fri, 8 Jul 2022 07:53:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0611F10F978; Fri, 8 Jul 2022 07:53:50 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BE9510F972; Fri, 8 Jul 2022 07:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657266828; x=1688802828; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=226n02MK38Ht0X6q4rCIPnDL++KJz3PSWDz7ZAUD+1w=; b=HKz3qwxDYMVMqAhWITTPB116RJrukIagwdJys6K0Xqndjd24hAPG2SoK Bhx37uQnTAbwNC2AsB+p1RNgR0lWYmmN2wRjLQe+SW2RxYFS+kgIxuAEb RyNtoA7F7kMDSTCt2AS+f1eD7ZCWZ0Ln+y8hVTO5X7TW6zxyXbdyRcC4c 4KCoTinxLK8l3Yh5rezZmcbyl7HQXF+1MpRFebpeCMeKZ8oxpElkbrWU7 AOMnWPYjxy/tV1RWo4zlXaxfa+qSCaqrDonQ4d2WHle50xsY/FAiNreC8 xZtgL4fq1Xtwz1UMjCBMGTd4+obER5DRy45NTY6f9VhOzYKcPNjhnX8US g==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="284245278" X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="284245278" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 00:53:47 -0700 X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="661691042" Received: from cmchugh-mobl.ger.corp.intel.com (HELO [10.213.229.21]) ([10.213.229.21]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 00:53:45 -0700 Message-ID: <6e387f90-dce3-486d-83e9-26a975777265@intel.com> Date: Fri, 8 Jul 2022 08:53:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Content-Language: en-GB To: Robert Beckett , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter References: <20220707200230.1657555-1-bob.beckett@collabora.com> <20220707200230.1657555-5-bob.beckett@collabora.com> From: Matthew Auld In-Reply-To: <20220707200230.1657555-5-bob.beckett@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v10 04/11] drm/i915/gem: selftest should not attempt mmap of private regions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , kernel@collabora.com, linux-kernel@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 07/07/2022 21:02, Robert Beckett wrote: > During testing make can_mmap consider whether the region is private. Do we still need this with: 938d2fd17d17 ("drm/i915/selftests: skip the mman tests for stolen") ? > > Signed-off-by: Robert Beckett > Reviewed-by: Thomas Hellström > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > index 5bc93a1ce3e3..76181e28c75e 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > @@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type) > struct drm_i915_private *i915 = to_i915(obj->base.dev); > bool no_map; > > + if (obj->mm.region && obj->mm.region->private) > + return false; > + > if (obj->ops->mmap_offset) > return type == I915_MMAP_TYPE_FIXED; > else if (type == I915_MMAP_TYPE_FIXED)