From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Joseph, Anoob" Subject: Re: [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD Date: Fri, 5 Oct 2018 19:05:55 +0530 Message-ID: <6e4292aa-76fc-d0f6-5f13-82c04f6e265f@caviumnetworks.com> References: <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1538744363-30340-1-git-send-email-anoob.joseph@caviumnetworks.com> <5ff7c39c-44cf-3071-5be6-1f61c664bdf3@nxp.com> <86c7edb1-8935-80f3-c37d-91f6b65a8f9e@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: Jerin Jacob , Narayana Prasad , Ankur Dwivedi , Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj , dev@dpdk.org To: Akhil Goyal , Pablo de Lara , Thomas Monjalon Return-path: Received: from NAM05-CO1-obe.outbound.protection.outlook.com (mail-eopbgr720085.outbound.protection.outlook.com [40.107.72.85]) by dpdk.org (Postfix) with ESMTP id E52751B123 for ; Fri, 5 Oct 2018 15:34:53 +0200 (CEST) In-Reply-To: <86c7edb1-8935-80f3-c37d-91f6b65a8f9e@nxp.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, v2: * Moved common code identified for crypto devices of OCTEON TX family to common/cpt. * Divided the patches to make sure one feature gets added with one patch. * Addressed indentation issues. * Addressed comments from Jerin and Pablo. v3: * Merged v2-0001* & v2-0003* patch (Akhil) * Replaced macro used in capabilities with array and function to return it (Thomas) * Consistent comments in the code base (Akhil) * Added missing comments for members of structure (Akhil) * Added missing feature flags for scatter-gather (Akhil) * Added validation tests for testing the newly introduced flags (Akhil) * Added missing flags etc in doc (Akhil) * Improvements in the function cpt_fc_ciph_set_key function (patch 0017) * Fixed typos (Akhil) * Other optimizations (removed non-critical members in structures accessed in data path etc) Thanks, Anoob On 05-10-2018 18:44, Akhil Goyal wrote: > External Email > > On 10/5/2018 6:43 PM, Joseph, Anoob wrote: >> Hi Akhil, >> >> Do you want me to send revised cover letter patch or just summarizing >> it over email would do? > You could do it as you prefer. Just wanted to know the changes that were > done in every version that are sent. >> >> Thanks, >> Anoob >> On 05-10-2018 18:34, Akhil Goyal wrote: >>> External Email >>> >>> Hi Anoob, >>> >>> Could you please add the change log in the cover note. >>> >>> Thanks, >>> Akhil >>> >>> On 10/5/2018 6:28 PM, Anoob Joseph wrote: >>>> Ankur Dwivedi (5): >>>>    common/cpt: add common logging support >>>>    config: add Cavium OCTEONTX crypto PMD skeleton >>>>    crypto/octeontx: add register addresses >>>>    common/cpt: add common code for init routine >>>>    test: adds validation test >>>> >>>> Anoob Joseph (5): >>>>    crypto/octeontx: add hardware init routine >>>>    common/cpt: add hardware register defines >>>>    crypto/octeontx: add hardware register access for misc poll >>>>    crypto/octeontx: adds symmetric capabilities >>>>    doc: adds doc file >>>> >>>> Murthy NSSR (5): >>>>    common/cpt: add PMD ops helper functions >>>>    crypto/octeontx: add global resource init >>>>    crypto/octeontx: add mailbox routines >>>>    crypto/octeontx: add basic dev ops >>>>    common/cpt: add common macros for queue pair ops >>>> >>>> Nithin Dabilpuram (5): >>>>    crypto/octeontx: add queue pair functions >>>>    common/cpt: add common code required for session management >>>>    crypto/octeontx: add session management ops >>>>    common/cpt: add common code for fill session data >>>>    crypto/octeontx: add supported sessions >>>> >>>> Ragothaman Jayaraman (4): >>>>    common/cpt: add common defines for microcode >>>>    common/cpt: add microcode interface for encryption >>>>    common/cpt: add microcode interface for decryption >>>>    common/cpt: add crypo op enqueue request manager framework >>>> >>>> Srisivasubramanian S (4): >>>>    common/cpt: add support for zuc and snow3g >>>>    common/cpt: add support for kasumi >>>>    common/cpt: add support for hash >>>>    crypto/octeontx: add routines to prepare instructions >>>> >>>> Tejasree Kondoj (4): >>>>    common/cpt: add common code for enqueuing cpt instruction >>>>    crypto/octeontx: add enqueue burst op >>>>    common/cpt: add common code for cpt dequeue >>>>    crypto/octeontx: add dequeue burst op >>>> >>>>   MAINTAINERS                                        |    7 + >>>>   config/common_base                                 |    5 + >>>>   doc/guides/cryptodevs/features/octeontx.ini        |   62 + >>>>   doc/guides/cryptodevs/index.rst                    |    1 + >>>>   doc/guides/cryptodevs/octeontx.rst                 |  128 + >>>>   drivers/common/Makefile                            |    4 + >>>>   drivers/common/cpt/Makefile                        |   25 + >>>>   drivers/common/cpt/cpt_common.h                    |   91 + >>>>   drivers/common/cpt/cpt_hw_types.h                  |  522 +++ >>>>   drivers/common/cpt/cpt_mcode_defines.h             |  386 +++ >>>>   drivers/common/cpt/cpt_pmd_logs.h                  |   50 + >>>>   drivers/common/cpt/cpt_pmd_ops_helper.c            |   41 + >>>>   drivers/common/cpt/cpt_pmd_ops_helper.h            |   34 + >>>>   drivers/common/cpt/cpt_request_mgr.h               |  185 + >>>>   drivers/common/cpt/cpt_ucode.h                     | 3650 >>>> ++++++++++++++++++++ >>>>   drivers/common/cpt/meson.build                     |    8 + >>>>   drivers/common/cpt/rte_common_cpt_version.map      |    6 + >>>>   drivers/common/meson.build                         |    2 +- >>>>   drivers/crypto/Makefile                            |    1 + >>>>   drivers/crypto/meson.build                         |    2 +- >>>>   drivers/crypto/octeontx/Makefile                   |   46 + >>>>   drivers/crypto/octeontx/meson.build                |   18 + >>>>   drivers/crypto/octeontx/otx_cryptodev.c            |  133 + >>>>   drivers/crypto/octeontx/otx_cryptodev.h            |   20 + >>>>   .../crypto/octeontx/otx_cryptodev_capabilities.c   |  604 ++++ >>>>   .../crypto/octeontx/otx_cryptodev_capabilities.h   |   17 + >>>>   drivers/crypto/octeontx/otx_cryptodev_hw_access.c  |  598 ++++ >>>>   drivers/crypto/octeontx/otx_cryptodev_hw_access.h  |  320 ++ >>>>   drivers/crypto/octeontx/otx_cryptodev_mbox.c       |  178 + >>>>   drivers/crypto/octeontx/otx_cryptodev_mbox.h       |   92 + >>>>   drivers/crypto/octeontx/otx_cryptodev_ops.c        |  531 +++ >>>>   drivers/crypto/octeontx/otx_cryptodev_ops.h        |   18 + >>>>   .../octeontx/rte_pmd_octeontx_crypto_version.map   |    4 + >>>>   mk/rte.app.mk                                      |    5 + >>>>   test/test/meson.build                              |    1 + >>>>   test/test/test_cryptodev.c                         |  316 ++ >>>>   test/test/test_cryptodev.h                         |    1 + >>>>   test/test/test_cryptodev_aes_test_vectors.h        |  114 +- >>>>   test/test/test_cryptodev_blockcipher.c             |    9 +- >>>>   test/test/test_cryptodev_blockcipher.h             |    1 + >>>>   test/test/test_cryptodev_des_test_vectors.h        |   12 +- >>>>   test/test/test_cryptodev_hash_test_vectors.h       |   78 +- >>>>   42 files changed, 8255 insertions(+), 71 deletions(-) >>>>   create mode 100644 doc/guides/cryptodevs/features/octeontx.ini >>>>   create mode 100644 doc/guides/cryptodevs/octeontx.rst >>>>   create mode 100644 drivers/common/cpt/Makefile >>>>   create mode 100644 drivers/common/cpt/cpt_common.h >>>>   create mode 100644 drivers/common/cpt/cpt_hw_types.h >>>>   create mode 100644 drivers/common/cpt/cpt_mcode_defines.h >>>>   create mode 100644 drivers/common/cpt/cpt_pmd_logs.h >>>>   create mode 100644 drivers/common/cpt/cpt_pmd_ops_helper.c >>>>   create mode 100644 drivers/common/cpt/cpt_pmd_ops_helper.h >>>>   create mode 100644 drivers/common/cpt/cpt_request_mgr.h >>>>   create mode 100644 drivers/common/cpt/cpt_ucode.h >>>>   create mode 100644 drivers/common/cpt/meson.build >>>>   create mode 100644 drivers/common/cpt/rte_common_cpt_version.map >>>>   create mode 100644 drivers/crypto/octeontx/Makefile >>>>   create mode 100644 drivers/crypto/octeontx/meson.build >>>>   create mode 100644 drivers/crypto/octeontx/otx_cryptodev.c >>>>   create mode 100644 drivers/crypto/octeontx/otx_cryptodev.h >>>>   create mode 100644 >>>> drivers/crypto/octeontx/otx_cryptodev_capabilities.c >>>>   create mode 100644 >>>> drivers/crypto/octeontx/otx_cryptodev_capabilities.h >>>>   create mode 100644 drivers/crypto/octeontx/otx_cryptodev_hw_access.c >>>>   create mode 100644 drivers/crypto/octeontx/otx_cryptodev_hw_access.h >>>>   create mode 100644 drivers/crypto/octeontx/otx_cryptodev_mbox.c >>>>   create mode 100644 drivers/crypto/octeontx/otx_cryptodev_mbox.h >>>>   create mode 100644 drivers/crypto/octeontx/otx_cryptodev_ops.c >>>>   create mode 100644 drivers/crypto/octeontx/otx_cryptodev_ops.h >>>>   create mode 100644 >>>> drivers/crypto/octeontx/rte_pmd_octeontx_crypto_version.map >>>> >>> >> >