From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905CFC6FA82 for ; Mon, 26 Sep 2022 08:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233554AbiIZI4F (ORCPT ); Mon, 26 Sep 2022 04:56:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbiIZI4E (ORCPT ); Mon, 26 Sep 2022 04:56:04 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE7782F645 for ; Mon, 26 Sep 2022 01:56:02 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id c7so6592974ljm.12 for ; Mon, 26 Sep 2022 01:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=LygWxMPYiiK3qZH2BOr8vVIkBAjDPXCSKFsPmYOYNp4=; b=YZg/aIRbC0PHB9nhtnEszdhN+jwLatJdmHoRaxhB+SGlCd5dmDboTAF2GVP9SBWIYb QybMQpCFM5x9sLv2YKOHXNZvF21YLysRqGGEwQItaJsbYWve+5nrFkmBNqUOHQ9tBGk2 ZyreflIF4/lnqqflZJEbN2MGmmWy9kdmGdk1tBbjGpuDEQBQxcdb61FK76YE41F2Fpyz B0yR2mymcIYpofTmEpEHZB8xw9fLf8y9ytQUlCzaXuaqeGpmQkcuPOlL3ZwNOURTdD/w IWWs+BSSNjyahkZvoRtWs/xkXXSGEUILF09RkJQIyp6bx9LNOayLBIsgwYscOD6KBxSL WlTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=LygWxMPYiiK3qZH2BOr8vVIkBAjDPXCSKFsPmYOYNp4=; b=vRita/5yHJnwK5UWGR+AXljTP8p2OoZSsJ+3HDSZDjtjeerYdc4ZCaO6pwVMMFrwkO vdNzEc+p6R39v4sLbUpGUxbGguHyfuHjZUdAv3vjFpiRqg7ajAFDjKJMWteFuiWz5lbD DrS/l3ddiSn1BRZ7Omk8rByvoSP6+k+3xsRMtNcEEJA3KCQCiVSBPK7kyRwkbqFt0Yfr Fy/kClpMAnSBQDNJNf4PQY+kBVSxmY+d8nJy+YCEPAfBbfxiMyKv3ISl95Z1yOvqOGFg s6VUDbULZoujMaHqreGs95gC9APJbIc1wQXE3Q7SmQ+/B4jFgM9ui+opv5OqEcO2/Ijy pXZA== X-Gm-Message-State: ACrzQf09tuwq2wmPuZV3YnR+va4ujxHVYNR8QTn+kCvlZarU0XLybRmE cQyV5HWW/cuRMB30dVO0ZVUcAQ== X-Google-Smtp-Source: AMsMyM5A6TYCbX/hg5uRQ698K2J10sgO4nLPjMSO7EHPQ1s5wRt/HXI9m7i2VCM+76dMMIPYm9tfig== X-Received: by 2002:a2e:bba2:0:b0:26b:e2d6:fe44 with SMTP id y34-20020a2ebba2000000b0026be2d6fe44mr7080053lje.286.1664182561232; Mon, 26 Sep 2022 01:56:01 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u15-20020a2e9f0f000000b0026c4c1a0b4dsm2308051ljk.126.2022.09.26.01.55.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 01:56:00 -0700 (PDT) Message-ID: <6e43fd39-3452-c36d-d9ff-fd508ac337c9@linaro.org> Date: Mon, 26 Sep 2022 10:55:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH net-next v3 1/6] dt-bindings: net: tsnep: Allow dma-coherent Content-Language: en-US To: Gerhard Engleder , netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org References: <20220923202911.119729-1-gerhard@engleder-embedded.com> <20220923202911.119729-2-gerhard@engleder-embedded.com> <6e814bf8-7033-2f5d-9124-feaa6593a129@linaro.org> <773e8425-58ff-1f17-f0eb-2041f3114105@engleder-embedded.com> <7c7f67d3-d42e-a053-256d-706cc9dfb947@linaro.org> <7782924b-9664-6946-f8f6-c70cec618df9@engleder-embedded.com> From: Krzysztof Kozlowski In-Reply-To: <7782924b-9664-6946-f8f6-c70cec618df9@engleder-embedded.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 25/09/2022 10:14, Gerhard Engleder wrote: > On 25.09.22 09:41, Krzysztof Kozlowski wrote: >> On 24/09/2022 20:11, Gerhard Engleder wrote: >>> On 24.09.22 11:15, Krzysztof Kozlowski wrote: >>>> On 23/09/2022 22:29, Gerhard Engleder wrote: >>>>> Fix the following dtbs_check error if dma-coherent is used: >>>>> >>>>> ...: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >>>>> From schema: .../Documentation/devicetree/bindings/net/engleder,tsnep.yaml >>>> >>>> Skip last line - it's obvious. What instead you miss here - the >>>> DTS/target which has this warning. I assume that some existing DTS uses >>>> this property? >>> >>> I will skip that line. >>> >>> The binding is for an FPGA based Ethernet MAC. I'm working with >>> an evaluation platform currently. The DTS for the evaluation platform >>> is mainline, but my derived DTS was not accepted mainline. So there is >>> no DTS. This is similar for other FPGA based devices. >> >> If this is not coming from mainline, then there is no warning... we are >> not interested in warnings in out-of-tree code, because we are not >> fixing them. > > Ok. So I would rewrite the description that it just allows dma-coherent > and remove the fix/warning stuff. Is that ok? That would be okay, but please add answer to why you are making this change. Best regards, Krzysztof