All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: Marek Vasut <marex@denx.de>, u-boot@lists.denx.de, sbabic@denx.de
Cc: Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v2] ARM: imx: Enable instruction cache early on on i.MX8M
Date: Wed, 13 Apr 2022 09:47:11 +0200	[thread overview]
Message-ID: <6e4c1aba-23d4-837e-bc5d-b784dc86f786@denx.de> (raw)
In-Reply-To: <20220412224152.194959-1-marex@denx.de>

On 13.04.22 00:41, Marek Vasut wrote:
> Enable instruction cache early on to speed up the boot process on i.MX8M.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> V2: Protect the icache_enable with !CONFIG_IS_ENABLED(SYS_ICACHE_OFF),
>      the symbol might be undefined in case CONFIG_(SPL_)SYS_ICACHE_OFF
>      is set
> ---
>   arch/arm/mach-imx/imx8m/soc.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
> index bb94ef51492..8171631db10 100644
> --- a/arch/arm/mach-imx/imx8m/soc.c
> +++ b/arch/arm/mach-imx/imx8m/soc.c
> @@ -550,6 +550,11 @@ EVENT_SPY(EVT_DM_POST_INIT, imx8m_check_clock);
>   int arch_cpu_init(void)
>   {
>   	struct ocotp_regs *ocotp = (struct ocotp_regs *)OCOTP_BASE_ADDR;
> +
> +#if !CONFIG_IS_ENABLED(SYS_ICACHE_OFF)
> +	icache_enable();
> +#endif
> +
>   	/*
>   	 * ROM might disable clock for SCTR,
>   	 * enable the clock before timer_init.

Thanks for fast fix - I apply this before my PR.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

  reply	other threads:[~2022-04-13  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 22:41 [PATCH v2] ARM: imx: Enable instruction cache early on on i.MX8M Marek Vasut
2022-04-13  7:47 ` Stefano Babic [this message]
2022-04-13  9:31 ` sbabic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e4c1aba-23d4-837e-bc5d-b784dc86f786@denx.de \
    --to=sbabic@denx.de \
    --cc=festevam@gmail.com \
    --cc=marex@denx.de \
    --cc=peng.fan@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.