From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 3/3] xen/vcpu: Rework sanity checks in vcpu_create() Date: Fri, 7 Sep 2018 00:01:32 +0100 Message-ID: <6e5f11bb-bd6d-5d76-24f4-62f71224f60c@citrix.com> References: <1536261934-1236-1-git-send-email-andrew.cooper3@citrix.com> <1536261934-1236-4-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jason Andryuk Cc: sstabellini@kernel.org, Wei Liu , xen-devel@lists.xen.org, julien.grall@arm.com, Jan Beulich , roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org T24gMDYvMDkvMTggMjE6MDcsIEphc29uIEFuZHJ5dWsgd3JvdGU6Cj4gT24gVGh1LCBTZXAgNiwg MjAxOCBhdCAzOjI4IFBNIEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ IHdyb3RlOgo+PiBQb2lzb25pbmcgaWRsZV92Y3B1WzBdIHdpdGggdGhlIHNhbml0eSBkZWJ1ZyB2 YWx1ZSBpc24ndCBhY3R1YWxseSBhIGNsZXZlcgo+PiBpZGVhLCBiZWNhdXNlIGl0IHBhc3NlcyBh IE5VTEwgcG9pbnRlciBjaGVjayBidXQgaXNuJ3QgYSB1c2FibGUgdmNwdS4gIEl0IGlzCj4+IGFs c28gdGhlIHJlYXNvbiBmb3IgdGhlICghaXNfaWRsZV9kb21haW4oZCkgfHwgdmNwdV9pZCkgcGFy dCBvZiB0aGUgZXhpc3RpbmcKPj4gc2FuaXR5IEJVR19PTigpLgo+Pgo+PiBOb3cgdGhhdCBkLT5t YXhfdmNwdXMgaXMgYXBwcm9wcmlhdGVseSBzZXQgdXAgYmVmb3JlIHZjcHVfY3JlYXRlKCkgaXMg Y2FsbGVkLAo+PiB3ZSBjYW4gcHJvcGVybHkgcmFuZ2UgY2hlY2sgdGhlIHJlcXVlc3RlZCB2Y3B1 X2lkLiAgRHJvcCB0aGUgQlVHX09OKCkgYW5kCj4+IHJlcGxhY2UgaXQgd2l0aCBjb2RlIHdoaWNo IGlzIHJ1bnRpbWUgc2FmZSBidXQgbm9uLWZhdGFsLgo+Pgo+PiBXaGlsZSB2MCBtdXN0IGJlIHRo ZSBmaXJzdCBhbGxvY2F0ZWQgdmNwdSBmb3IgZm9yX2VhY2hfdmNwdSgpIHRvIHdvcmssIGl0Cj4+ IGlzbid0IGEgcmVxdWlyZW1lbnQgZm9yIHRoZSB0aHJlYWRpbmcgdGhlIHZjcHUgaW50byB0aGUg bGlua2VkIGxpc3QsIHNvIHVwZGF0ZQo+PiB0aGUgdGhyZWFkaW5nIGNvZGUgdG8gYmUgbW9yZSBn ZW5lcmljLCBhbmQgYWRkIGEgY29tbWVudCBleHBsYWluaW5nIHdoeSB3ZQo+PiBuZWVkIHRvIHNl YXJjaCBmb3IgcHJldl9pZC4KPj4KPj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5k cmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KPj4gLS0tCj4+IENDOiBKYW4gQmV1bGljaCA8SkJldWxp Y2hAc3VzZS5jb20+Cj4+IENDOiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+PiBDQzog Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Cj4+IENDOiBTdGVmYW5vIFN0 YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4+IENDOiBKdWxpZW4gR3JhbGwgPGp1 bGllbi5ncmFsbEBhcm0uY29tPgo+PiAtLS0KPj4gIHhlbi9hcmNoL2FybS9zZXR1cC5jIHwgIDEg LQo+PiAgeGVuL2FyY2gveDg2L3NldHVwLmMgfCAgMSAtCj4+ICB4ZW4vY29tbW9uL2RvbWFpbi5j ICB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tCj4+ICAzIGZpbGVzIGNoYW5n ZWQsIDI4IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC9hcm0vc2V0dXAuYyBiL3hlbi9hcmNoL2FybS9zZXR1cC5jCj4+IGluZGV4IDAxYWFh YWIuLmQwNmFjNDAgMTAwNjQ0Cj4+IC0tLSBhL3hlbi9hcmNoL2FybS9zZXR1cC5jCj4+ICsrKyBi L3hlbi9hcmNoL2FybS9zZXR1cC5jCj4+IEBAIC03MDQsNyArNzA0LDYgQEAgdm9pZCBfX2luaXQg c3RhcnRfeGVuKHVuc2lnbmVkIGxvbmcgYm9vdF9waHlzX29mZnNldCwKPj4gICAgICBzZXRfcHJv Y2Vzc29yX2lkKDApOyAvKiBuZWVkZWQgZWFybHksIGZvciBzbXBfcHJvY2Vzc29yX2lkKCkgKi8K Pj4KPj4gICAgICBzZXRfY3VycmVudCgoc3RydWN0IHZjcHUgKikweGZmZmZmMDAwKTsgLyogZGVi dWcgc2FuaXR5ICovCj4+IC0gICAgaWRsZV92Y3B1WzBdID0gY3VycmVudDsKPj4KPj4gICAgICBz ZXR1cF92aXJ0dWFsX3JlZ2lvbnMoTlVMTCwgTlVMTCk7Cj4+ICAgICAgLyogSW5pdGlhbGl6ZSB0 cmFwcyBlYXJseSBhbGxvdyB1cyB0byBnZXQgYmFja3RyYWNlIHdoZW4gYW4gZXJyb3Igb2NjdXJy ZWQgKi8KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zZXR1cC5jIGIveGVuL2FyY2gveDg2 L3NldHVwLmMKPj4gaW5kZXggYTJmMjJhMS4uNWUxZThhZSAxMDA2NDQKPj4gLS0tIGEveGVuL2Fy Y2gveDg2L3NldHVwLmMKPj4gKysrIGIveGVuL2FyY2gveDg2L3NldHVwLmMKPj4gQEAgLTY5MSw3 ICs2OTEsNiBAQCB2b2lkIF9faW5pdCBub3JldHVybiBfX3N0YXJ0X3hlbih1bnNpZ25lZCBsb25n IG1iaV9wKQo+Pgo+PiAgICAgIHNldF9wcm9jZXNzb3JfaWQoMCk7Cj4+ICAgICAgc2V0X2N1cnJl bnQoSU5WQUxJRF9WQ1BVKTsgLyogZGVidWcgc2FuaXR5LiAqLwo+PiAtICAgIGlkbGVfdmNwdVsw XSA9IGN1cnJlbnQ7Cj4geGVuL2FyY2gveDg2L3Rib290LmM6dGJvb3Rfc2h1dGRvd24oKSBoYXM6 Cj4gICAgIGlmICggaWRsZV92Y3B1WzBdICE9IElOVkFMSURfVkNQVSApCj4gICAgICAgICB3cml0 ZV9wdGJhc2UoaWRsZV92Y3B1WzBdKTsKPgo+IFdpdGggeW91ciBjaGFuZ2UsIHRoaXMgc2hvdWxk IGJlIHVwZGF0ZSB0byBjaGVjayBmb3Igbm9uLU5VTEwuCgpPaCAtIHZlcnkgZ29vZCBjYXRjaC7C oCBUaGFua3MuCgpMb29raW5nIGF0IHRoZSBjb2RlLCBpZGVhbGx5IGl0IHdvdWxkIGNoYW5nZSB0 bwp3cml0ZV9jcjMoaWRsZV9wZ190YWJsZSksIGJ1dCB0aGF0IGlzbid0IGdvaW5nIHRvIGluY2x1 ZGUgdGhlIGFkZGl0aW9uYWwKQ1I0IGNoYW5nZXMuwqAgTGVhdmluZyB0aGlzIGluIHRoaXMgZm9y bSAod2l0aCBhIE5VTEwpIGNoZWNrIGlzIHByb2JhYmx5CmJlc3QuCgp+QW5kcmV3CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnBy b2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs