From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E941EC43461 for ; Sat, 17 Apr 2021 09:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3312613C7 for ; Sat, 17 Apr 2021 09:27:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235945AbhDQJ14 (ORCPT ); Sat, 17 Apr 2021 05:27:56 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:16597 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbhDQJ1u (ORCPT ); Sat, 17 Apr 2021 05:27:50 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FMnjW26hXz17Qt9; Sat, 17 Apr 2021 17:25:03 +0800 (CST) Received: from [10.174.185.179] (10.174.185.179) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Sat, 17 Apr 2021 17:27:13 +0800 Subject: Re: [PATCH v19 4/7] time: Add mechanism to recognize clocksource in time_get_snapshot To: Marc Zyngier CC: , , , , , , , , , , , , , , , , , , , References: <20210330145430.996981-1-maz@kernel.org> <20210330145430.996981-5-maz@kernel.org> From: Zenghui Yu Message-ID: <6e5fb440-156d-2b18-b3cd-89b1a09b0239@huawei.com> Date: Sat, 17 Apr 2021 17:27:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20210330145430.996981-5-maz@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.185.179] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/3/30 22:54, Marc Zyngier wrote: > - u64 cycles; > - ktime_t real; > - ktime_t raw; > - unsigned int clock_was_set_seq; > - u8 cs_was_changed_seq; > + u64 cycles; > + ktime_t real; > + ktime_t raw; > + enum clocksource_ids cs_id; nit: worth adding a description for it (on top of the structure)? > + unsigned int clock_was_set_seq; > + u8 cs_was_changed_seq; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D74C433ED for ; Sat, 17 Apr 2021 09:27:35 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 7068F611ED for ; Sat, 17 Apr 2021 09:27:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7068F611ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D6A384B351; Sat, 17 Apr 2021 05:27:33 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5HNUIqh9cfBe; Sat, 17 Apr 2021 05:27:30 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 06DF14B30D; Sat, 17 Apr 2021 05:27:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DF0384B346 for ; Sat, 17 Apr 2021 05:27:27 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z6nDQbha9d8L for ; Sat, 17 Apr 2021 05:27:25 -0400 (EDT) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id AD36A4B30D for ; Sat, 17 Apr 2021 05:27:25 -0400 (EDT) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FMnjW26hXz17Qt9; Sat, 17 Apr 2021 17:25:03 +0800 (CST) Received: from [10.174.185.179] (10.174.185.179) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Sat, 17 Apr 2021 17:27:13 +0800 Subject: Re: [PATCH v19 4/7] time: Add mechanism to recognize clocksource in time_get_snapshot To: Marc Zyngier References: <20210330145430.996981-1-maz@kernel.org> <20210330145430.996981-5-maz@kernel.org> From: Zenghui Yu Message-ID: <6e5fb440-156d-2b18-b3cd-89b1a09b0239@huawei.com> Date: Sat, 17 Apr 2021 17:27:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20210330145430.996981-5-maz@kernel.org> Content-Language: en-US X-Originating-IP: [10.174.185.179] X-CFilter-Loop: Reflected Cc: kernel-team@android.com, lorenzo.pieralisi@arm.com, justin.he@arm.com, kvm@vger.kernel.org, netdev@vger.kernel.org, richardcochran@gmail.com, yangbo.lu@nxp.com, sudeep.holla@arm.com, steven.price@arm.com, Andre.Przywara@arm.com, john.stultz@linaro.org, linux-arm-kernel@lists.infradead.org, seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2021/3/30 22:54, Marc Zyngier wrote: > - u64 cycles; > - ktime_t real; > - ktime_t raw; > - unsigned int clock_was_set_seq; > - u8 cs_was_changed_seq; > + u64 cycles; > + ktime_t real; > + ktime_t raw; > + enum clocksource_ids cs_id; nit: worth adding a description for it (on top of the structure)? > + unsigned int clock_was_set_seq; > + u8 cs_was_changed_seq; _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A78DC433ED for ; Sat, 17 Apr 2021 09:29:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1E58611AF for ; Sat, 17 Apr 2021 09:29:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1E58611AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5bzDnLr8vEPq/jLy1C30efUJI/TkD74KBOlp0sYQDlM=; b=Q1dnfqI39EM/h0h0zRyOn74Af E3VVTpk7S0RJDtnRL/qVFieq13Wn5TAT0vh1I1geZE3hR9ZXOKm/BVn73CvLO/DZroOdKBpoW6N+C /DVV1q2/deQl+1VgOryKSCzkvXbtnGTPGClD0vbvQU5dJ/6LxEn5TE5q3mU5qYno9LzHC5xpHbA1F qL7LsNrSXBrHIbVgfQDCaMQlUKci/S/woAU11MPga6twiLjVQCPVQ1lh+rxBr8zA8j72OAK+nb16S hpc9NY59YA9AEZKJN46RvpXQBfVGm9t1peeYUWHQKZ8RlcXrmccM6fVdveoV/nllLceeQHz7b9qhx I6bunae8g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXhEr-004slA-CO; Sat, 17 Apr 2021 09:27:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXhEk-004skX-UA for linux-arm-kernel@desiato.infradead.org; Sat, 17 Apr 2021 09:27:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=huypl7LViBwmDvCj8iCuUKGc5zWpZEZmvUVLCWwKtd0=; b=ad6h62B0LdW39atlbaGXh6UwDP sBfYxxx8U9ARN73aRH16QYd1InV8V9GEL7vK9uAQ01kZby4KN/2Bixney07DgQDRAwXVfVW2NV067 nRW+VcSJA1+a5n5znMTY4a/yOZQoDgqAo894XQaAIL1DxrNqICifv6i7DyNj0ywcFCAcyXhxgWb2K bFelvqTSVVr3P+kzbiPbj3YmIxP6eyJwRaOQd2gOKvUu1B+Uaa9/3MXE+aYkzXCBCIcIZ8/CUOrsw 3p2zsXJPQL/vhZ4wlY0zCjrqVVdgEVEPO1CHlNZtnoD2CULf9LxNHz7hKgJSe4SEWS+8eXNd3EAIx kMwGWsuA==; Received: from szxga04-in.huawei.com ([45.249.212.190]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXhEe-009xLj-CS for linux-arm-kernel@lists.infradead.org; Sat, 17 Apr 2021 09:27:33 +0000 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FMnjW26hXz17Qt9; Sat, 17 Apr 2021 17:25:03 +0800 (CST) Received: from [10.174.185.179] (10.174.185.179) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Sat, 17 Apr 2021 17:27:13 +0800 Subject: Re: [PATCH v19 4/7] time: Add mechanism to recognize clocksource in time_get_snapshot To: Marc Zyngier CC: , , , , , , , , , , , , , , , , , , , References: <20210330145430.996981-1-maz@kernel.org> <20210330145430.996981-5-maz@kernel.org> From: Zenghui Yu Message-ID: <6e5fb440-156d-2b18-b3cd-89b1a09b0239@huawei.com> Date: Sat, 17 Apr 2021 17:27:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20210330145430.996981-5-maz@kernel.org> Content-Language: en-US X-Originating-IP: [10.174.185.179] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210417_022728_624136_B37878AD X-CRM114-Status: UNSURE ( 5.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/3/30 22:54, Marc Zyngier wrote: > - u64 cycles; > - ktime_t real; > - ktime_t raw; > - unsigned int clock_was_set_seq; > - u8 cs_was_changed_seq; > + u64 cycles; > + ktime_t real; > + ktime_t raw; > + enum clocksource_ids cs_id; nit: worth adding a description for it (on top of the structure)? > + unsigned int clock_was_set_seq; > + u8 cs_was_changed_seq; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel