From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"Lin, Mengdong" <mengdong.lin@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"mengdong.lin" <mengdong.lin@linux.intel.com>
Subject: Re: [PATCH][alsa-lib] topology: fix unused-const-variable warning
Date: Sat, 24 Dec 2016 00:34:29 +0900 [thread overview]
Message-ID: <6e6431cf-b498-f79b-f4dc-ab3aa78f6e1f@sakamocchi.jp> (raw)
In-Reply-To: <1482506626.24233.71.camel@loki>
On 2016年12月24日 00:23, Liam Girdwood wrote:
> On Sat, 2016-12-24 at 00:08 +0900, Takashi Sakamoto wrote:
>> On 2016年12月23日 23:48, Lin, Mengdong wrote:
>>>> -----Original Message-----
>>>> From: alsa-devel-bounces@alsa-project.org [mailto:alsa-devel-
>>>> bounces@alsa-project.org] On Behalf Of Liam Girdwood
>>>> Sent: Friday, December 23, 2016 4:49 PM
>>>>
>>>> This looks fine by me, Mengdong is this still unused or is it needed by a
>>>> future patch ?
>>>
>>> Hi Liam,
>>>
>>> This "widget_control_map" is still unused now.
>>>
>>> Could you remember why we define this map in the early phase?
>>> I guess previously we want to distinguish stand-alone controls from controls embedded in widgets. But now we process them in the same way, both in user space and kernel.
>>>
>>> So I feel we can remove this structure.
>>
>> Additionally, would you check this post to fix some warnings which you
>> added into alsa-lib, please.
>> [alsa-devel] [PATCH][alsa-lib] topology: fix sign-compare warning
>> introduced to set_link_hw_config() and tplg_add_link_object()
>> http://mailman.alsa-project.org/pipermail/alsa-devel/2016-December/115896.html
>>
>>
>
> Both look good to me. Apologies that I missed them.
>
> You may want to resend them both with my Ack (maybe wait for until after
> Christmas though).
No need. Iwai-san already reviewed them. Next year, I'll request him to
apply them.
http://mailman.alsa-project.org/pipermail/alsa-devel/2016-December/115725.html
I request Mengdong-Lin to care of compiler warnings again. Her patches
frequently bring this kind of mistakes, and I have no motivations to fix
them anymore.
Thanks
Takashi Sakamoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2016-12-23 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 15:44 [PATCH][alsa-lib] topology: fix unused-const-variable warning Takashi Sakamoto
2016-12-17 0:39 ` Takashi Sakamoto
2016-12-23 8:49 ` Liam Girdwood
2016-12-23 14:48 ` Lin, Mengdong
2016-12-23 15:08 ` Takashi Sakamoto
2016-12-23 15:23 ` Liam Girdwood
2016-12-23 15:34 ` Takashi Sakamoto [this message]
2016-12-27 9:57 ` Lin, Mengdong
2017-01-02 14:22 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e6431cf-b498-f79b-f4dc-ab3aa78f6e1f@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=mengdong.lin@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.