From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbeADJoQ (ORCPT + 1 other); Thu, 4 Jan 2018 04:44:16 -0500 Received: from mout.web.de ([212.227.17.11]:65065 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394AbeADJoN (ORCPT ); Thu, 4 Jan 2018 04:44:13 -0500 Subject: Re: Coccinelle: Rename the script for a transformation of memory allocations To: Julia Lawall , cocci@systeme.lip6.fr Cc: Gilles Muller , Himanshu Jha , Masahiro Yamada , Michal Marek , Nicolas Palix , Amitoj Kaur Chawla , LKML , kernel-janitors@vger.kernel.org References: <6423882b-20df-61fd-d7c6-ac1bb4ec891d@users.sourceforge.net> <2ca7ce82-3223-9733-9aa5-6061c79ff804@users.sourceforge.net> <7490d0cb-4246-8e10-05cd-6219b58c4f14@users.sourceforge.net> From: SF Markus Elfring Message-ID: <6e685bda-6f8f-4adf-4b0c-bf93b59981c2@users.sourceforge.net> Date: Thu, 4 Jan 2018 10:43:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:bACvuxbs6PCMPyRw8N5PQ3qTk4fY+Hd5SLlx/u0sesU+sLYP9Ag U4aBRn20RFKTAm4xasKM8FLWZLBsIdxlHOS55mhUqGICzfYkmx7wxySEBxAgHCXAAYBAImL XysHmco4/VaZ0qTJlQweXx9bBPuzTQ9ONkGlNvcO0SWa6oWnIhOYVdo3lFn/Z29UqXL1QEA Zhb6fRX75Rz3LkYa14dHA== X-UI-Out-Filterresults: notjunk:1;V01:K0:kFRm1sqkWdA=:a0Z013wcejGpJCOtvapyVg 0Nu4DPcWrpnQv71hz92nRFKmyYQULZWRex7561JNcR3EnXs1lfYJ7661Dx6VrrwlXu+ffNSYd hDahjwNQEfkpI5W7XDdKsMsLO9PaG2tHJxwk54N3GVInHIoXmkCQT84VgMi/q+CTDILQhG4d6 5dpo+bAOSUTGE7kB1qo+J2yyMXzUdhDyqBk9koB4PIJoeqwGrFWXDtMszzb7QjloQFsiGgYRh ggUyerBARMdLkoJ2v0M2y8L3G8x/h9VEdOC4is3rEdw26SBeX38PKmbn5GLINeE/Nty6OCd28 OqTRPxK4AyVWpwG/tg+GW2omVXv+pKfx8KCNXdagLnAghPH/eF71/ehNvMtS2iTRDwCN600Jf r8m+9kR5fdYLaQFEfuYm90lEr3U9x5OMy6U8hqhB8sOiXt38o6Vr//9h7PDKPzDAG6E3QEOYA 5ieGVdZ4N1hc1DX2btYGqLX/OL+0V9aggnDPgmq3xVqPCOuq3e4X8eR2C1S9sZ39hz23scYb8 JmyfVXAsSaZAXEdQ89UZyhQ/oM/ceVLfm4ApbeNDRgNTWLE37sRDES5dxVTzqbYezfFbu1WoN l4WK5WcmKg7rN6x+qOGyyF1EUslP7g8QS3RK6OZUWhL0Sh0fzry7P3e6/ckZuVqzAQtLiTlkN 98F8vJ/DSd3WD3MePOaFVjI1fXlhKF6gsTog4nEENyqhPz3VXC/9h2aT1g28V0JtYY68HAVUB 9zSS6lhzuZHRJc4PV4L4JQVL0wWIvWXeoyODDdGxby5cuSRGLOILNUg7DGubdRJHYMfr+cyt6 K+kAqvFyTpmRO4wIHjKyq10AyMXl8UG3wAOHMWuODXIwg24x/c= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: >> Would you find the file name selection “zalloc-extra_changes1.cocci” acceptable? > > No. Next try then … > I do't know what the extra changes are This script for the semantic patch language was designed in the way that more source code would be adjusted (or just reformatted) than I see as an essential transformation for the replacement of function calls in the shown case. Example: … ( - x = kmalloc(E1,E2); + x = kzalloc(E1,E2); | … We are discussing consequences from the specification of a different change granularity for a while. I hope that another SmPL script variant could be integrated which will work with a higher precision then so that involved software developers can choose the preferred transformation approach also on their own. > and I don't know what the number 1 means. How do you think about to start with numbering for subsequent SmPL scripts? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 04 Jan 2018 09:43:59 +0000 Subject: Re: Coccinelle: Rename the script for a transformation of memory allocations Message-Id: <6e685bda-6f8f-4adf-4b0c-bf93b59981c2@users.sourceforge.net> List-Id: References: <6423882b-20df-61fd-d7c6-ac1bb4ec891d@users.sourceforge.net> <2ca7ce82-3223-9733-9aa5-6061c79ff804@users.sourceforge.net> <7490d0cb-4246-8e10-05cd-6219b58c4f14@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Julia Lawall , cocci@systeme.lip6.fr Cc: Gilles Muller , Himanshu Jha , Masahiro Yamada , Michal Marek , Nicolas Palix , Amitoj Kaur Chawla , LKML , kernel-janitors@vger.kernel.org >> Would you find the file name selection “zalloc-extra_changes1.cocci” acceptable? > > No. Next try then … > I do't know what the extra changes are This script for the semantic patch language was designed in the way that more source code would be adjusted (or just reformatted) than I see as an essential transformation for the replacement of function calls in the shown case. Example: … ( - x = kmalloc(E1,E2); + x = kzalloc(E1,E2); | … We are discussing consequences from the specification of a different change granularity for a while. I hope that another SmPL script variant could be integrated which will work with a higher precision then so that involved software developers can choose the preferred transformation approach also on their own. > and I don't know what the number 1 means. How do you think about to start with numbering for subsequent SmPL scripts? Regards, Markus