From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F1CC4361A for ; Sat, 5 Dec 2020 10:07:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7397222D6F for ; Sat, 5 Dec 2020 10:07:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7397222D6F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klUTM-0002AW-63 for qemu-devel@archiver.kernel.org; Sat, 05 Dec 2020 05:07:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klUSY-0001k5-B9 for qemu-devel@nongnu.org; Sat, 05 Dec 2020 05:06:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:58582) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klUSW-0002Tg-EZ for qemu-devel@nongnu.org; Sat, 05 Dec 2020 05:06:34 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 75C77AC90; Sat, 5 Dec 2020 10:06:30 +0000 (UTC) Subject: Re: [RFC v7 15/22] cpu: Move tlb_fill to tcg_ops To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Eduardo Habkost References: <20201130023535.16689-1-cfontana@suse.de> <20201130023535.16689-16-cfontana@suse.de> <4c7fe436-7c2d-e55d-1139-8aa30e91965f@redhat.com> <20201204173703.GQ3836@habkost.net> <6233d4db-546a-2ec3-376d-154af8ed2cdb@redhat.com> From: Claudio Fontana Message-ID: <6e6e83c2-080b-c5e1-a8a4-2900e49ce384@suse.de> Date: Sat, 5 Dec 2020 11:06:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Stefano Stabellini , Colin Xu , Paul Durrant , Jason Wang , Marcelo Tosatti , Richard Henderson , qemu-devel@nongnu.org, Peter Xu , Dario Faggioli , Roman Bolshakov , "Emilio G . Cota" , haxm-team@intel.com, Cameron Esfahani , Anthony Perard , Paolo Bonzini , Sunil Muthuswamy , Bruce Rogers , Olaf Hering , Wenchao Wang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/4/20 8:27 PM, Philippe Mathieu-Daudé wrote: > On 12/4/20 7:14 PM, Claudio Fontana wrote: >> On 12/4/20 7:00 PM, Philippe Mathieu-Daudé wrote: >>> On 12/4/20 6:37 PM, Eduardo Habkost wrote: >>>> On Fri, Dec 04, 2020 at 06:14:07PM +0100, Philippe Mathieu-Daudé wrote: >>>>> On 11/30/20 3:35 AM, Claudio Fontana wrote: >>>>>> From: Eduardo Habkost >>>>>> >>>>>> Signed-off-by: Eduardo Habkost >>>>>> --- >>>>>> accel/tcg/cputlb.c | 6 +++--- >>>>>> accel/tcg/user-exec.c | 6 +++--- >>>>>> include/hw/core/cpu.h | 9 --------- >>>>>> include/hw/core/tcg-cpu-ops.h | 12 ++++++++++++ >>>>>> target/alpha/cpu.c | 2 +- >>>>>> target/arm/cpu.c | 2 +- >>>>>> target/avr/cpu.c | 2 +- >>>>>> target/cris/cpu.c | 2 +- >>>>>> target/hppa/cpu.c | 2 +- >>>>>> target/i386/tcg-cpu.c | 2 +- >>>>>> target/lm32/cpu.c | 2 +- >>>>>> target/m68k/cpu.c | 2 +- >>>>>> target/microblaze/cpu.c | 2 +- >>>>>> target/mips/cpu.c | 2 +- >>>>>> target/moxie/cpu.c | 2 +- >>>>>> target/nios2/cpu.c | 2 +- >>>>>> target/openrisc/cpu.c | 2 +- >>>>>> target/ppc/translate_init.c.inc | 2 +- >>>>>> target/riscv/cpu.c | 2 +- >>>>>> target/rx/cpu.c | 2 +- >>>>>> target/s390x/cpu.c | 2 +- >>>>>> target/sh4/cpu.c | 2 +- >>>>>> target/sparc/cpu.c | 2 +- >>>>>> target/tilegx/cpu.c | 2 +- >>>>>> target/tricore/cpu.c | 2 +- >>>>>> target/unicore32/cpu.c | 2 +- >>>>>> target/xtensa/cpu.c | 2 +- >>>>>> 27 files changed, 41 insertions(+), 38 deletions(-) >>>>> >>>>> With cc->tcg_ops.* guarded with #ifdef CONFIG_TCG: >>>>> Reviewed-by: Philippe Mathieu-Daudé >>>> >>>> Thanks! >>>> >>>> Are the #ifdefs a hard condition for your Reviewed-by? >>> >>> No, as you said, this is fine as a first step, so you can >>> include them. >>> >>>> Even if we agree #ifdef CONFIG_TCG is the way to go, I don't >>>> think this should block a series that's a step in the right >>>> direction. It can be done in a separate patch. >>>> >>>> (Unless the lack of #ifdef introduces regressions, of course) >>> >>> I'm worried about the +system -tcg build configuration. >>> >>> s390x is the only target testing for such regressions >>> (see "[s390x] Clang (disable-tcg)" on Travis-CI. >>> >> >> which exact configure options are concerned about? >> >> --disable-tcg --enable-kvm --target="*-system"? >> >> Or something else? > > Basically --disable-tcg --enable-$ACCEL [--enable-$ACCEL] > >> >> this is something I am testing (and found the issues). >> >> I am currently testing (and a result fixing) for each patch: >> >> --disable-tcg --enable-kvm > > This one is meaningful to check the host, so I run it on: > - x86 [ok] > - s390x [ok] > - aarch64 [done, waiting for your effort before respining] > - ppc64 [done, I was postponing the series submission waiting > for aa64 to be merged, but I might go back to it as > aa64 is taking too long]. > - mips: no hardware access > >> --enable-tcg --disable-kvm >> --enable-tcg --enable-kvm --enable-hax >> --disable-system > > I also use: > > * --disable-tcg --disable-kvm --enable-xen > [x86 host works] > [aa64 host needs Alex Bennée patches] > > * --disable-tcg --disable-system --disable-user --enable-tools > > * --disable-system --static --disable-capstone > (experimental, not supported, don't waste time with it). > > The most useful is --enable-tools with all accelerators disabled, > as it quickly triggers linking errors when you miss-place a > handler between #ifdefs. Hi, seems good, however if I configure with --disable-tcg --disable-kvm --disable-hax --enable-tools make works fine, while make check errors out with 'qemu' not found. Running test fp-test-rem Running test fp-test-sqrt Running test QAPI schema regression tests check: qemu not found make: *** [/dev/shm/cfontana/qemu/tests/Makefile.include:144: check-block] Error 1 make: *** Waiting for unfinished jobs.... Maybe something to improve in the build system? I'd expect only the tools check to run (if any), if only tools are built... Thanks, Ciao Claudio > >> With targets (when compatible): >> TARGET_LIST="x86_64-softmmu,x86_64-linux-user,arm-softmmu,arm-linux-user,aarch64-softmmu,aarch64-linux-user,s390x-softmmu,s390x-linux-user" > > "first class KVM users" include PPC64 too. > >> >> and yes, should offload much of this to CI.. >> >> Ciao, >> >> Claudio >> > >