From: james.smart@broadcom.com (James Smart)
Subject: [PATCH 4.15-rc 2/3] nvme-core/loop/rdma: Host delete_work and reset_work on system workqueues
Date: Fri, 22 Dec 2017 09:39:14 -0800 [thread overview]
Message-ID: <6e87270a-ee67-4b93-e2c3-b977400f9e79@broadcom.com> (raw)
In-Reply-To: <20171221100752.18386-3-sagi@grimberg.me>
On 12/21/2017 2:07 AM, Sagi Grimberg wrote:
> From: Roy Shterman <roys at lightbitslabs.com>
>
> We need to ensure that delete_work will be hosted on a different
> workqueue than all the works we flush or cancel from it.
> Otherwise we may hit a circular dependency warning [1].
>
> Also, given that delete_work flushes reset_work, host reset_work
> on system_wq and delete_work on system_long_wq. In addition,
> fix the flushing in the individual drivers to flush system_long_wq
> when draining queued deletes.
>
>
Any particular reason you didn't do similar mods for the fc transport ?
-- james
next prev parent reply other threads:[~2017-12-22 17:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 10:07 [PATCH 4.15-rc 0/3] few fabrics fixes targeted to 4.15 Sagi Grimberg
2017-12-21 10:07 ` [PATCH 4.15-rc 1/3] nvme-core: Don't set nvme_wq as MEM_RECLAIM Sagi Grimberg
2017-12-21 10:17 ` Christoph Hellwig
2017-12-21 10:41 ` Sagi Grimberg
2017-12-21 13:00 ` Christoph Hellwig
2017-12-21 13:17 ` Sagi Grimberg
2017-12-21 13:54 ` Christoph Hellwig
2017-12-21 14:17 ` Sagi Grimberg
2017-12-29 9:35 ` Christoph Hellwig
2017-12-31 9:51 ` Sagi Grimberg
2017-12-21 10:07 ` [PATCH 4.15-rc 2/3] nvme-core/loop/rdma: Host delete_work and reset_work on system workqueues Sagi Grimberg
2017-12-21 10:25 ` Christoph Hellwig
2017-12-21 10:43 ` Sagi Grimberg
2017-12-21 13:00 ` Christoph Hellwig
2017-12-22 17:39 ` James Smart [this message]
2017-12-24 8:55 ` Sagi Grimberg
2017-12-21 10:07 ` [PATCH 4.15-rc 3/3] nvme-fabrics: Protect against module unload during create_ctrl Sagi Grimberg
2017-12-21 10:25 ` Christoph Hellwig
2017-12-21 18:31 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e87270a-ee67-4b93-e2c3-b977400f9e79@broadcom.com \
--to=james.smart@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.