From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753901AbdGJMYX (ORCPT ); Mon, 10 Jul 2017 08:24:23 -0400 Received: from 7of9.schinagl.nl ([62.251.20.244]:33370 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753829AbdGJMYW (ORCPT ); Mon, 10 Jul 2017 08:24:22 -0400 Subject: Re: [linux-sunxi] [PATCH v5 5/6] ARM: sun7i: Convert to CCU To: Maxime Ripard References: <2ff8930c51b90a0bb875ecc6c4737f44b3314e7f.1499197129.git-series.plaes@plaes.org> <4091e67f-6207-26ef-85f1-e9ff509dd3b7@schinagl.nl> <20170710115519.sddpeyvbxq5llunf@flea> Cc: plaes@plaes.org, Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Chen-Yu Tsai , Russell King , Philipp Zabel , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Jonathan Liu From: Olliver Schinagl Message-ID: <6e8b7b1d-c14c-d5fa-a9ef-71dae239fd64@schinagl.nl> Date: Mon, 10 Jul 2017 14:24:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170710115519.sddpeyvbxq5llunf@flea> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On 10-07-17 13:55, Maxime Ripard wrote: > On Mon, Jul 10, 2017 at 01:23:51PM +0200, Olliver Schinagl wrote: >> Hi Pleas, >> >> On 04-07-17 22:05, Priit Laes wrote: >>> Convert sun7i-a20.dtsi to new CCU driver. >>> >>> Tested on Cubietruck. >>> >>> Signed-off-by: Priit Laes >>> --- >>> arch/arm/boot/dts/sun7i-a20.dtsi | 719 +++----------------------------- >>> 1 file changed, 84 insertions(+), 635 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi >>> index 96bee77..a5ca5a8 100644 >>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi >>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi >>> @@ -46,8 +46,6 @@ >>> >>> #include >>> #include >>> - >>> -#include >>> #include >> I had to add these includes here to make this all work: > > That's unlikely, none of the defines are used in this patch. > My appologies you are right. I needed to add them to get this ontop of your DRM stack working for the A20. I looked at my local diff and responded a bit overeagerly probably. Nice catch! Olliver > Maxime > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olliver Schinagl Subject: Re: [linux-sunxi] [PATCH v5 5/6] ARM: sun7i: Convert to CCU Date: Mon, 10 Jul 2017 14:24:17 +0200 Message-ID: <6e8b7b1d-c14c-d5fa-a9ef-71dae239fd64@schinagl.nl> References: <2ff8930c51b90a0bb875ecc6c4737f44b3314e7f.1499197129.git-series.plaes@plaes.org> <4091e67f-6207-26ef-85f1-e9ff509dd3b7@schinagl.nl> <20170710115519.sddpeyvbxq5llunf@flea> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170710115519.sddpeyvbxq5llunf@flea> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Ripard Cc: plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org, Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Chen-Yu Tsai , Russell King , Philipp Zabel , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Jonathan Liu List-Id: devicetree@vger.kernel.org Hi Maxime, On 10-07-17 13:55, Maxime Ripard wrote: > On Mon, Jul 10, 2017 at 01:23:51PM +0200, Olliver Schinagl wrote: >> Hi Pleas, >> >> On 04-07-17 22:05, Priit Laes wrote: >>> Convert sun7i-a20.dtsi to new CCU driver. >>> >>> Tested on Cubietruck. >>> >>> Signed-off-by: Priit Laes >>> --- >>> arch/arm/boot/dts/sun7i-a20.dtsi | 719 +++----------------------------- >>> 1 file changed, 84 insertions(+), 635 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi >>> index 96bee77..a5ca5a8 100644 >>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi >>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi >>> @@ -46,8 +46,6 @@ >>> >>> #include >>> #include >>> - >>> -#include >>> #include >> I had to add these includes here to make this all work: > > That's unlikely, none of the defines are used in this patch. > My appologies you are right. I needed to add them to get this ontop of your DRM stack working for the A20. I looked at my local diff and responded a bit overeagerly probably. Nice catch! Olliver > Maxime > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: oliver@schinagl.nl (Olliver Schinagl) Date: Mon, 10 Jul 2017 14:24:17 +0200 Subject: [linux-sunxi] [PATCH v5 5/6] ARM: sun7i: Convert to CCU In-Reply-To: <20170710115519.sddpeyvbxq5llunf@flea> References: <2ff8930c51b90a0bb875ecc6c4737f44b3314e7f.1499197129.git-series.plaes@plaes.org> <4091e67f-6207-26ef-85f1-e9ff509dd3b7@schinagl.nl> <20170710115519.sddpeyvbxq5llunf@flea> Message-ID: <6e8b7b1d-c14c-d5fa-a9ef-71dae239fd64@schinagl.nl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Maxime, On 10-07-17 13:55, Maxime Ripard wrote: > On Mon, Jul 10, 2017 at 01:23:51PM +0200, Olliver Schinagl wrote: >> Hi Pleas, >> >> On 04-07-17 22:05, Priit Laes wrote: >>> Convert sun7i-a20.dtsi to new CCU driver. >>> >>> Tested on Cubietruck. >>> >>> Signed-off-by: Priit Laes >>> --- >>> arch/arm/boot/dts/sun7i-a20.dtsi | 719 +++----------------------------- >>> 1 file changed, 84 insertions(+), 635 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi >>> index 96bee77..a5ca5a8 100644 >>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi >>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi >>> @@ -46,8 +46,6 @@ >>> >>> #include >>> #include >>> - >>> -#include >>> #include >> I had to add these includes here to make this all work: > > That's unlikely, none of the defines are used in this patch. > My appologies you are right. I needed to add them to get this ontop of your DRM stack working for the A20. I looked at my local diff and responded a bit overeagerly probably. Nice catch! Olliver > Maxime >