From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQCc5-0006xH-Oy for qemu-devel@nongnu.org; Wed, 28 Jun 2017 09:02:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQCc4-0008Sb-UA for qemu-devel@nongnu.org; Wed, 28 Jun 2017 09:02:33 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:2606 helo=relay.sw.ru) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dQCc4-0008SA-JG for qemu-devel@nongnu.org; Wed, 28 Jun 2017 09:02:32 -0400 References: <20170628120530.31251-1-vsementsov@virtuozzo.com> <20170628120530.31251-14-vsementsov@virtuozzo.com> From: Vladimir Sementsov-Ogievskiy Message-ID: <6e99d1ce-a7e9-af1b-ec84-baae97f348df@virtuozzo.com> Date: Wed, 28 Jun 2017 16:02:17 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Qemu-devel] [PATCH v22 13/30] block: new bdrv_reopen_bitmaps_rw interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, armbru@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com It is interesting, but I see this problem only in your answers, in my letters I see this white-space on its place. 28.06.2017 15:36, Eric Blake wrote: > [meta-comment] > > On 06/28/2017 07:10 AM, Vladimir Sementsov-Ogievskiy wrote: >> 28.06.2017 15:05, Vladimir Sementsov-Ogievskiy wrote: >>> Add format driver handler, which should mark loaded read-only >>> bitmaps as 'IN_USE' in the image and unset read_only field in >>> corresponding BdrvDirtyBitmap's. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> Reviewed-by: John Snow > Your original message had spaces before '<' in the email addresses, but > it got lost here... > >> >> Forgot to add: >> >> Reviewed-by: Max Reitz > ...this one also lacks the space. I'm not sure if git cares, but it may > be worth investigating why your mailer eats the space when you reply > manually rather than sending via git; and for consistency, it is worth > keeping the space (for example, we like to grep 'git log' for learning > how active various contributors are, and having a consistent usage of > space before < in an email address can make the task easier). > -- Best regards, Vladimir