From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH] compat: merge compat library into EAL Date: Thu, 10 Jan 2019 11:31:31 +0000 Message-ID: <6e9e1548-808d-cb86-a304-c8b8ac4491f4@intel.com> References: <20190110111104.56464-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Marchand , Thomas Monjalon To: Bruce Richardson , dev@dpdk.org Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 570B31B5FD for ; Thu, 10 Jan 2019 12:31:34 +0100 (CET) In-Reply-To: <20190110111104.56464-1-bruce.richardson@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10-Jan-19 11:11 AM, Bruce Richardson wrote: > Since compat library is only a single header, we can easily move it into > the EAL common headers instead of tracking it separately. The downside of > this is that it becomes a little more difficult to have any libs that are > built before EAL depend on it. Thankfully, this is not the case, so there > are no big complications to the move. > > However, to ensure that we don't later hit problems later with this, we can > add EAL common headers folder to the global include list in the meson build > which means that all common headers can be safely used by all libraries, no > matter what their build order. > > Signed-off-by: Bruce Richardson > --- Presumably this makes my patch obsolete? -- Thanks, Anatoly