From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case Date: Wed, 12 Sep 2018 11:51:50 +0000 Message-ID: <6ea95d8032c94db79cee98c62dbe1d56@AMSPEX02CL03.citrite.net> References: <5B98D7CF02000078001E7AEA@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1g03gX-0008Js-WD for xen-devel@lists.xenproject.org; Wed, 12 Sep 2018 11:51:54 +0000 In-Reply-To: <5B98D7CF02000078001E7AEA@prv1-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: 'Jan Beulich' , xen-devel Cc: Andrew Cooper List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEphbiBCZXVsaWNoIFttYWlsdG86 SkJldWxpY2hAc3VzZS5jb21dCj4gU2VudDogMTIgU2VwdGVtYmVyIDIwMTggMTA6MTAKPiBUbzog eGVuLWRldmVsIDx4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc+Cj4gQ2M6IEFuZHJldyBD b29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+OyBQYXVsIER1cnJhbnQKPiA8UGF1bC5E dXJyYW50QGNpdHJpeC5jb20+Cj4gU3ViamVjdDogW1BBVENIXSB4ODYvSFZNOiBjb3JyZWN0IGh2 bWVtdWxfbWFwX2xpbmVhcl9hZGRyKCkgZm9yIG11bHRpLQo+IHBhZ2UgY2FzZQo+IAo+IFRoZSBm dW5jdGlvbiBkb2VzIHR3byB0cmFuc2xhdGlvbnMgaW4gb25lIGdvIGZvciBhIHNpbmdsZSBndWVz dCBhY2Nlc3MuCj4gQW55IGZhaWx1cmUgb2YgdGhlIGZpcnN0IHRyYW5zbGF0aW9uIHN0ZXAgKGd1 ZXN0IGxpbmVhciAtPiBndWVzdAo+IHBoeXNpY2FsKSwgcmVzdWx0aW5nIGluICNQRiwgb3VnaHQg dG8gdGFrZSBwcmVjZWRlbmNlIG92ZXIgYW55IGZhaWx1cmUKPiBvZiB0aGUgc2Vjb25kIHN0ZXAg KGd1ZXN0IHBoeXNpY2FsIC0+IGhvc3QgcGh5c2ljYWwpLiBCYWlsIG91dCBvZiB0aGUKPiBsb29w IGVhcmx5IHNvbGVseSB3aGVuIHRyYW5zbGF0aW9uIHByb2R1Y2VzIEhWTVRSQU5TX2JhZF9saW5l YXJfdG9fZ2ZuLAo+IGFuZCByZWNvcmQgdGhlIG1vc3QgcmVsZXZhbnQgb2YgcGVyaGFwcyBtdWx0 aXBsZSBkaWZmZXJlbnQgZXJyb3JzCj4gb3RoZXJ3aXNlLiAoVGhlIGNob2ljZSBvZiBaRVJPX0JM T0NLX1BUUiBhcyBzZW50aW5lbCBpcyBhcmJpdHJhcnkuKQoKQ291bGQgd2UgaGF2ZSBjb21tZW50 IHBlcmhhcHMgc2F5aW5nIHdoYXQgdGhlIG9yZGVyIG9mIHJlbGV2YW5jZSBvZiB0aGUgZXJyb3Jz IGFyZT8gVGhlIGxvZ2ljIGluIHVwZGF0ZV9tYXBfZXJyKCkgYmVsb3cgaXMgYSBsaXR0bGUgaGFy ZCB0byBmb2xsb3cuCgogIFBhdWwKCj4gCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpi ZXVsaWNoQHN1c2UuY29tPgo+IAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vZW11bGF0ZS5jCj4g KysrIGIveGVuL2FyY2gveDg2L2h2bS9lbXVsYXRlLmMKPiBAQCAtNTMxLDYgKzUzMSwyMCBAQCBz dGF0aWMgaW50IGh2bWVtdWxfZG9fbW1pb19hZGRyKHBhZGRyX3QKPiAgICAgIHJldHVybiBodm1l bXVsX2RvX2lvX2FkZHIoMSwgbW1pb19ncGEsIHJlcHMsIHNpemUsIGRpciwgZGYsIHJhbV9ncGEp Owo+ICB9Cj4gCj4gK3N0YXRpYyB2b2lkICp1cGRhdGVfbWFwX2Vycih2b2lkICplcnIsIHZvaWQg Km5ldykKPiArewo+ICsgICAgaWYgKCBlcnIgPT0gWkVST19CTE9DS19QVFIgfHwgZXJyID09IEVS Ul9QVFIoflg4NkVNVUxfT0tBWSkgKQo+ICsgICAgICAgIHJldHVybiBuZXc7Cj4gKwo+ICsgICAg aWYgKCBuZXcgPT0gRVJSX1BUUih+WDg2RU1VTF9PS0FZKSApCj4gKyAgICAgICAgcmV0dXJuIGVy cjsKPiArCj4gKyAgICBpZiAoIGVyciA9PSBFUlJfUFRSKH5YODZFTVVMX1JFVFJZKSApCj4gKyAg ICAgICAgcmV0dXJuIG5ldzsKPiArCj4gKyAgICByZXR1cm4gZXJyOwo+ICt9Cj4gKwo+ICAvKgo+ ICAgKiBNYXAgdGhlIGZyYW1lKHMpIGNvdmVyaW5nIGFuIGluZGl2aWR1YWwgbGluZWFyIGFjY2Vz cywgZm9yIHdyaXRlYWJsZQo+ICAgKiBhY2Nlc3MuICBNYXkgcmV0dXJuIE5VTEwgZm9yIE1NSU8s IG9yIEVSUl9QVFIoflg4NkVNVUxfKikgZm9yIG90aGVyCj4gZXJyb3JzCj4gQEAgLTU0NCw3ICs1 NTgsNyBAQCBzdGF0aWMgdm9pZCAqaHZtZW11bF9tYXBfbGluZWFyX2FkZHIoCj4gICAgICBzdHJ1 Y3QgaHZtX2VtdWxhdGVfY3R4dCAqaHZtZW11bF9jdHh0KQo+ICB7Cj4gICAgICBzdHJ1Y3QgdmNw dSAqY3VyciA9IGN1cnJlbnQ7Cj4gLSAgICB2b2lkICplcnIsICptYXBwaW5nOwo+ICsgICAgdm9p ZCAqZXJyID0gWkVST19CTE9DS19QVFIsICptYXBwaW5nOwo+ICAgICAgdW5zaWduZWQgaW50IG5y X2ZyYW1lcyA9ICgobGluZWFyICsgYnl0ZXMgLSAhIWJ5dGVzKSA+PiBQQUdFX1NISUZUKSAtCj4g ICAgICAgICAgKGxpbmVhciA+PiBQQUdFX1NISUZUKSArIDE7Cj4gICAgICB1bnNpZ25lZCBpbnQg aTsKPiBAQCAtNjAwLDI3ICs2MTQsMjggQEAgc3RhdGljIHZvaWQgKmh2bWVtdWxfbWFwX2xpbmVh cl9hZGRyKAo+ICAgICAgICAgICAgICBnb3RvIG91dDsKPiAKPiAgICAgICAgICBjYXNlIEhWTVRS QU5TX2JhZF9nZm5fdG9fbWZuOgo+IC0gICAgICAgICAgICBlcnIgPSBOVUxMOwo+IC0gICAgICAg ICAgICBnb3RvIG91dDsKPiArICAgICAgICAgICAgZXJyID0gdXBkYXRlX21hcF9lcnIoZXJyLCBO VUxMKTsKPiArICAgICAgICAgICAgY29udGludWU7Cj4gCj4gICAgICAgICAgY2FzZSBIVk1UUkFO U19nZm5fcGFnZWRfb3V0Ogo+ICAgICAgICAgIGNhc2UgSFZNVFJBTlNfZ2ZuX3NoYXJlZDoKPiAt ICAgICAgICAgICAgZXJyID0gRVJSX1BUUih+WDg2RU1VTF9SRVRSWSk7Cj4gLSAgICAgICAgICAg IGdvdG8gb3V0Owo+ICsgICAgICAgICAgICBlcnIgPSB1cGRhdGVfbWFwX2VycihlcnIsIEVSUl9Q VFIoflg4NkVNVUxfUkVUUlkpKTsKPiArICAgICAgICAgICAgY29udGludWU7Cj4gCj4gICAgICAg ICAgZGVmYXVsdDoKPiAtICAgICAgICAgICAgZ290byB1bmhhbmRsZWFibGU7Cj4gKyAgICAgICAg ICAgIGVyciA9IHVwZGF0ZV9tYXBfZXJyKGVyciwgRVJSX1BUUih+WDg2RU1VTF9VTkhBTkRMRUFC TEUpKTsKPiArICAgICAgICAgICAgY29udGludWU7Cj4gICAgICAgICAgfQo+IAo+ICAgICAgICAg ICptZm4rKyA9IHBhZ2VfdG9fbWZuKHBhZ2UpOwo+IAo+ICAgICAgICAgIGlmICggcDJtX2lzX2Rp c2NhcmRfd3JpdGUocDJtdCkgKQo+IC0gICAgICAgIHsKPiAtICAgICAgICAgICAgZXJyID0gRVJS X1BUUih+WDg2RU1VTF9PS0FZKTsKPiAtICAgICAgICAgICAgZ290byBvdXQ7Cj4gLSAgICAgICAg fQo+ICsgICAgICAgICAgICBlcnIgPSB1cGRhdGVfbWFwX2VycihlcnIsIEVSUl9QVFIoflg4NkVN VUxfT0tBWSkpOwo+ICAgICAgfQo+IAo+ICsgICAgaWYgKCBlcnIgIT0gWkVST19CTE9DS19QVFIg KQo+ICsgICAgICAgIGdvdG8gb3V0Owo+ICsKPiAgICAgIC8qIEVudGlyZSBhY2Nlc3Mgd2l0aGlu IGEgc2luZ2xlIGZyYW1lPyAqLwo+ICAgICAgaWYgKCBucl9mcmFtZXMgPT0gMSApCj4gICAgICAg ICAgbWFwcGluZyA9IG1hcF9kb21haW5fcGFnZShodm1lbXVsX2N0eHQtPm1mblswXSk7Cj4gQEAg LTYzOSw2ICs2NTQsNyBAQCBzdGF0aWMgdm9pZCAqaHZtZW11bF9tYXBfbGluZWFyX2FkZHIoCj4g ICAgICByZXR1cm4gbWFwcGluZyArIChsaW5lYXIgJiB+UEFHRV9NQVNLKTsKPiAKPiAgIHVuaGFu ZGxlYWJsZToKPiArICAgIEFTU0VSVChlcnIgPT0gWkVST19CTE9DS19QVFIpOwo+ICAgICAgZXJy ID0gRVJSX1BUUih+WDg2RU1VTF9VTkhBTkRMRUFCTEUpOwo+IAo+ICAgb3V0Ogo+IAo+IAo+IAoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlz dHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=