From: Joao Pinto <Joao.Pinto@synopsys.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] net: stmmac: adding multiple buffers for rx
Date: Wed, 19 Apr 2017 15:24:55 +0000 [thread overview]
Message-ID: <6eaea136-5b51-b7ea-94b0-0479955e7abd@synopsys.com> (raw)
In-Reply-To: <20170412194946.GA28352@mwanda>
Hi Dan,
Às 8:49 PM de 4/12/2017, Dan Carpenter escreveu:
> Hello Joao Pinto,
>
> The patch 54139cf3bb33: "net: stmmac: adding multiple buffers for rx"
> from Apr 6, 2017, leads to the following static checker warning:
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1274 init_dma_rx_desc_rings()
> warn: always true condition '(queue >= 0) => (0-u32max >= 0)'
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> 1270
> 1271 return 0;
> 1272
> 1273 err_init_rx_buffers:
> 1274 while (queue >= 0) {
> ^^^^^^^^^^
> This is harmless because of the break statement later, but slightly
> annoying because of the static checker warning.
>
> 1275 while (--i >= 0)
> 1276 stmmac_free_rx_buffer(priv, queue, i);
> 1277
> 1278 if (queue = 0)
> 1279 break;
> 1280
> 1281 i = DMA_RX_SIZE;
> 1282 queue--;
> 1283 }
> 1284
> 1285 return ret;
> 1286 }
>
> regards,
> dan carpenter
>
Sorry for delayed answer. I will fix this ASAP. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-04-19 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 19:49 [bug report] net: stmmac: adding multiple buffers for rx Dan Carpenter
2017-04-19 15:24 ` Joao Pinto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eaea136-5b51-b7ea-94b0-0479955e7abd@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.