All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Tsoy <alexander@tsoy.me>
To: Gregor Pintar <grpintar@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, Roope Salmi <rpsalmi@gmail.com>
Subject: Re: [PATCH 1/2] ALSA: usb-audio: Improve frames size computation
Date: Fri, 24 Apr 2020 19:43:58 +0300	[thread overview]
Message-ID: <6eb7b878b82659f7e9b9859186dfe40320402438.camel@tsoy.me> (raw)
In-Reply-To: <CAOPXC2kF-k9xH8KhP_s+RmebgTdZW7avn9uedMRAooOB5WhzCA@mail.gmail.com>

В Пт, 24/04/2020 в 17:02 +0200, Gregor Pintar пишет:
> On Fri, Apr 24, 2020 at 4:24 AM Alexander Tsoy <alexander@tsoy.me>
> wrote:
> > This patch fixes this issue by implementing a different algorithm
> > for
> > frame size computation. It is based on accumulating of the
> > remainders
> > from division fs/fps and it doesn't accumulate errors over time.
> > This
> > new method is enabled for synchronous and adaptive playback
> > endpoints.
> > 
> 
> Hm, I still sometimes get click usually in about first 2 seconds,
> but it is hard to reproduce.

I wonder if it's because the driver doesn't honor wLockDelay. Anyway,
the second patch can be reverted if there are still issues with 2nd gen
Scarletts.


  reply	other threads:[~2020-04-24 16:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24  2:24 [PATCH 1/2] ALSA: usb-audio: Improve frames size computation Alexander Tsoy
2020-04-24  2:24 ` [PATCH 2/2] ALSA: usb-audio: Remove async workaround for Scarlett 2nd gen Alexander Tsoy
2020-04-24  6:28   ` Takashi Iwai
2020-04-24 15:21   ` Gregor Pintar
2020-04-24  6:28 ` [PATCH 1/2] ALSA: usb-audio: Improve frames size computation Takashi Iwai
2020-04-24  9:19 ` Pavel Hofman
2020-04-24  9:29   ` Alexander Tsoy
2020-04-24  9:39     ` Pavel Hofman
2020-04-24 15:02 ` Gregor Pintar
2020-04-24 16:43   ` Alexander Tsoy [this message]
2020-04-25 16:50     ` Gregor Pintar
2020-04-25 18:09       ` Gregor Pintar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6eb7b878b82659f7e9b9859186dfe40320402438.camel@tsoy.me \
    --to=alexander@tsoy.me \
    --cc=alsa-devel@alsa-project.org \
    --cc=grpintar@gmail.com \
    --cc=rpsalmi@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.