From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel@lists.xen.org
Cc: jbeulich@suse.com
Subject: Re: [PATCH 1/3] x86/vpmu: Calculate vpmu_enabled() based on vpmu_mode value
Date: Mon, 13 Feb 2017 10:33:27 +0000 [thread overview]
Message-ID: <6ed07657-78d0-eb91-6bfb-b4ef74b26702@citrix.com> (raw)
In-Reply-To: <1486952997-19445-2-git-send-email-boris.ostrovsky@oracle.com>
On 13/02/17 02:29, Boris Ostrovsky wrote:
> vpmu_enabled() is currently reported based on VPMU_CONTEXT_ALLOCATED
> bit of VPMU's flags. This presents a problem on Intel processors where
> VPMU context is allocated lazily, during the first access to VPMU MSRs.
> With such delayed allocation we, for example, cannot properly report
> CPUID's leaf 0xa since it is likely that the leaf is queried by a
> guest before the guest attempts ro read or write the MSR.
>
> Instead of keying vpmu_enabled() off the flags we should compute it
> based on vpmu_mode.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
s/bool_t/bool/
Otherwise, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
I can fix this up on commit if there are no other issues.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-13 10:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 2:29 [PATCH 0/3] VPMU fixes Boris Ostrovsky
2017-02-13 2:29 ` [PATCH 1/3] x86/vpmu: Calculate vpmu_enabled() based on vpmu_mode value Boris Ostrovsky
2017-02-13 10:33 ` Andrew Cooper [this message]
2017-02-13 12:50 ` Jan Beulich
2017-02-13 14:38 ` Boris Ostrovsky
2017-02-13 14:44 ` Jan Beulich
2017-02-13 15:02 ` Boris Ostrovsky
2017-02-13 2:29 ` [PATCH 2/3] x86/vpmu: Decrement vpmu_count early in vpmu_destroy() Boris Ostrovsky
2017-02-13 10:38 ` Andrew Cooper
2017-02-13 14:22 ` Boris Ostrovsky
2017-02-13 2:29 ` [PATCH 3/3] x86: Adjust which files need vpmu.h Boris Ostrovsky
2017-02-13 2:46 ` Tian, Kevin
2017-02-13 10:38 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed07657-78d0-eb91-6bfb-b4ef74b26702@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.